Unblock domain service specs/refactor (#2867)

* Add spec for unblock domain service

* Refactor UnblockDomainService
This commit is contained in:
Matt Jankowski 2017-05-07 08:44:28 -04:00 committed by Eugen Rochko
parent ada8a6cb77
commit b8ba719f73
2 changed files with 66 additions and 10 deletions

View File

@ -1,17 +1,27 @@
# frozen_string_literal: true # frozen_string_literal: true
class UnblockDomainService < BaseService class UnblockDomainService < BaseService
attr_accessor :domain_block
def call(domain_block, retroactive) def call(domain_block, retroactive)
if retroactive @domain_block = domain_block
accounts = Account.where(domain: domain_block.domain).in_batches process_retroactive_updates if retroactive
if domain_block.silence?
accounts.update_all(silenced: false)
else
accounts.update_all(suspended: false)
end
end
domain_block.destroy domain_block.destroy
end end
def process_retroactive_updates
blocked_accounts.in_batches.update_all(update_options)
end
def blocked_accounts
Account.where(domain: domain_block.domain)
end
def update_options
{ domain_block_impact => false }
end
def domain_block_impact
domain_block.silence? ? :silenced : :suspended
end
end end

View File

@ -0,0 +1,46 @@
# frozen_string_literal: true
require 'rails_helper'
describe UnblockDomainService do
subject { described_class.new }
describe 'call' do
before do
@silenced = Fabricate(:account, domain: 'example.com', silenced: true)
@suspended = Fabricate(:account, domain: 'example.com', suspended: true)
@domain_block = Fabricate(:domain_block, domain: 'example.com')
end
context 'without retroactive' do
it 'removes the domain block' do
subject.call(@domain_block, false)
expect_deleted_domain_block
end
end
context 'with retroactive' do
it 'unsilences accounts and removes block' do
@domain_block.update(severity: :silence)
subject.call(@domain_block, true)
expect_deleted_domain_block
expect(@silenced.reload.silenced).to be false
expect(@suspended.reload.suspended).to be true
end
it 'unsuspends accounts and removes block' do
@domain_block.update(severity: :suspend)
subject.call(@domain_block, true)
expect_deleted_domain_block
expect(@suspended.reload.suspended).to be false
expect(@silenced.reload.silenced).to be true
end
end
end
def expect_deleted_domain_block
expect { @domain_block.reload }.to raise_error(ActiveRecord::RecordNotFound)
end
end