Cover Admin::DomainBlocksController more (#3329)

Also domain_block fabricator now sets unique domains
This commit is contained in:
Akihiko Odaki (@fn_aki@pawoo.net) 2017-06-26 04:42:36 +09:00 committed by Eugen Rochko
parent 87efa38721
commit 8f991831b8
2 changed files with 31 additions and 5 deletions

View File

@ -8,17 +8,30 @@ RSpec.describe Admin::DomainBlocksController, type: :controller do
end end
describe 'GET #index' do describe 'GET #index' do
it 'returns http success' do around do |example|
get :index default_per_page = DomainBlock.default_per_page
DomainBlock.paginates_per 1
example.run
DomainBlock.paginates_per default_per_page
end
it 'renders domain blocks' do
2.times { Fabricate(:domain_block) }
get :index, params: { page: 2 }
assigned = assigns(:domain_blocks)
expect(assigned.count).to eq 1
expect(assigned.klass).to be DomainBlock
expect(response).to have_http_status(:success) expect(response).to have_http_status(:success)
end end
end end
describe 'GET #new' do describe 'GET #new' do
it 'returns http success' do it 'assigns a new domain block' do
get :new get :new
expect(assigns(:domain_block)).to be_instance_of(DomainBlock)
expect(response).to have_http_status(:success) expect(response).to have_http_status(:success)
end end
end end
@ -33,13 +46,25 @@ RSpec.describe Admin::DomainBlocksController, type: :controller do
end end
describe 'POST #create' do describe 'POST #create' do
it 'blocks the domain' do it 'blocks the domain when succeeded to save' do
allow(DomainBlockWorker).to receive(:perform_async).and_return(true) allow(DomainBlockWorker).to receive(:perform_async).and_return(true)
post :create, params: { domain_block: { domain: 'example.com', severity: 'silence' } } post :create, params: { domain_block: { domain: 'example.com', severity: 'silence' } }
expect(DomainBlockWorker).to have_received(:perform_async) expect(DomainBlockWorker).to have_received(:perform_async)
expect(flash[:notice]).to eq I18n.t('admin.domain_blocks.created_msg')
expect(response).to redirect_to(admin_domain_blocks_path) expect(response).to redirect_to(admin_domain_blocks_path)
end end
it 'renders new when failed to save' do
Fabricate(:domain_block, domain: 'example.com')
allow(DomainBlockWorker).to receive(:perform_async).and_return(true)
post :create, params: { domain_block: { domain: 'example.com', severity: 'silence' } }
expect(DomainBlockWorker).not_to have_received(:perform_async)
expect(response).to render_template :new
end
end end
describe 'DELETE #destroy' do describe 'DELETE #destroy' do
@ -50,6 +75,7 @@ RSpec.describe Admin::DomainBlocksController, type: :controller do
delete :destroy, params: { id: domain_block.id, domain_block: { retroactive: '1' } } delete :destroy, params: { id: domain_block.id, domain_block: { retroactive: '1' } }
expect(service).to have_received(:call).with(domain_block, true) expect(service).to have_received(:call).with(domain_block, true)
expect(flash[:notice]).to eq I18n.t('admin.domain_blocks.destroyed_msg')
expect(response).to redirect_to(admin_domain_blocks_path) expect(response).to redirect_to(admin_domain_blocks_path)
end end
end end

View File

@ -1,3 +1,3 @@
Fabricator(:domain_block) do Fabricator(:domain_block) do
domain "example.com" domain { sequence(:domain) { |i| "#{i}#{Faker::Internet.domain_name}" } }
end end