Browse Source

make it not return http 400 when passing and empty source argument (#12259)

* make it not return http 400 when passing and empty source argument

* create a spec for the empty source hash bug

* compact checks for nil, empty? parameters

* use nil.blank? instead checking for nil
cybrespace-3.1
Jennifer Glauche 3 years ago committed by Eugen Rochko
parent
commit
fd93a9c871
  1. 2
      app/controllers/api/v1/accounts/credentials_controller.rb
  2. 13
      spec/controllers/api/v1/accounts/credentials_controller_spec.rb

2
app/controllers/api/v1/accounts/credentials_controller.rb

@ -25,7 +25,7 @@ class Api::V1::Accounts::CredentialsController < Api::BaseController @@ -25,7 +25,7 @@ class Api::V1::Accounts::CredentialsController < Api::BaseController
end
def user_settings_params
return nil unless params.key?(:source)
return nil if params[:source].blank?
source_params = params.require(:source)

13
spec/controllers/api/v1/accounts/credentials_controller_spec.rb

@ -59,6 +59,19 @@ describe Api::V1::Accounts::CredentialsController do @@ -59,6 +59,19 @@ describe Api::V1::Accounts::CredentialsController do
end
end
describe 'with empty source list' do
before do
patch :update, params: {
display_name: "I'm a cat",
source: {},
}, as: :json
end
it 'returns http success' do
expect(response).to have_http_status(200)
end
end
describe 'with invalid data' do
before do
patch :update, params: { note: 'This is too long. ' * 30 }

Loading…
Cancel
Save