cybrespace/mastodon
4
3
Fork 3
Code Issues 7 Pull requests Releases Activity

Ignore empty response in ActivityPub::FetchRemoteStatusService (#4661)

Browse source 
* Ignore empty response in ActivityPub::FetchRemoteStatusService

This fixes `NoMethodError: undefined method `[]' for nil:NilClass` error.

* Check json.nil? in JsonLdHelper#supported_context?
This commit is contained in:
unarist 2017-08-23 03:00:49 +09:00 • committed by Eugen Rochko
parent 871c0d251a
commit 5927b43c0f
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/helpers/jsonld_helper.rb
View file

@ -14,7 +14,7 @@ module JsonLdHelper
end
def supported_context?(json)
equals_or_includes?(json['@context'], ActivityPub::TagManager::CONTEXT)
!json.nil? && equals_or_includes?(json['@context'], ActivityPub::TagManager::CONTEXT)
end
def fetch_resource(uri)

2
app/services/fetch_atom_service.rb
View file

@ -82,7 +82,7 @@ class FetchAtomService < BaseService
def supported_activity?(body)
json = body_to_json(body)
return false if json.nil? || !supported_context?(json)
return false unless supported_context?(json)
json['type'] == 'Person' ? json['inbox'].present? : true
end
end