cybrespace
/
mastodon
4
3
Fork 3
Code Issues 7 Pull Requests Releases Activity

Improve performance of account_media_status_ids (#6729)

This commit is contained in:
abcang 2018-03-11 01:44:26 +09:00 committed by Eugen Rochko
parent 36579bac88
commit 37b043d447
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/controllers/api/v1/accounts/statuses_controller.rb
View File

@ -51,7 +51,13 @@ class Api::V1::Accounts::StatusesController < Api::BaseController
end
def account_media_status_ids
@account.media_attachments.attached.reorder(nil).select(:status_id).distinct
# `SELECT DISTINCT id, updated_at` is too slow, so pluck ids at first, and then select id, updated_at with ids.
# Also, Avoid getting slow by not narrowing down by `statuses.account_id`.
# When narrowing down by `statuses.account_id`, `index_statuses_20180106` will be used
# and the table will be joined by `Merge Semi Join`, so the query will be slow.
Status.joins(:media_attachments).merge(@account.media_attachments).permitted_for(@account, current_account)
.paginate_by_max_id(limit_param(DEFAULT_STATUSES_LIMIT), params[:max_id], params[:since_id])
.reorder(id: :desc).distinct(:id).pluck(:id)
end
def pinned_scope