Clean up admin UI for accounts (#6004)

* Add staff filter to admin UI for accounts, remove obsolete columns

* Only display OStatus section in admin UI for accounts when OStatus data
This commit is contained in:
Eugen Rochko 2017-12-13 12:15:10 +01:00 committed by GitHub
parent 155e211dd0
commit 20a6584d2d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 17 additions and 20 deletions

View File

@ -89,7 +89,8 @@ module Admin
:username, :username,
:display_name, :display_name,
:email, :email,
:ip :ip,
:staff
) )
end end
end end

View File

@ -1,7 +1,7 @@
# frozen_string_literal: true # frozen_string_literal: true
module Admin::FilterHelper module Admin::FilterHelper
ACCOUNT_FILTERS = %i(local remote by_domain silenced suspended recent username display_name email ip).freeze ACCOUNT_FILTERS = %i(local remote by_domain silenced suspended recent username display_name email ip staff).freeze
REPORT_FILTERS = %i(resolved account_id target_account_id).freeze REPORT_FILTERS = %i(resolved account_id target_account_id).freeze
INVITE_FILTER = %i(available expired).freeze INVITE_FILTER = %i(available expired).freeze

View File

@ -45,6 +45,8 @@ class AccountFilter
else else
Account.default_scoped Account.default_scoped
end end
when 'staff'
accounts_with_users.merge User.staff
else else
raise "Unknown filter: #{key}" raise "Unknown filter: #{key}"
end end

View File

@ -4,22 +4,11 @@
%td.domain %td.domain
- unless account.local? - unless account.local?
= link_to account.domain, admin_accounts_path(by_domain: account.domain) = link_to account.domain, admin_accounts_path(by_domain: account.domain)
%td.protocol %td
- unless account.local? - if account.local?
= t("admin.accounts.roles.#{account.user&.role}")
- else
= account.protocol.humanize = account.protocol.humanize
%td.confirmed
- if account.local?
- if account.user_confirmed?
%i.fa.fa-check
- else
%i.fa.fa-times
%td.subscribed
- if account.local?
= t('admin.accounts.location.local')
- elsif account.subscribed?
%i.fa.fa-check
- else
%i.fa.fa-times
%td %td
= table_link_to 'circle', t('admin.accounts.web'), web_path("accounts/#{account.id}") = table_link_to 'circle', t('admin.accounts.web'), web_path("accounts/#{account.id}")
= table_link_to 'globe', t('admin.accounts.public'), TagManager.instance.url_for(account) = table_link_to 'globe', t('admin.accounts.public'), TagManager.instance.url_for(account)

View File

@ -30,6 +30,11 @@
= filter_link_to t('admin.accounts.moderation.suspended'), {suspended: nil}, {suspended: '1'} = filter_link_to t('admin.accounts.moderation.suspended'), {suspended: nil}, {suspended: '1'}
- else - else
= filter_link_to t('admin.accounts.moderation.suspended'), suspended: '1' = filter_link_to t('admin.accounts.moderation.suspended'), suspended: '1'
.filter-subset
%strong= t('admin.accounts.role')
%ul
%li= filter_link_to t('admin.accounts.moderation.all'), staff: nil
%li= filter_link_to t('admin.accounts.roles.staff'), staff: '1'
.filter-subset .filter-subset
%strong= t('admin.accounts.order.title') %strong= t('admin.accounts.order.title')
%ul %ul
@ -56,9 +61,7 @@
%tr %tr
%th= t('admin.accounts.username') %th= t('admin.accounts.username')
%th= t('admin.accounts.domain') %th= t('admin.accounts.domain')
%th= t('admin.accounts.protocol') %th
%th= t('admin.accounts.confirmed')
%th= fa_icon 'paper-plane-o'
%th %th
%tbody %tbody
= render @accounts = render @accounts

View File

@ -104,7 +104,7 @@
- else - else
= link_to t('admin.accounts.perform_full_suspension'), admin_account_suspension_path(@account.id), method: :post, data: { confirm: t('admin.accounts.are_you_sure') }, class: 'button' if can?(:suspend, @account) = link_to t('admin.accounts.perform_full_suspension'), admin_account_suspension_path(@account.id), method: :post, data: { confirm: t('admin.accounts.are_you_sure') }, class: 'button' if can?(:suspend, @account)
- unless @account.local? - if !@account.local? && @account.hub_url.present?
%hr %hr
%h3 OStatus %h3 OStatus
@ -132,6 +132,7 @@
- if @account.subscribed? - if @account.subscribed?
= link_to t('admin.accounts.unsubscribe'), unsubscribe_admin_account_path(@account.id), method: :post, class: 'button negative' if can?(:unsubscribe, @account) = link_to t('admin.accounts.unsubscribe'), unsubscribe_admin_account_path(@account.id), method: :post, class: 'button negative' if can?(:unsubscribe, @account)
- if !@account.local? && @account.inbox_url.present?
%hr %hr
%h3 ActivityPub %h3 ActivityPub

View File

@ -116,6 +116,7 @@ en:
roles: roles:
admin: Administrator admin: Administrator
moderator: Moderator moderator: Moderator
staff: Staff
user: User user: User
salmon_url: Salmon URL salmon_url: Salmon URL
search: Search search: Search