mastodon/spec
Claire c8dbbd60eb Fix error-prone SQL queries (#15828)
* Fix error-prone SQL queries in Account search

While this code seems to not present an actual vulnerability, one could
easily be introduced by mistake due to how the query is built.

This PR parameterises the `to_tsquery` input to make the query more robust.

* Harden code for Status#tagged_with_all and Status#tagged_with_none

Those two scopes aren't used in a way that could be vulnerable to an SQL
injection, but keeping them unchanged might be a hazard.

* Remove unneeded spaces surrounding tsquery term

* Please CodeClimate

* Move advanced_search_for SQL template to its own function

This avoids one level of indentation while making clearer that the SQL template
isn't build from all the dynamic parameters of advanced_search_for.

* Add tests covering tagged_with, tagged_with_all and tagged_with_none

* Rewrite tagged_with_none to avoid multiple joins and make it more robust

* Remove obsolete brakeman warnings

* Revert "Remove unneeded spaces surrounding tsquery term"

The two queries are not strictly equivalent.

This reverts commit 86f16c537e06c6ba4a8b250f25dcce9f049023ff.
2022-02-02 23:30:15 +01:00
..
controllers Fix AccountNote not having a maximum length (#16942) 2021-11-06 00:17:05 +01:00
fabricators Add canonical e-mail blocks for suspended accounts (#16049) 2021-04-17 03:14:25 +02:00
features Add submit button to the top of preferences pages (#13068) 2020-03-08 16:04:03 +01:00
fixtures Change references to tootsuite/mastodon to mastodon/mastodon (#16491) 2021-11-05 23:46:24 +01:00
helpers Change RTL detection to rely on unicode-bidi paragraph by paragraph (#14573) 2020-12-15 12:56:43 +01:00
lib Fix addressing of remote groups' followers (#16700) 2021-11-05 20:28:20 +01:00
mailers Add Ruby 3.0 support (#16046) 2021-05-06 14:22:54 +02:00
models Fix error-prone SQL queries (#15828) 2022-02-02 23:30:15 +01:00
policies Add support for reversible suspensions through ActivityPub (#14989) 2020-11-08 00:28:39 +01:00
presenters Change references to tootsuite/mastodon to mastodon/mastodon (#16491) 2021-11-05 23:46:24 +01:00
requests Further preparation for Rails 6 (#15916) 2021-03-19 02:45:34 +01:00
routing Move create/destroy actions for api/v1/statuses to namespace (#3678) 2017-06-10 09:39:26 +02:00
serializers/activitypub Fix account URI in UpdatePollSerializer (#11194) 2019-06-27 19:41:55 +02:00
services Fix filtering DMs from non-followed users (#17042) 2021-11-26 01:22:33 +01:00
support Fix base64-encoded file uploads not being possible (#12748) 2020-01-04 01:54:07 +01:00
validators Add canonical e-mail blocks for suspended accounts (#16049) 2021-04-17 03:14:25 +02:00
views Change references to tootsuite/mastodon to mastodon/mastodon (#16491) 2021-11-05 23:46:24 +01:00
workers Fix followers synchronization mechanism not working when URI has empty path (#16510) 2022-01-31 10:59:00 +01:00
rails_helper.rb Add WebAuthn as an alternative 2FA method (#14466) 2020-08-24 16:46:27 +02:00
spec_helper.rb Move rspec examples to tmp dir (#12539) 2019-12-02 19:55:08 +01:00