Feat add validation for report comment: characters under 1000 valid (#4833)
This commit is contained in:
		
							parent
							
								
									5264496240
								
							
						
					
					
						commit
						8185f98872
					
				
					 2 changed files with 16 additions and 0 deletions
				
			
		| 
						 | 
					@ -22,6 +22,8 @@ class Report < ApplicationRecord
 | 
				
			||||||
  scope :unresolved, -> { where(action_taken: false) }
 | 
					  scope :unresolved, -> { where(action_taken: false) }
 | 
				
			||||||
  scope :resolved,   -> { where(action_taken: true) }
 | 
					  scope :resolved,   -> { where(action_taken: true) }
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					  validates :comment, length: { maximum: 1000 }
 | 
				
			||||||
 | 
					
 | 
				
			||||||
  def statuses
 | 
					  def statuses
 | 
				
			||||||
    Status.where(id: status_ids).includes(:account, :media_attachments, :mentions)
 | 
					    Status.where(id: status_ids).includes(:account, :media_attachments, :mentions)
 | 
				
			||||||
  end
 | 
					  end
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
| 
						 | 
					@ -21,4 +21,18 @@ describe Report do
 | 
				
			||||||
      expect(report.media_attachments).to eq [media_attachment]
 | 
					      expect(report.media_attachments).to eq [media_attachment]
 | 
				
			||||||
    end
 | 
					    end
 | 
				
			||||||
  end
 | 
					  end
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					  describe 'validatiions' do
 | 
				
			||||||
 | 
					    it 'has a valid fabricator' do
 | 
				
			||||||
 | 
					      report = Fabricate(:report)
 | 
				
			||||||
 | 
					      report.valid?
 | 
				
			||||||
 | 
					      expect(report).to be_valid
 | 
				
			||||||
 | 
					    end
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    it 'is invalid if comment is longer than 1000 characters' do
 | 
				
			||||||
 | 
					      report = Fabricate.build(:report, comment: Faker::Lorem.characters(1001))
 | 
				
			||||||
 | 
					      report.valid?
 | 
				
			||||||
 | 
					      expect(report).to model_have_error_on_field(:comment)
 | 
				
			||||||
 | 
					    end
 | 
				
			||||||
 | 
					  end
 | 
				
			||||||
end
 | 
					end
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
		Loading…
	
	Add table
		
		Reference in a new issue