Commit Graph

572 Commits

Author SHA1 Message Date
Marcin Mielniczuk 9328475c22 Pylint CI improvements
* Move the pylint CI configuration to a separate script
* Update pylint in CI to 2.1.1
* Add pycurl to pylint whitelist
2018-10-07 00:46:58 +02:00
Philipp Hörist 38ac6a0637 Pass correct show state 2018-10-07 00:46:58 +02:00
Philipp Hörist 6cd619675f Fix passing wrong type 2018-10-07 00:46:58 +02:00
Philipp Hörist 50c670e61b Refactor Chat State Notifications
- Move code into chatstate module
- Refactor most of the code, make it much simpler
2018-10-07 00:46:57 +02:00
Daniel Brötzmann 0af65954be Unify Emoticon and Emoji strings 2018-10-07 00:46:57 +02:00
Philipp Hörist db34877191 MAM: Up the requested page size 2018-10-07 00:46:56 +02:00
Philipp Hörist dd3bbf2bb7 Request security catalog from the barejid
- Some Code/UI cleanup
2018-10-07 00:46:56 +02:00
Philipp Hörist e292b78a5d Fix security labels 2018-10-07 00:46:56 +02:00
Philipp Hörist cb1be1621d Fix Dark Theme switch
- Move css_config to gtk module
- Add Combobox for overriding the current session setting
- Move theme methods to css_config
2018-10-07 00:46:55 +02:00
Philipp Hörist ec76d8ac3b Only use absolute imports from gtk module
- This reduces import cycles
2018-10-07 00:46:55 +02:00
Yann Leboulanger 3ab7f92856 handle error message from MUC correctly. Fixes #9280 2018-10-07 00:46:54 +02:00
Philipp Hörist ad5f59ba49 configpaths: Add get_plugin_dirs() method
This helps with mypy because otherwise get() has multiple return types

This reduces our usage of cast()
2018-10-07 00:46:54 +02:00
Philipp Hörist 5db0178a15 Windows: Add debug logging switch in preferences
If debug logging is enabled verbose output is redirected to a file
in the user dir
2018-10-07 00:46:54 +02:00
Philipp Hörist 3bdcd53ff5 Dont parse our own nick on sent carbons
Fixes #9051
2018-10-07 00:46:53 +02:00
Philipp Hörist 9bbc2eceb3 Fix rest of mypy errors
- This allows us to run mypy on the full gajim folder
2018-10-07 00:46:53 +02:00
Philipp Hörist eb8093d25f Add annotations
- Remove some unused vars from app
2018-10-07 00:46:52 +02:00
Philipp Hörist fa45935c11 Make SQL INSERT querys more resilient
Specify the column in which we insert otherwise downgrading Gajim is
not possible anymore because the query breaks if we modified the column
count in future
2018-10-07 00:46:51 +02:00
Philipp Hörist 4c38a309fc Fix pylint errors
- deprecated-method
- anomalous-backslash-in-string
- cell-var-from-loop
- undefined-loop-variable
2018-10-07 00:46:51 +02:00
Philipp Hörist 16f7620204 pylint W0143 is not available on pylint < 2.0 2018-10-07 00:46:50 +02:00
Philipp Hörist 60173c06db Fix pylint errors
- duplicate-key
- eval-used
- comparison-with-callable
2018-10-07 00:46:50 +02:00
Philipp Hörist 64487929a6 Fix pylint errors
- pointless-statement
- pointless-string-statement
- unnecessary-lambda
2018-10-07 00:46:50 +02:00
Philipp Hörist 99efc4a9b4 Fix pylint errors
- consider-using-enumerate
- unneeded-not
- unidiomatic-typecheck
2018-10-07 00:46:49 +02:00
Philipp Hörist c156f02cc0 Fix redefined-builtin pylint errors 2018-10-07 00:46:48 +02:00
Philipp Hörist f12dfb811d Fix trailing-whitespace pylint errors 2018-10-07 00:46:48 +02:00
Philipp Hörist e842298724 Fix bad-whitespace pylint errors 2018-10-07 00:46:48 +02:00
Philipp Hörist a65d88c1cd Fix multiple-statements pylint errors 2018-10-07 00:46:47 +02:00
Philipp Hörist 5d1de209a8 Fix singleton-comparison pylint errors 2018-10-07 00:46:47 +02:00
Philipp Hörist dad5331bf2 Fix no-else-return pylint errors 2018-10-07 00:46:46 +02:00
Philipp Hörist b9edcceb4c Fix redefined-argument-from-local pylint errors 2018-10-07 00:46:45 +02:00
Philipp Hörist c5ca89558d keys() doesnt return list() in python3 2018-10-07 00:46:45 +02:00
Philipp Hörist bc70b24d80 Fix trailing-comma-tuple pylint errors 2018-10-07 00:46:45 +02:00
Philipp Hörist acb0bacc09 Fix simplifiable-if-statement pylint errors 2018-10-07 00:46:45 +02:00
Philipp Hörist defe74cc06 Fix literal-comparison pylint errors 2018-10-07 00:46:45 +02:00
Philipp Hörist 4fb78dfbfa Use keys() iteration if we modify the dict 2018-10-07 00:46:44 +02:00
Philipp Hörist c4bd6d6ab2 Fix consider-iterating-dictionary pylint errors 2018-10-07 00:46:44 +02:00
Philipp Hörist 407dc04b28 Fix pylint errors 2018-10-07 00:46:44 +02:00
Philipp Hörist cebd83d436 Fix unused-variable pylint errors 2018-10-07 00:46:44 +02:00
Philipp Hörist 6305fc69b9 Fix logging-not-lazy pylint errors 2018-10-07 00:46:43 +02:00
Philipp Hörist 5ff08236bb Fix bare-except pylint errors 2018-10-07 00:46:42 +02:00
Philipp Hörist 1c7f347a08 Fix missing time attribute
This was removed by accident
2018-10-07 00:46:42 +02:00
Philipp Hörist eb6f5761ec Fix redefined-outer-name pylint errors 2018-10-07 00:46:42 +02:00
Philipp Hörist a6525e19a2 Fix superfluous-parens pylint errors 2018-10-07 00:46:41 +02:00
Philipp Hörist 54776f5877 Fix evaluation for subject change 2018-10-07 00:46:41 +02:00
Philipp Hörist 0b5c8a3b46 Dont retract pep items on UserXEPs
This leads to multiple problems

1. We cant assume only items with id='current' are stored in the node
which would lead to retracting 'current' but another item would become
the last published and sent to users

2. Even if we have a SingletonNode retracting the only item means the Node
would be empty and offline clients would not receive the last published item
on coming online, because there is no item anymore

Instead we always publish an empty item from now on
2018-10-07 00:46:41 +02:00
Philipp Hörist f00d8087ad Fix sending empty pep data 2018-10-07 00:46:41 +02:00
Philipp Hörist 7cf53e901b Fix useless-object-inheritance pylint errors 2018-10-07 00:46:40 +02:00
Philipp Hörist d011be2d89 Fix unsued-import pylint errors 2018-10-07 00:46:40 +02:00
Philipp Hörist a3c687dae1 Fix len-as-condition pylint errors 2018-10-07 00:46:39 +02:00
Philipp Hörist e953820ff8 Zeroconf: Store time of outgoing messages 2018-10-07 00:46:39 +02:00
Philipp Hörist 77c9b3a98d Add annotations and fix pylint/mypy errors 2018-10-07 00:46:38 +02:00