Fix pylint errors

- duplicate-key
- eval-used
- comparison-with-callable

gajim/common/connection.py

@@ -1031,7 +1031,7 @@ class Connection(CommonConnection, ConnectionHandlers):
         nbxmpp.dispatcher_nb.DEFAULT_TIMEOUT_SECONDS = \
             self.try_connecting_for_foo_secs
         # FIXME: this is a hack; need a better way
-        if self.on_connect_success == self._on_new_account:
+        if self.on_connect_success == self._on_new_account:  # pylint: disable=W0143
             con.RegisterDisconnectHandler(self._on_new_account)
 
         if self.client_cert and app.config.get_per('accounts', self.name,

gajim/gui_interface.py

@@ -1873,18 +1873,19 @@ class Interface:
 ################################################################################
 
     def join_gc_room(self, account, room_jid, nick, password, minimize=False,
-    is_continued=False):
+                     is_continued=False):
         """
         Join the room immediately
         """
 
         if app.contacts.get_contact(account, room_jid) and \
         not app.contacts.get_contact(account, room_jid).is_groupchat():
-            ErrorDialog(_('This is not a group chat'),
+            ErrorDialog(
+                _('This is not a group chat'),
                 _('%(room_jid)s is already in your roster. Please check '
-                'if %(room_jid)s is a correct group chat name. If it is, '
-                'delete it from your roster and try joining the group chat '
-                'again.') % {'room_jid': room_jid, 'room_jid': room_jid})
+                  'if %(room_jid)s is a correct group chat name. If it is, '
+                  'delete it from your roster and try joining the group chat '
+                  'again.') % {'room_jid': room_jid})
             return
 
         if not nick:

gajim/gui_menu_builder.py

@@ -41,7 +41,7 @@ def build_resources_submenu(contacts, account, action, room_jid=None,
         item = Gtk.MenuItem.new_with_label(
             '%s (%s)' % (c.resource, str(c.priority)))
         sub_menu.append(item)
-
+        # pylint: disable=W0143
         if action == roster.on_invite_to_room:
             item.connect('activate', action, [(c, account)], room_jid,
                     room_account, c.resource)

gajim/htmltextview.py

@@ -183,7 +183,7 @@ INLINE = INLINE_PHRASAL.union(INLINE_PRES).union(INLINE_STRUCT)
 LIST_ELEMS = set('dl, ol, ul'.split(', '))
 
 for _name in BLOCK_HEAD:
-    _num = eval(_name[1])
+    _num = int(_name[1])
     _header_size = (_num - 1) // 2
     _weight = (_num - 1) % 2
     _element_styles[_name] = '; font-size: %s; %s' % (('large', 'medium', 'small')[_header_size],