Commit Graph

15737 Commits

Author SHA1 Message Date
Philipp Hörist 08cfe09ae4 Fix pylint errors
- used-before-assignment
- misplaced-bare-raise
2018-10-07 00:46:50 +02:00
Philipp Hörist f163d90a44 Dont move window between virtual desktops
Its the job of the window manager to restore a window to the correct
location
2018-10-07 00:46:50 +02:00
Philipp Hörist d37a93ff60 Fix unneeded-not pylint errors 2018-10-07 00:46:49 +02:00
Philipp Hörist 9543e0a190 Update pylint error list
- Check for C0113 unneeded-not
- Check for C0123 unidiomatic-typecheck
- Check for C0203 bad-mcs-method-argument
- Check for C0200 consider-using-enumerate
- Check for C0305 trailing-newlines
- Check for E0213 no-self-argument
2018-10-07 00:46:49 +02:00
Philipp Hörist e89dfccf73 Fix pylint errors
- bad-mcs-method-argument
- trailing-newlines
- no-self-argument
2018-10-07 00:46:49 +02:00
Philipp Hörist 99efc4a9b4 Fix pylint errors
- consider-using-enumerate
- unneeded-not
- unidiomatic-typecheck
2018-10-07 00:46:49 +02:00
Philipp Hörist 8a2044a59c Update pylint error list
Specify from now on the errors that are disabled instead of enabled,
because we have now more checks enabled than disabled
2018-10-07 00:46:49 +02:00
Philipp Hörist d0c913af23 Update pylint error list
- Check for R1714 consider-using-in
- Check for W0107 unnecessary-pass
- Check for W0235 useless-super-delegation
2018-10-07 00:46:49 +02:00
Philipp Hörist 7a96e6a4e4 Fix consider-using-in pylint errors 2018-10-07 00:46:49 +02:00
Philipp Hörist 20c5af5deb Fix useless-super-delegation pylint errors 2018-10-07 00:46:49 +02:00
Philipp Hörist 9baf4666b8 Fix unnecessary-pass pylint errors 2018-10-07 00:46:49 +02:00
Philipp Hörist 7e177f05ac Update pylint error list
- Check for W0622 redefined-builtin
- Check for C0303 trailing-whitespace
- Check for C0326 bad-whitespace
2018-10-07 00:46:48 +02:00
Philipp Hörist c156f02cc0 Fix redefined-builtin pylint errors 2018-10-07 00:46:48 +02:00
Philipp Hörist f12dfb811d Fix trailing-whitespace pylint errors 2018-10-07 00:46:48 +02:00
Philipp Hörist e842298724 Fix bad-whitespace pylint errors 2018-10-07 00:46:48 +02:00
Philipp Hörist b2a64fe5cc Update pylint error list
- Check for C0121 singleton-comparison
- Check for C0321 multiple-statements
2018-10-07 00:46:47 +02:00
Philipp Hörist a65d88c1cd Fix multiple-statements pylint errors 2018-10-07 00:46:47 +02:00
Philipp Hörist 5d1de209a8 Fix singleton-comparison pylint errors 2018-10-07 00:46:47 +02:00
Philipp Hörist 56f4d35169 Update pylint error list
- Check for R1704 redefined-argument-from-local
- Check for R1705 no-else-return
2018-10-07 00:46:46 +02:00
Philipp Hörist dad5331bf2 Fix no-else-return pylint errors 2018-10-07 00:46:46 +02:00
Philipp Hörist b9edcceb4c Fix redefined-argument-from-local pylint errors 2018-10-07 00:46:45 +02:00
Philipp Hörist c5ca89558d keys() doesnt return list() in python3 2018-10-07 00:46:45 +02:00
Philipp Hörist 4923464dfa Update pylint error list
Check for R1707 trailing-comma-tuple
2018-10-07 00:46:45 +02:00
Philipp Hörist bc70b24d80 Fix trailing-comma-tuple pylint errors 2018-10-07 00:46:45 +02:00
Philipp Hörist e4e998272c Update pylint error list
- Check for R0123 literal-comparison
- Check for R1703 simplifiable-if-statement
2018-10-07 00:46:45 +02:00
Philipp Hörist acb0bacc09 Fix simplifiable-if-statement pylint errors 2018-10-07 00:46:45 +02:00
Philipp Hörist defe74cc06 Fix literal-comparison pylint errors 2018-10-07 00:46:45 +02:00
Philipp Hörist 4fb78dfbfa Use keys() iteration if we modify the dict 2018-10-07 00:46:44 +02:00
Philipp Hörist be2d1131bb Update pylint error list
Check for C0201 consider-iterating-dictionary
2018-10-07 00:46:44 +02:00
Philipp Hörist c4bd6d6ab2 Fix consider-iterating-dictionary pylint errors 2018-10-07 00:46:44 +02:00
Philipp Hörist 407dc04b28 Fix pylint errors 2018-10-07 00:46:44 +02:00
Philipp Hörist aca7019bbb Update pylint error list
Check for W0612 unused-variable
2018-10-07 00:46:44 +02:00
Philipp Hörist cebd83d436 Fix unused-variable pylint errors 2018-10-07 00:46:44 +02:00
Philipp Hörist 7c558d38a6 Update pylint error list
Check for W1202 logging-format-interpolation
2018-10-07 00:46:43 +02:00
Philipp Hörist a8509db2e5 Update pylint error list
Check for W1201 logging-not-lazy
2018-10-07 00:46:43 +02:00
Philipp Hörist 6305fc69b9 Fix logging-not-lazy pylint errors 2018-10-07 00:46:43 +02:00
Philipp Hörist 7674450cc6 Update pylint error list
Check for W0702 bare-except
2018-10-07 00:46:42 +02:00
Philipp Hörist 5ff08236bb Fix bare-except pylint errors 2018-10-07 00:46:42 +02:00
Philipp Hörist 1c7f347a08 Fix missing time attribute
This was removed by accident
2018-10-07 00:46:42 +02:00
Philipp Hörist 9dde6f2506 Update .pylintrc 2018-10-07 00:46:42 +02:00
Philipp Hörist f9c9b2f051 Update pylint error list
Check for W0621 redefined-outer-name
2018-10-07 00:46:42 +02:00
Philipp Hörist eb6f5761ec Fix redefined-outer-name pylint errors 2018-10-07 00:46:42 +02:00
Philipp Hörist e952739dee Update pylint error list
Check for C0325 superfluous-parens
2018-10-07 00:46:42 +02:00
Philipp Hörist a6525e19a2 Fix superfluous-parens pylint errors 2018-10-07 00:46:41 +02:00
Philipp Hörist 54776f5877 Fix evaluation for subject change 2018-10-07 00:46:41 +02:00
Philipp Hörist 4c877cfb9c Update pre-push-tests.sh 2018-10-07 00:46:41 +02:00
Philipp Hörist 57af04d7d3 Add a pre-push script
Run this before every push to simulate the CI regarding mypy and pylint
2018-10-07 00:46:41 +02:00
Philipp Hörist 0b5c8a3b46 Dont retract pep items on UserXEPs
This leads to multiple problems

1. We cant assume only items with id='current' are stored in the node
which would lead to retracting 'current' but another item would become
the last published and sent to users

2. Even if we have a SingletonNode retracting the only item means the Node
would be empty and offline clients would not receive the last published item
on coming online, because there is no item anymore

Instead we always publish an empty item from now on
2018-10-07 00:46:41 +02:00
Philipp Hörist f00d8087ad Fix sending empty pep data 2018-10-07 00:46:41 +02:00
Philipp Hörist bdc93e17ae Update pylint error list
Check for R0205 useless-object-inheritance
2018-10-07 00:46:40 +02:00