Commit Graph

655 Commits

Author SHA1 Message Date
Philipp Hörist 4c38a309fc Fix pylint errors
- deprecated-method
- anomalous-backslash-in-string
- cell-var-from-loop
- undefined-loop-variable
2018-10-07 00:46:51 +02:00
Philipp Hörist 16f7620204 pylint W0143 is not available on pylint < 2.0 2018-10-07 00:46:50 +02:00
Philipp Hörist 60173c06db Fix pylint errors
- duplicate-key
- eval-used
- comparison-with-callable
2018-10-07 00:46:50 +02:00
Philipp Hörist 64487929a6 Fix pylint errors
- pointless-statement
- pointless-string-statement
- unnecessary-lambda
2018-10-07 00:46:50 +02:00
Philipp Hörist 99efc4a9b4 Fix pylint errors
- consider-using-enumerate
- unneeded-not
- unidiomatic-typecheck
2018-10-07 00:46:49 +02:00
Philipp Hörist c156f02cc0 Fix redefined-builtin pylint errors 2018-10-07 00:46:48 +02:00
Philipp Hörist f12dfb811d Fix trailing-whitespace pylint errors 2018-10-07 00:46:48 +02:00
Philipp Hörist e842298724 Fix bad-whitespace pylint errors 2018-10-07 00:46:48 +02:00
Philipp Hörist a65d88c1cd Fix multiple-statements pylint errors 2018-10-07 00:46:47 +02:00
Philipp Hörist 5d1de209a8 Fix singleton-comparison pylint errors 2018-10-07 00:46:47 +02:00
Philipp Hörist dad5331bf2 Fix no-else-return pylint errors 2018-10-07 00:46:46 +02:00
Philipp Hörist b9edcceb4c Fix redefined-argument-from-local pylint errors 2018-10-07 00:46:45 +02:00
Philipp Hörist c5ca89558d keys() doesnt return list() in python3 2018-10-07 00:46:45 +02:00
Philipp Hörist bc70b24d80 Fix trailing-comma-tuple pylint errors 2018-10-07 00:46:45 +02:00
Philipp Hörist acb0bacc09 Fix simplifiable-if-statement pylint errors 2018-10-07 00:46:45 +02:00
Philipp Hörist defe74cc06 Fix literal-comparison pylint errors 2018-10-07 00:46:45 +02:00
Philipp Hörist 4fb78dfbfa Use keys() iteration if we modify the dict 2018-10-07 00:46:44 +02:00
Philipp Hörist c4bd6d6ab2 Fix consider-iterating-dictionary pylint errors 2018-10-07 00:46:44 +02:00
Philipp Hörist 407dc04b28 Fix pylint errors 2018-10-07 00:46:44 +02:00
Philipp Hörist cebd83d436 Fix unused-variable pylint errors 2018-10-07 00:46:44 +02:00
Philipp Hörist 6305fc69b9 Fix logging-not-lazy pylint errors 2018-10-07 00:46:43 +02:00
Philipp Hörist 5ff08236bb Fix bare-except pylint errors 2018-10-07 00:46:42 +02:00
Philipp Hörist 1c7f347a08 Fix missing time attribute
This was removed by accident
2018-10-07 00:46:42 +02:00
Philipp Hörist eb6f5761ec Fix redefined-outer-name pylint errors 2018-10-07 00:46:42 +02:00
Philipp Hörist a6525e19a2 Fix superfluous-parens pylint errors 2018-10-07 00:46:41 +02:00
Philipp Hörist 54776f5877 Fix evaluation for subject change 2018-10-07 00:46:41 +02:00
Philipp Hörist 0b5c8a3b46 Dont retract pep items on UserXEPs
This leads to multiple problems

1. We cant assume only items with id='current' are stored in the node
which would lead to retracting 'current' but another item would become
the last published and sent to users

2. Even if we have a SingletonNode retracting the only item means the Node
would be empty and offline clients would not receive the last published item
on coming online, because there is no item anymore

Instead we always publish an empty item from now on
2018-10-07 00:46:41 +02:00
Philipp Hörist f00d8087ad Fix sending empty pep data 2018-10-07 00:46:41 +02:00
Philipp Hörist 7cf53e901b Fix useless-object-inheritance pylint errors 2018-10-07 00:46:40 +02:00
Philipp Hörist d011be2d89 Fix unsued-import pylint errors 2018-10-07 00:46:40 +02:00
Philipp Hörist a3c687dae1 Fix len-as-condition pylint errors 2018-10-07 00:46:39 +02:00
Philipp Hörist e953820ff8 Zeroconf: Store time of outgoing messages 2018-10-07 00:46:39 +02:00
Philipp Hörist 77c9b3a98d Add annotations and fix pylint/mypy errors 2018-10-07 00:46:38 +02:00
Philipp Hörist 9bfa2d9258 fuzzyclock: Fix pylint errors 2018-10-07 00:46:38 +02:00
Philipp Hörist 6ba984d540 Add annotations 2018-10-07 00:46:38 +02:00
Philipp Hörist 6753c3e499 Fix pylint errors 2018-10-07 00:46:37 +02:00
Philipp Hörist 58ad5cd4d5 Fix pylint errors in common/modules 2018-10-07 00:46:37 +02:00
Philipp Hörist 6abb9c626b Make some vars private 2018-10-07 00:46:37 +02:00
Philipp Hörist 375af2a3d9 Catch error if no translation is found 2018-10-07 00:46:37 +02:00
Philipp Hörist 8d896449c7 Fix mypy error regarding _() 2018-10-07 00:46:37 +02:00
Philipp Hörist 1b75403754 Refactor i18n
- Make _() available, so other modules can import it from i18n, we need
this because mypy cant handle _() in the builtins namespace
2018-10-07 00:46:36 +02:00
Philipp Hörist f5cef34910 Add annotations to modules/util.py 2018-10-07 00:46:36 +02:00
Philipp Hörist 9a778541b5 Add annotations for modules/__init__.py 2018-10-07 00:46:36 +02:00
Philipp Hörist df9651f33b Remove unnecessary code
NetworkIncomingEvent defines base_network_events and generate() already
2018-10-07 00:46:36 +02:00
Philipp Hörist 648ac9fe89 Fix subscribing to contact
Fixes #9321
2018-10-07 00:46:36 +02:00
Philipp Hörist 950130528d Request blocking list on connect 2018-10-07 00:46:36 +02:00
Philipp Hörist 9bd9bef3c3 Fix fallback for bookmark name 2018-10-07 00:46:36 +02:00
Philipp Hörist 069c0263e1 Improve speed of groupchat roster
- Save reference to contact in a dict instead of iterating the whole model
- Sort roster only once after all contacts have been added to the roster
- Speed up get_gc_contact()

Fixes #9334
2018-10-07 00:46:36 +02:00
Philipp Hörist ba8d20ab78 Remove verbose logging of idle time 2018-10-07 00:46:35 +02:00
Philipp Hörist 3fbba447db Windows: Improve locked screen detection
UAC prompts count as locked screens, so only trigger extended away
when the screen is more than 10 seconds locked

Fixes #9117
2018-10-07 00:46:35 +02:00
Philipp Hörist fcda077493 Revert "Windows: Remove locked screen detection"
This reverts commit 05307bd609
2018-10-07 00:46:35 +02:00
Philipp Hörist 37420720fe Windows: Remove locked screen detection
This does not reliably tell us when the screen is locked.
For example this triggers when a UAC prompt is active.
From the Windows documentation there is no way to determine
if a workstation is locked

Fixes #9117
2018-10-07 00:46:35 +02:00
Philipp Hörist ebc0dd4536 Fix license comment format
every linter flags this as an error
2018-10-07 00:46:35 +02:00
Philipp Hörist 7a8892f021 Windows: Fix IPV6 for Windows 10+
Fixes #9326
2018-10-07 00:46:34 +02:00
Philipp Hörist 4d53bd9064 Light refactring of bookmark code
- Convert xs:boolean values in bookmark module
- Use python booleans for minimize and autojoin in other parts of Gajim
- Use add_bookmark() instead of manipulating the bookmarks dict
2018-10-07 00:46:34 +02:00
Philipp Hörist 4d43fc4db5 Add a bookmark sorting method 2018-10-07 00:46:34 +02:00
Philipp Hörist 3e73ee93e1 Add XEP-0398 optimizations
- If the server implements XEP-0398 we dont need to add the avatar sha
anymore, the server adds it for us.
- It also means we dont have to query our own avatar from vcard at start
because the server tells us the avatar sha that is published with the inital
presence reflection
2018-10-07 00:46:34 +02:00
Philipp Hörist d4d29f8309 Send all presence through the presence module 2018-10-07 00:46:33 +02:00
Philipp Hörist 42a7dbc79a Fix contact not beeing found after room destroy 2018-10-07 00:46:33 +02:00
Philipp Hörist d01dc442c8 Fix missing attribute 2018-10-07 00:46:33 +02:00
Sophie Herold afbc0c325f Unify to use app.get_account_label() 2018-10-07 00:46:33 +02:00
Philipp Hörist 41a7196620 Fix displaying MUC subjects with delay tag
Dont print it as "old" conversation, instead add the delay timestamp
at the end of the subject
2018-10-07 00:46:33 +02:00
Philipp Hörist a8534800b0 Parse delay after decryption
Delay could be encrypted with full stanza encryption
2018-10-07 00:46:33 +02:00
Philipp Hörist f25634bff5 Register modules defined by plugins 2018-10-07 00:46:33 +02:00
André Apitzsch 501111b93e Time: use classes from standard library 2018-10-07 00:42:00 +02:00
Philipp Hörist 163f98f7c4 Windows: Fix gstreamer/farstream plugin paths 2018-08-25 09:42:09 +02:00
Philipp Hörist 33effbbeb6 Call link() on correct object 2018-08-25 09:42:09 +02:00
Philipp Hörist 2e47f93214 Display only emojis the font supports
Fixes #9299
2018-08-25 09:42:09 +02:00
Philipp Hörist 6f8ffb131a Add JID to VcardReceivedEvent 2018-08-19 16:43:30 +02:00
Philipp Hörist c4dfc0f8f2 Caps: Lower log level 2018-08-19 10:50:51 +02:00
Yann Leboulanger c49f9d60ab fix jingle negotiation from an XMPP point of view 2018-08-18 16:05:33 +02:00
Philipp Hörist bab834814e Use a python 3.5 compat method to scan dirs 2018-08-18 14:06:54 +02:00
Philipp Hörist c8c44f5a78 Fix XMLConsole
- Print the stream header again
- Fix template button, it should not be translated
2018-08-18 12:35:21 +02:00
Philipp Hörist 5feb4becfd Rework Emoji implementation
- Use emoji data from a generated dict based on the offical unicode docs,
this makes it easier to update in the future
- Rewrite the emoji chooser
- Add a search field to the emoji chooser
- The emoji chooser is loaded async
- Update to current Unicode 11 Noto theme
2018-08-17 21:55:42 +02:00
Philipp Hörist 9d5131b8b4 Rework Gajim Theming
- Save all Theme settings to .css instead of the config file
- Add a gajim-dark.css
- Refactor the ThemesWindow
2018-08-16 22:53:33 +02:00
Sophie Herold ee3cc9cbab Reduce number of notifications kept in message tray 2018-08-16 22:48:40 +02:00
Philipp Hörist 2ce78334ca Fix direct MUC invite 2018-08-04 21:41:44 +02:00
Philipp Hörist 043e764896 Make Service Registration a Gtk.Assistant
- Move all xmpp Register methods into the register module
2018-08-04 19:47:57 +02:00
Sophie Herold 99ec800856 Rework History Dialog 2018-08-04 11:04:36 +02:00
Philipp Hörist 560a122ab5 Add error message to change password dialog
- Move register methods to own module
2018-08-01 00:35:42 +02:00
Philipp Hörist 4096ab5db5 Fix detecting oob data 2018-07-31 21:20:02 +02:00
Philipp Hörist 85bc3896ab Handle messages without 'to' correctly 2018-07-30 21:58:22 +02:00
Philipp Hörist 137bf1f831 MAM: Request from last received stanza-id
Record stanza-ids from live messages. If Gajim is started query the
archive from the last received stanza-id
2018-07-29 23:16:13 +02:00
Philipp Hörist dbf891e97c Add missing bookmark dict entry 2018-07-29 22:26:52 +02:00
Philipp Hörist 394d38e663 Add lost server discovery query 2018-07-29 22:16:06 +02:00
Philipp Hörist 80aee95f2e Reset connect_maschine after disconnect on purpose 2018-07-29 19:35:45 +02:00
Philipp Hörist 7584037fc7 Fix typo 2018-07-28 13:32:37 +02:00
Philipp Hörist 2f3d50b13f Fix restoring open chatcontrols after restart 2018-07-27 16:16:23 +02:00
Philipp Hörist 5a6f03dea4 Add connect_maschine()
Add method that sequentially works the steps we have to do
before sending first presence

- Move Delimiter into own module
- Move Metacontacts into own module
2018-07-27 16:01:10 +02:00
Philipp Hörist db77fa1ace Add roster implementation to Gajim 2018-07-26 20:38:00 +02:00
Philipp Hörist 7ad6a28e12 Fix event name 2018-07-26 17:27:56 +02:00
Philipp Hörist cf580c62de Discover httpupload also on the user domain 2018-07-25 19:33:03 +02:00
Philipp Hörist 5d24c9bbdd Move subscription code into presence module 2018-07-23 23:04:07 +02:00
Philipp Hörist 6c4d9ff4c7 Dont disco unnecessary server items 2018-07-23 20:44:57 +02:00
Philipp Hörist ea34959b35 Catch cert error in posh query 2018-07-23 19:51:25 +02:00
Philipp Hörist a943a35a5d Move caps code into own module 2018-07-22 20:49:53 +02:00
Philipp Hörist 07c87a4194 Rewrite discovery code and move it into own module 2018-07-22 16:20:00 +02:00
Philipp Hörist 5ff9e9febf Move dataforms into modules folder 2018-07-22 16:20:00 +02:00
Philipp Hörist afb0306160 Move security labels into own module 2018-07-22 16:19:59 +02:00
Philipp Hörist 78858f7c82 Move more MUC methods into muc module 2018-07-22 16:19:53 +02:00
Philipp Hörist 37f7a80396 Move message handler into own module 2018-07-22 12:33:55 +02:00
Philipp Hörist d4fd621d11 Use misc module to parse correction 2018-07-21 08:50:46 +02:00
Philipp Hörist 9f65bca3d3 Remove traces of forwarding messages (XEP-0146)
This is deprecated because its very insecure and also not needed
anymore because of MAM
2018-07-21 08:50:46 +02:00
Philipp Hörist 54b5dec6c7 Mock bookmarks for zeroconf
Fixes #9256
2018-07-20 23:17:58 +02:00
Philipp Hörist 5ed9768b87 Add JID to log output 2018-07-19 17:15:28 +02:00
Philipp Hörist 3a3b5aff20 Move some dialogs into gtk module 2018-07-18 00:15:46 +02:00
Philipp Hörist bff5f14b92 Move invites into MUC module 2018-07-17 18:38:36 +02:00
Philipp Hörist d65253b021 Move Carbons into own module 2018-07-17 18:38:36 +02:00
Philipp Hörist 6c70b63e34 Fix parsing jid from roster set event 2018-07-17 00:13:12 +02:00
Sophie Herold 67d9b7a7ea Rework Bookmarks Dialog 2018-07-16 19:44:38 +02:00
Philipp Hörist 8fbafcd8fb Register mam handler correctly 2018-07-15 23:58:21 +02:00
Philipp Hörist ebbe06d587 Refactor MAM into own module
- Rework the MAM Preference dialog
- Move MAM Preference dialog into a new gtk module
- Refactor all MAM code into own module
- Refactor the MAM code itself so we can easier test it in the future
- Add a misc module for smaller XEPs and move EME, Last Message Correction
Delay, OOB into it
- Add dedicated module for XEP-0082 Time Profiles
2018-07-15 14:26:00 +02:00
Philipp Hörist 72ee9af79c Set lower log level for password errors 2018-07-14 08:21:43 +02:00
Philipp Hörist 28aada122d Fix it better 2018-07-13 18:09:48 +02:00
Philipp Hörist 45635736bf Fix error if session is None 2018-07-13 18:06:31 +02:00
Philipp Hörist 4cb852914e Fix bookmarks strategy
Strategy is now:

1. Get pubsub if supported
2. Get private storage and merge if we find boomarks we dont have
3. Store bookmarks to both pubsub and privatestorage

The only drawback with this strategy is, that a client that supports
only private storage cant delete bookmarks
2018-07-12 21:34:15 +02:00
Ave O c3a359ba23
Change to gender-neutral alternatives of pronouns 2018-07-11 23:15:56 +03:00
Philipp Hörist d9eb3e6891 Blocking: Raise NodeProcessed 2018-07-09 23:37:13 +02:00
Philipp Hörist 828d74570a Remove print statement 2018-07-09 19:52:57 +02:00
Philipp Hörist c25a4a0aab Fallback to account name when label is missing
Fixes #9236
2018-07-08 21:28:02 +02:00
Philipp Hörist a2d7283e6e Refactor AdHocCommands into own module 2018-07-08 19:39:57 +02:00
Philipp Hörist 78d16c44f3 Register PEP module first
Other modules depend on it
2018-07-08 17:06:12 +02:00
Philipp Hörist bd79fe629f Refactor Privacy and Blocking into own modules 2018-07-08 16:44:14 +02:00
Philipp Hörist 3cfd82b0c2 Fix method call 2018-07-08 10:31:05 +02:00
Philipp Hörist 3a6f667008 Check if we have a nbxmpp Client object
In some cases the XMPPDispatcher which handles the callbacks is not
yet created.
2018-07-07 20:01:47 +02:00
Philipp Hörist e918ac85fe Remove streamhost redirect
After asking around this is a dead feature.
Because servers cannot be sure if clients support redirection, a server
using this feature would essentially risk that his users are not able to
connect at all.
2018-07-07 20:00:09 +02:00
Philipp Hörist af7ac9211d Fix pylint errors in dataforms module 2018-07-07 19:36:24 +02:00
Philipp Hörist 3e4cf4a07d Change nbxmpp event we use for XMLConsole 2018-07-07 18:28:43 +02:00
Philipp Hörist 59428d2f2f Register all available modules automatically 2018-07-07 13:52:44 +02:00
Philipp Hörist 3a3b32249c Fix requesting pubsub node config
Regression from refactoring
2018-07-07 01:49:50 +02:00
Philipp Hörist 09aead3e7f Remove unused imports 2018-07-07 01:49:50 +02:00
Philipp Hörist 4bcdbde2c8 Move httpupload into modules 2018-07-07 01:49:50 +02:00
Philipp Hörist 1e9fb205ee Fix regression from 8b800f46 2018-07-06 23:54:29 +02:00
Sophie Herold 4fa4484dfd Rework JoinGroupchat Dialog 2018-07-06 22:14:32 +02:00
Philipp Hörist 63a27ace61 Use open JoinGroupchat Dialog when browsing MUCs 2018-07-06 21:43:53 +02:00
Philipp Hörist d45fa13ee9 Refactor atom into new module and disable it
Gajim lacks a good UI for microblogging

Fixes #9218
2018-07-06 21:02:06 +02:00
Philipp Hörist 70661b70d3 Rename method to something more appropriate 2018-07-06 20:12:50 +02:00
Philipp Hörist ccb3c2decc Move rest of UserAvatar into new module 2018-07-06 19:55:13 +02:00
Philipp Hörist 0a6b2126b3 Raise NodeProcessed after processing ROSTERX 2018-07-05 23:55:09 +02:00
Philipp Hörist 51e85f14a3 Remove unused code 2018-07-05 21:41:28 +02:00
Philipp Hörist 503ee35bd0 Add message handlers for AUTH and ROSTERX 2018-07-05 21:09:55 +02:00
Philipp Hörist fe3c1b4fbd Refactor UserNickname into own module 2018-07-05 20:20:22 +02:00
Philipp Hörist b04f9af4c5 Fix copy/paste typo 2018-07-05 19:54:32 +02:00
Philipp Hörist 31d6235881 Fix retracting UserTune/UserActivity 2018-07-05 19:38:41 +02:00
Philipp Hörist bbf3a544e8 Refactor UserLocation into own module 2018-07-05 19:38:03 +02:00
Philipp Hörist 14f088c2d9 Refactor UserMood into own module 2018-07-05 19:37:51 +02:00
Philipp Hörist 1712743fd5 Fix typo 2018-07-05 18:14:36 +02:00
Philipp Hörist 73f290b518 Fix incorrect argument 2018-07-05 00:28:09 +02:00
Philipp Hörist 42ccbe7499 Dont fail if modules are not registered
This is for Zeroconf so we dont have to test in GUI always for
account != local

Fixes #9229
2018-07-05 00:16:42 +02:00
Philipp Hörist a4350a812b Refactor UserTune into own module 2018-07-05 00:16:42 +02:00