Move cancellable to the type system and implement multi-parenting #1

Fermé

dgriffen souhaite fusionner 3 révision(s) depuis dgriffen/rust.eventbus:dev/dgriffen/type-cancel vers master

tirer les modifications depuis: dgriffen/rust.eventbus:dev/dgriffen/type-cancel

fusionner dans: SoniEx2:master

SoniEx2:master

SoniEx2:dev

Discussion 5 Révisions 3 Fichiers Modifiés 3 +104 -58

dgriffen a commenté 2018-10-29 03:57:23 +01:00.

Première contribution

Copier le lien

The dyn_events test was changed to produce the output requested in your sample here: https://bpaste.net/show/73d5e4bc55b4

The dyn_events test was changed to produce the output requested in your sample here: <https://bpaste.net/show/73d5e4bc55b4>

dgriffen a commenté 2018-10-29 03:59:24 +01:00.

Auteur

Première contribution

Copier le lien

This is the output produced when run with cargo test -- --nocapture

Got event for inspection and manipulation: MyEventImpl { i: 3 }
Got event for inspection, manipulation, and cancellation: MyExtraEventImpl { i: 4 }
Got event for inspection and manipulation: MyExtraEventImpl { i: 4 }

This is the output produced when run with `cargo test -- --nocapture` ```text Got event for inspection and manipulation: MyEventImpl { i: 3 } Got event for inspection, manipulation, and cancellation: MyExtraEventImpl { i: 4 } Got event for inspection and manipulation: MyExtraEventImpl { i: 4 } ```

SoniEx2 a commenté 2018-10-29 04:06:11 +01:00.

Propriétaire

Copier le lien

The output requested in my sample should be done as a separate test. And it should use asserts somehow.

This also doesn't respect the hook priorities correctly.

The output requested in my sample should be done as a separate test. And it should use asserts somehow. This also doesn't respect the hook priorities correctly.

dgriffen a commenté 2018-10-29 04:10:55 +01:00.

Auteur

Première contribution

Copier le lien

Hook priorities is quite a large problem with the way this system is implemented. Rust really doesn't have a good built-in system for dynamic typing and downcasting which will have to be done in order to respect hook priorities since we'll be mixing up handlers a lot.

Hook priorities is quite a large problem with the way this system is implemented. Rust really doesn't have a good built-in system for dynamic typing and downcasting which will have to be done in order to respect hook priorities since we'll be mixing up handlers a lot.

SoniEx2 a commenté 2018-10-29 04:15:31 +01:00.

Propriétaire

Copier le lien

Some way to generate identifiers (for use in a large enum or somesuch) would work just as well, I think, altho I'm not quite sure how to do that.

Some way to generate identifiers (for use in a large enum or somesuch) would work just as well, I think, altho I'm not quite sure how to do that.

dgriffen a commenté 2018-10-29 04:21:59 +01:00.

Auteur

Première contribution

Copier le lien

Ah yes, having the macro generate an enum large enough for each type would probably work great. I'm not sure if Rust supports turning a ty into an ident though.

Ah yes, having the macro generate an enum large enough for each type would probably work great. I'm not sure if Rust supports turning a `ty` into an `ident` though.

SoniEx2 a fermé cette demande d'ajout 2018-12-03 16:45:02 +01:00.

Demande d’ajout fermée

Veuillez rouvrir cette demande d'ajout pour effectuer l'opération de fusion.

Connectez-vous pour rejoindre cette conversation.

Évaluateurs

Sans évaluateur

Labels

Effacer les labels

Pas d'élément

Sans labels

Jalon

Effacer le jalon

Pas d'élément

Sans jalon

Projets

Effacer les projets

Pas d'élément

Sans projet

Assignés

Supprimer les affectations

Sans assignation

2 participants

Notifications

S’abonner

Échéance

La date d’échéance est invalide ou hors plage. Veuillez utiliser le format "aaaa-mm-dd".

Aucune échéance n'a été définie.

Dépendances

Aucune dépendance définie.

Référence : SoniEx2/rust.eventbus#1

Sans contenu.