Move cancellable to the type system and implement multi-parenting #1

Geschlossen

dgriffen möchte 3 Commits von dgriffen/rust.eventbus:dev/dgriffen/type-cancel nach master zusammenführen

pullen von: dgriffen/rust.eventbus:dev/dgriffen/type-cancel

Ziel: SoniEx2:master

SoniEx2:master

SoniEx2:dev

Diskussion 5 Commits 3 Geänderte Dateien 3 +104 -58

dgriffen hat 2018-10-29 03:57:23 +01:00 kommentiert

Erstmaliger Mitwirkender

Link kopieren

The dyn_events test was changed to produce the output requested in your sample here: https://bpaste.net/show/73d5e4bc55b4

The dyn_events test was changed to produce the output requested in your sample here: <https://bpaste.net/show/73d5e4bc55b4>

dgriffen hat 2018-10-29 03:59:24 +01:00 kommentiert

Autor

Erstmaliger Mitwirkender

Link kopieren

This is the output produced when run with cargo test -- --nocapture

Got event for inspection and manipulation: MyEventImpl { i: 3 }
Got event for inspection, manipulation, and cancellation: MyExtraEventImpl { i: 4 }
Got event for inspection and manipulation: MyExtraEventImpl { i: 4 }

This is the output produced when run with `cargo test -- --nocapture` ```text Got event for inspection and manipulation: MyEventImpl { i: 3 } Got event for inspection, manipulation, and cancellation: MyExtraEventImpl { i: 4 } Got event for inspection and manipulation: MyExtraEventImpl { i: 4 } ```

SoniEx2 hat 2018-10-29 04:06:11 +01:00 kommentiert

Besitzer

Link kopieren

The output requested in my sample should be done as a separate test. And it should use asserts somehow.

This also doesn't respect the hook priorities correctly.

The output requested in my sample should be done as a separate test. And it should use asserts somehow. This also doesn't respect the hook priorities correctly.

dgriffen hat 2018-10-29 04:10:55 +01:00 kommentiert

Autor

Erstmaliger Mitwirkender

Link kopieren

Hook priorities is quite a large problem with the way this system is implemented. Rust really doesn't have a good built-in system for dynamic typing and downcasting which will have to be done in order to respect hook priorities since we'll be mixing up handlers a lot.

Hook priorities is quite a large problem with the way this system is implemented. Rust really doesn't have a good built-in system for dynamic typing and downcasting which will have to be done in order to respect hook priorities since we'll be mixing up handlers a lot.

SoniEx2 hat 2018-10-29 04:15:31 +01:00 kommentiert

Besitzer

Link kopieren

Some way to generate identifiers (for use in a large enum or somesuch) would work just as well, I think, altho I'm not quite sure how to do that.

Some way to generate identifiers (for use in a large enum or somesuch) would work just as well, I think, altho I'm not quite sure how to do that.

dgriffen hat 2018-10-29 04:21:59 +01:00 kommentiert

Autor

Erstmaliger Mitwirkender

Link kopieren

Ah yes, having the macro generate an enum large enough for each type would probably work great. I'm not sure if Rust supports turning a ty into an ident though.

Ah yes, having the macro generate an enum large enough for each type would probably work great. I'm not sure if Rust supports turning a `ty` into an `ident` though.

SoniEx2 hat diesen Pull-Request 2018-12-03 16:45:02 +01:00 geschlossen

Pull-Request geschlossen

Bitte diesen Pull-Request wieder öffnen, um zusammenführen zu können.

Anmelden, um an der Diskussion teilzunehmen.

Reviewer

Keine Reviewer

Labels

Labels entfernen

Keine Einträge

Keine Label

Meilenstein

Meilenstein entfernen

Keine Einträge

Kein Meilenstein

Projekte

Projekte löschen

Keine Einträge

Kein Projekt

Zuständige

Zuständige entfernen

Niemand zuständig

2 Beteiligte

Nachrichten

Abonnieren

Fällig am

Das Fälligkeitsdatum ist ungültig oder außerhalb des zulässigen Bereichs. Bitte verwende das Format „jjjj-mm-tt“.

Kein Fälligkeitsdatum gesetzt.

Abhängigkeiten

Keine Abhängigkeiten gesetzt.

Referenz: SoniEx2/rust.eventbus#1

Keine Beschreibung angegeben.