fix requestIdleCallback usage

routes/_components/timeline/Timeline.html

@@ -208,7 +208,9 @@
           stop('handleItemIdsToAdd')
         }
         this.observe('itemIdsToAddStringified', itemIdsToAddStringified => {
+          if (itemIdsToAddStringified) {
             scheduleIdleTask(handleItemIdsToAdd)
+          }
         })
       },
       setupFocus() {

routes/_store/notificationObservers.js

@@ -1,17 +1,19 @@
 import { setFavicon } from '../_utils/setFavicon'
 import { scheduleIdleTask } from '../_utils/scheduleIdleTask'
 
+let currentFaviconHasNotifications = false
+
 export function notificationObservers (store) {
   store.observe('hasNotifications', hasNotifications => {
     if (!process.browser) {
       return
     }
+    if (currentFaviconHasNotifications === hasNotifications) {
+      return
+    }
     scheduleIdleTask(() => {
-      if (hasNotifications) {
+      setFavicon(hasNotifications ? '/favicon-alert.png' : '/favicon.png')
-        setFavicon('/favicon-alert.png')
+      currentFaviconHasNotifications = !currentFaviconHasNotifications
-      } else {
-        setFavicon('/favicon.png')
-      }
     })
   })
 }

routes/_store/store.js

@@ -41,10 +41,7 @@ export const store = new PinaforeStore({
 
 mixins(PinaforeStore)
 computations(store)
-
-export function initStore () {
 observers(store)
-}
 
 if (process.browser && process.env.NODE_ENV !== 'production') {
   window.store = store // for debugging

templates/main.js

@@ -1,5 +1,4 @@
 import { init } from 'sapper/runtime.js'
-import { initStore } from '../routes/_store/store'
 import { loadPolyfills } from '../routes/_utils/loadPolyfills'
 import '../routes/_utils/offlineNotification'
 import '../routes/_utils/serviceWorkerClient'
@@ -8,6 +7,5 @@ import '../routes/_utils/loadingMask'
 
 loadPolyfills().then(() => {
   // `routes` is an array of route objects injected by Sapper
-  initStore()
   init(document.querySelector('#sapper'), __routes__)
 })