fix(icons): fix icons.svg url (#769)

in #762 I forgot to set the absolute path for these; it fails on
subpages
This commit is contained in:
Nolan Lawson 2018-12-08 20:04:32 -08:00 committed by GitHub
parent 481a567807
commit 1d34d45da7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
18 changed files with 24 additions and 24 deletions

View File

@ -1,6 +1,6 @@
{#if error} {#if error}
<svg class={computedClass} style={svgStyle} aria-hidden="true"> <svg class={computedClass} style={svgStyle} aria-hidden="true">
<use xlink:href="icons.svg#fa-user" /> <use xlink:href="/icons.svg#fa-user" />
</svg> </svg>
{:elseif $autoplayGifs} {:elseif $autoplayGifs}
<LazyImage <LazyImage

View File

@ -3,7 +3,7 @@
> >
{#if icon} {#if icon}
<svg class="dynamic-page-banner-svg"> <svg class="dynamic-page-banner-svg">
<use xlink:href="icons.svg{icon}" /> <use xlink:href="/icons.svg{icon}" />
</svg> </svg>
{/if} {/if}
<h1 class="dynamic-page-title" aria-label={ariaTitle}>{title}</h1> <h1 class="dynamic-page-title" aria-label={ariaTitle}>{title}</h1>

View File

@ -5,7 +5,7 @@
class={computedClass}> class={computedClass}>
<slot></slot>{#if showIcon} <slot></slot>{#if showIcon}
<svg class="external-link-svg"> <svg class="external-link-svg">
<use xlink:href="icons.svg#fa-external-link" /> <use xlink:href="/icons.svg#fa-external-link" />
</svg> </svg>
{/if}</a> {/if}</a>
<style> <style>

View File

@ -8,7 +8,7 @@
delegate-key={delegateKey} delegate-key={delegateKey}
focus-key={focusKey || ''} > focus-key={focusKey || ''} >
<svg class="icon-button-svg {svgClassName || ''}" ref:svg> <svg class="icon-button-svg {svgClassName || ''}" ref:svg>
<use xlink:href="icons.svg{href}" /> <use xlink:href="/icons.svg{href}" />
</svg> </svg>
</button> </button>
{:else} {:else}
@ -21,7 +21,7 @@
{disabled} {disabled}
on:click > on:click >
<svg class="icon-button-svg {svgClassName || ''}" ref:svg> <svg class="icon-button-svg {svgClassName || ''}" ref:svg>
<use xlink:href="icons.svg{href}" /> <use xlink:href="/icons.svg{href}" />
</svg> </svg>
</button> </button>
{/if} {/if}

View File

@ -2,7 +2,7 @@
style="width: {size}px; height: {size}px;" style="width: {size}px; height: {size}px;"
aria-label="Loading" aria-label="Loading"
> >
<use xlink:href="icons.svg#fa-spinner" /> <use xlink:href="/icons.svg#fa-spinner" />
</svg> </svg>
<style> <style>
.loading-spinner-icon { .loading-spinner-icon {

Before

Width:  |  Height:  |  Size: 453 B

After

Width:  |  Height:  |  Size: 454 B

View File

@ -7,7 +7,7 @@
{#if name === 'notifications'} {#if name === 'notifications'}
<div class="nav-link-svg-wrapper"> <div class="nav-link-svg-wrapper">
<svg class="nav-link-svg"> <svg class="nav-link-svg">
<use xlink:href="icons.svg{svg}" /> <use xlink:href="/icons.svg{svg}" />
</svg> </svg>
{#if $hasNotifications} {#if $hasNotifications}
<span class="nav-link-notifications nav-link-notifications-digits-{notificationDigits}" aria-hidden="true"> <span class="nav-link-notifications nav-link-notifications-digits-{notificationDigits}" aria-hidden="true">
@ -17,7 +17,7 @@
</div> </div>
{:else} {:else}
<svg class="nav-link-svg"> <svg class="nav-link-svg">
<use xlink:href="icons.svg{svg}" /> <use xlink:href="/icons.svg{svg}" />
</svg> </svg>
{/if} {/if}
<span class="nav-link-label">{label}</span> <span class="nav-link-label">{label}</span>

View File

@ -3,7 +3,7 @@
<div class="not-logged-in-home"> <div class="not-logged-in-home">
<div class="banner"> <div class="banner">
<svg aria-hidden="true" class="not-logged-in-home-svg"> <svg aria-hidden="true" class="not-logged-in-home-svg">
<use xlink:href="icons.svg#pinafore-logo" /> <use xlink:href="/icons.svg#pinafore-logo" />
</svg> </svg>
<h1>Pinafore</h1> <h1>Pinafore</h1>
</div> </div>

View File

@ -1,6 +1,6 @@
<div class="play-video-icon {className || ''}"> <div class="play-video-icon {className || ''}">
<svg class="play-video-icon-svg"> <svg class="play-video-icon-svg">
<use xlink:href="icons.svg#fa-play-circle" /> <use xlink:href="/icons.svg#fa-play-circle" />
</svg> </svg>
</div> </div>
<style> <style>

View File

@ -1,7 +1,7 @@
<li class="page-list-item"> <li class="page-list-item">
<a {href}> <a {href}>
<svg class="page-list-item-svg"> <svg class="page-list-item-svg">
<use xlink:href="icons.svg{icon}" /> <use xlink:href="/icons.svg{icon}" />
</svg> </svg>
<span aria-label={ariaLabel}> <span aria-label={ariaLabel}>
{label} {label}

View File

@ -9,14 +9,14 @@
<div class="compose-box-button-spinner" <div class="compose-box-button-spinner"
aria-hidden="true"> aria-hidden="true">
<svg class="compose-box-button-svg {$postingStatus ? 'spin' : 'hidden'}"> <svg class="compose-box-button-svg {$postingStatus ? 'spin' : 'hidden'}">
<use xlink:href="icons.svg#fa-spinner" /> <use xlink:href="/icons.svg#fa-spinner" />
</svg> </svg>
</div> </div>
<div class="compose-box-button-compose {sticky ? '' : 'hidden'}" <div class="compose-box-button-compose {sticky ? '' : 'hidden'}"
aria-hidden="true"> aria-hidden="true">
<svg class="compose-box-button-svg"> <svg class="compose-box-button-svg">
<use xlink:href="icons.svg#fa-pencil" /> <use xlink:href="/icons.svg#fa-pencil" />
</svg> </svg>
</div> </div>
</button> </button>

View File

@ -5,7 +5,7 @@
aria-label="Delete {shortName}" aria-label="Delete {shortName}"
on:click="onDeleteMedia()" > on:click="onDeleteMedia()" >
<svg class="compose-media-delete-button-svg"> <svg class="compose-media-delete-button-svg">
<use xlink:href="icons.svg#fa-times" /> <use xlink:href="/icons.svg#fa-times" />
</svg> </svg>
</button> </button>
</div> </div>

View File

@ -3,14 +3,14 @@
<li class="generic-dialog-list-item"> <li class="generic-dialog-list-item">
<button class="generic-dialog-list-button" on:click="fire('click', item)"> <button class="generic-dialog-list-button" on:click="fire('click', item)">
<svg class="generic-dialog-list-item-svg"> <svg class="generic-dialog-list-item-svg">
<use xlink:href="icons.svg{item.icon}" /> <use xlink:href="/icons.svg{item.icon}" />
</svg> </svg>
<span class="generic-dialog-list-button-span"> <span class="generic-dialog-list-button-span">
{item.label} {item.label}
</span> </span>
{#if selectable} {#if selectable}
<svg class="generic-dialog-list-item-svg {item.selected ? '' : 'hidden'}" aria-hidden={!item.selected}> <svg class="generic-dialog-list-item-svg {item.selected ? '' : 'hidden'}" aria-hidden={!item.selected}>
<use xlink:href="icons.svg#fa-check" /> <use xlink:href="/icons.svg#fa-check" />
</svg> </svg>
{/if} {/if}
</button> </button>

View File

@ -16,7 +16,7 @@
<button class="close-dialog-button" <button class="close-dialog-button"
data-a11y-dialog-hide aria-label="Close dialog"> data-a11y-dialog-hide aria-label="Close dialog">
<svg class="close-dialog-button-svg"> <svg class="close-dialog-button-svg">
<use xlink:href="icons.svg#fa-times" /> <use xlink:href="/icons.svg#fa-times" />
</svg> </svg>
</button> </button>
</div> </div>

View File

@ -9,7 +9,7 @@
</div> </div>
<button type="submit" class="primary search-button" aria-label="Search" disabled={$searchLoading}> <button type="submit" class="primary search-button" aria-label="Search" disabled={$searchLoading}>
<svg class="search-button-svg"> <svg class="search-button-svg">
<use xlink:href="icons.svg#fa-search" /> <use xlink:href="/icons.svg#fa-search" />
</svg> </svg>
</button> </button>
</form> </form>

View File

@ -2,7 +2,7 @@
<a {href}> <a {href}>
{#if icon} {#if icon}
<svg class="settings-list-item-svg"> <svg class="settings-list-item-svg">
<use xlink:href="icons.svg{icon}" /> <use xlink:href="/icons.svg{icon}" />
</svg> </svg>
{/if} {/if}
<span aria-label={ariaLabel || label} class={offsetForIcon ? 'offset-for-icon' : ''}> <span aria-label={ariaLabel || label} class={offsetForIcon ? 'offset-for-icon' : ''}>

View File

@ -26,7 +26,7 @@
href="/statuses/{originalStatusId}/reblogs" href="/statuses/{originalStatusId}/reblogs"
aria-label={reblogsLabel}> aria-label={reblogsLabel}>
<svg class="status-favs-reblogs-svg"> <svg class="status-favs-reblogs-svg">
<use xlink:href="icons.svg#fa-retweet"/> <use xlink:href="/icons.svg#fa-retweet"/>
</svg> </svg>
<span>{numReblogs}</span> <span>{numReblogs}</span>
</a> </a>
@ -34,7 +34,7 @@
href="/statuses/{originalStatusId}/favorites" href="/statuses/{originalStatusId}/favorites"
aria-label={favoritesLabel}> aria-label={favoritesLabel}>
<svg class="status-favs-reblogs-svg"> <svg class="status-favs-reblogs-svg">
<use xlink:href="icons.svg#fa-star" /> <use xlink:href="/icons.svg#fa-star" />
</svg> </svg>
<span>{numFavs}</span> <span>{numFavs}</span>
</a> </a>

View File

@ -3,7 +3,7 @@
<Avatar {account} size="extra-small"/> <Avatar {account} size="extra-small"/>
</div> </div>
<svg class="status-header-svg"> <svg class="status-header-svg">
<use xlink:href="icons.svg{icon}"/> <use xlink:href="/icons.svg{icon}"/>
</svg> </svg>
<div class="status-header-content"> <div class="status-header-content">

View File

@ -7,7 +7,7 @@
delegate-key={delegateKey} > delegate-key={delegateKey} >
<div class="svg-wrapper"> <div class="svg-wrapper">
<svg class="status-sensitive-media-svg"> <svg class="status-sensitive-media-svg">
<use xlink:href="icons.svg#fa-eye-slash" /> <use xlink:href="/icons.svg#fa-eye-slash" />
</svg> </svg>
</div> </div>
</button> </button>
@ -23,7 +23,7 @@
</div> </div>
<div class="svg-wrapper"> <div class="svg-wrapper">
<svg class="status-sensitive-media-svg"> <svg class="status-sensitive-media-svg">
<use xlink:href="icons.svg#fa-eye" /> <use xlink:href="/icons.svg#fa-eye" />
</svg> </svg>
</div> </div>
</button> </button>