Improve trends layout (#7700)

* Allow collapsing trends, responsively hide trends

* Add trends column
This commit is contained in:
Eugen Rochko 2018-06-01 19:18:37 +02:00 committed by GitHub
parent 69b45350fe
commit 73c0c36e7b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
8 changed files with 124 additions and 8 deletions

View File

@ -5,6 +5,7 @@ import PropTypes from 'prop-types';
import ImmutablePropTypes from 'react-immutable-proptypes'; import ImmutablePropTypes from 'react-immutable-proptypes';
import { FormattedMessage, defineMessages } from 'react-intl'; import { FormattedMessage, defineMessages } from 'react-intl';
import Hashtag from '../../../components/hashtag'; import Hashtag from '../../../components/hashtag';
import { Link } from 'react-router-dom';
const messages = defineMessages({ const messages = defineMessages({
refresh_trends: { id: 'trends.refresh', defaultMessage: 'Refresh' }, refresh_trends: { id: 'trends.refresh', defaultMessage: 'Refresh' },
@ -19,6 +20,9 @@ export default class Trends extends ImmutablePureComponent {
static propTypes = { static propTypes = {
trends: ImmutablePropTypes.list, trends: ImmutablePropTypes.list,
loading: PropTypes.bool.isRequired, loading: PropTypes.bool.isRequired,
showTrends: PropTypes.bool.isRequired,
fetchTrends: PropTypes.func.isRequired,
toggleTrends: PropTypes.func.isRequired,
}; };
componentDidMount () { componentDidMount () {
@ -29,8 +33,12 @@ export default class Trends extends ImmutablePureComponent {
this.props.fetchTrends(); this.props.fetchTrends();
} }
handleToggle = () => {
this.props.toggleTrends(!this.props.showTrends);
}
render () { render () {
const { intl, trends, loading } = this.props; const { intl, trends, loading, showTrends } = this.props;
if (!trends || trends.size < 1) { if (!trends || trends.size < 1) {
return null; return null;
@ -44,13 +52,18 @@ export default class Trends extends ImmutablePureComponent {
<i className='fa fa-fire fa-fw' /> <i className='fa fa-fire fa-fw' />
<FormattedMessage id='trends.header' defaultMessage='Trending now' /> <FormattedMessage id='trends.header' defaultMessage='Trending now' />
</button> </button>
<div className='column-header__buttons'> <div className='column-header__buttons'>
<button onClick={this.handleRefreshTrends} className='column-header__button' title={intl.formatMessage(messages.refresh_trends)} aria-label={intl.formatMessage(messages.refresh_trends)} disabled={loading}><i className={classNames('fa', 'fa-refresh', { 'fa-spin': loading })} /></button> {showTrends && <button onClick={this.handleRefreshTrends} className='column-header__button' title={intl.formatMessage(messages.refresh_trends)} aria-label={intl.formatMessage(messages.refresh_trends)} disabled={loading}><i className={classNames('fa', 'fa-refresh', { 'fa-spin': loading })} /></button>}
<button onClick={this.handleToggle} className='column-header__button'><i className={classNames('fa', showTrends ? 'fa-chevron-down' : 'fa-chevron-up')} /></button>
</div> </div>
</h1> </h1>
</div> </div>
<div className='getting-started__scrollable'>{trends.take(3).map(hashtag => <Hashtag key={hashtag.get('name')} hashtag={hashtag} />)}</div> {showTrends && <div className='getting-started__scrollable'>
{trends.take(3).map(hashtag => <Hashtag key={hashtag.get('name')} hashtag={hashtag} />)}
<Link to='/trends' className='load-more'><FormattedMessage id='status.load_more' defaultMessage='Load more' /></Link>
</div>}
</div> </div>
); );
} }

View File

@ -2,14 +2,17 @@ import { connect } from 'react-redux';
import { injectIntl } from 'react-intl'; import { injectIntl } from 'react-intl';
import { fetchTrends } from '../../../actions/trends'; import { fetchTrends } from '../../../actions/trends';
import Trends from '../components/trends'; import Trends from '../components/trends';
import { changeSetting } from '../../../actions/settings';
const mapStateToProps = state => ({ const mapStateToProps = state => ({
trends: state.getIn(['trends', 'items']), trends: state.getIn(['trends', 'items']),
loading: state.getIn(['trends', 'isLoading']), loading: state.getIn(['trends', 'isLoading']),
showTrends: state.getIn(['settings', 'trends', 'show']),
}); });
const mapDispatchToProps = dispatch => ({ const mapDispatchToProps = dispatch => ({
fetchTrends: () => dispatch(fetchTrends()), fetchTrends: () => dispatch(fetchTrends()),
toggleTrends: show => dispatch(changeSetting(['trends', 'show'], show)),
}); });
export default injectIntl(connect(mapStateToProps, mapDispatchToProps)(Trends)); export default injectIntl(connect(mapStateToProps, mapDispatchToProps)(Trends));

View File

@ -80,6 +80,7 @@ export default class GettingStarted extends ImmutablePureComponent {
const navItems = []; const navItems = [];
let i = 1; let i = 1;
let height = 0;
if (multiColumn) { if (multiColumn) {
navItems.push( navItems.push(
@ -88,6 +89,8 @@ export default class GettingStarted extends ImmutablePureComponent {
<ColumnLink key={i++} icon='globe' text={intl.formatMessage(messages.public_timeline)} to='/timelines/public' />, <ColumnLink key={i++} icon='globe' text={intl.formatMessage(messages.public_timeline)} to='/timelines/public' />,
<ColumnSubheading key={i++} text={intl.formatMessage(messages.personal)} /> <ColumnSubheading key={i++} text={intl.formatMessage(messages.personal)} />
); );
height += 34*2 + 48*2;
} }
navItems.push( navItems.push(
@ -96,8 +99,11 @@ export default class GettingStarted extends ImmutablePureComponent {
<ColumnLink key={i++} icon='bars' text={intl.formatMessage(messages.lists)} to='/lists' /> <ColumnLink key={i++} icon='bars' text={intl.formatMessage(messages.lists)} to='/lists' />
); );
height += 48*3;
if (myAccount.get('locked')) { if (myAccount.get('locked')) {
navItems.push(<ColumnLink key={i++} icon='users' text={intl.formatMessage(messages.follow_requests)} badge={badgeDisplay(unreadFollowRequests, 40)} to='/follow_requests' />); navItems.push(<ColumnLink key={i++} icon='users' text={intl.formatMessage(messages.follow_requests)} badge={badgeDisplay(unreadFollowRequests, 40)} to='/follow_requests' />);
height += 48;
} }
if (!multiColumn) { if (!multiColumn) {
@ -106,6 +112,8 @@ export default class GettingStarted extends ImmutablePureComponent {
<ColumnLink key={i++} icon='gears' text={intl.formatMessage(messages.preferences)} href='/settings/preferences' />, <ColumnLink key={i++} icon='gears' text={intl.formatMessage(messages.preferences)} href='/settings/preferences' />,
<ColumnLink key={i++} icon='lock' text={intl.formatMessage(messages.security)} href='/auth/edit' /> <ColumnLink key={i++} icon='lock' text={intl.formatMessage(messages.security)} href='/auth/edit' />
); );
height += 34 + 48*2;
} }
return ( return (
@ -119,7 +127,7 @@ export default class GettingStarted extends ImmutablePureComponent {
</h1> </h1>
</div>} </div>}
<div className='getting-started__wrapper'> <div className='getting-started__wrapper' style={{ height }}>
{!multiColumn && <NavigationBar account={myAccount} />} {!multiColumn && <NavigationBar account={myAccount} />}
{navItems} {navItems}
</div> </div>

View File

@ -0,0 +1,66 @@
import React from 'react';
import PropTypes from 'prop-types';
import ImmutablePropTypes from 'react-immutable-proptypes';
import ImmutablePureComponent from 'react-immutable-pure-component';
import { connect } from 'react-redux';
import { injectIntl, defineMessages } from 'react-intl';
import Column from '../ui/components/column';
import ColumnHeader from '../../components/column_header';
import Hashtag from '../../components/hashtag';
import classNames from 'classnames';
import { fetchTrends } from '../../actions/trends';
const messages = defineMessages({
title: { id: 'trends.header', defaultMessage: 'Trending now' },
refreshTrends: { id: 'trends.refresh', defaultMessage: 'Refresh trends' },
});
const mapStateToProps = state => ({
trends: state.getIn(['trends', 'items']),
loading: state.getIn(['trends', 'isLoading']),
});
const mapDispatchToProps = dispatch => ({
fetchTrends: () => dispatch(fetchTrends()),
});
@connect(mapStateToProps, mapDispatchToProps)
@injectIntl
export default class Trends extends ImmutablePureComponent {
static propTypes = {
intl: PropTypes.object.isRequired,
trends: ImmutablePropTypes.list,
fetchTrends: PropTypes.func.isRequired,
loading: PropTypes.bool,
};
componentDidMount () {
this.props.fetchTrends();
}
handleRefresh = () => {
this.props.fetchTrends();
}
render () {
const { trends, loading, intl } = this.props;
return (
<Column>
<ColumnHeader
icon='fire'
title={intl.formatMessage(messages.title)}
extraButton={(
<button className='column-header__button' title={intl.formatMessage(messages.refreshTrends)} aria-label={intl.formatMessage(messages.refreshTrends)} onClick={this.handleRefresh}><i className={classNames('fa', 'fa-refresh', { 'fa-spin': loading })} /></button>
)}
/>
<div className='scrollable'>
{trends && trends.map(hashtag => <Hashtag key={hashtag.get('name')} hashtag={hashtag} />)}
</div>
</Column>
);
}
}

View File

@ -42,6 +42,7 @@ import {
Mutes, Mutes,
PinnedStatuses, PinnedStatuses,
Lists, Lists,
Trends,
} from './util/async-components'; } from './util/async-components';
import { HotKeys } from 'react-hotkeys'; import { HotKeys } from 'react-hotkeys';
import { me } from '../../initial_state'; import { me } from '../../initial_state';
@ -154,6 +155,7 @@ class SwitchingColumnsArea extends React.PureComponent {
<WrappedRoute path='/pinned' component={PinnedStatuses} content={children} /> <WrappedRoute path='/pinned' component={PinnedStatuses} content={children} />
<WrappedRoute path='/search' component={Compose} content={children} componentParams={{ isSearchPage: true }} /> <WrappedRoute path='/search' component={Compose} content={children} componentParams={{ isSearchPage: true }} />
<WrappedRoute path='/trends' component={Trends} content={children} />
<WrappedRoute path='/statuses/new' component={Compose} content={children} /> <WrappedRoute path='/statuses/new' component={Compose} content={children} />
<WrappedRoute path='/statuses/:statusId' exact component={Status} content={children} /> <WrappedRoute path='/statuses/:statusId' exact component={Status} content={children} />

View File

@ -129,3 +129,7 @@ export function EmbedModal () {
export function ListEditor () { export function ListEditor () {
return import(/* webpackChunkName: "features/list_editor" */'../../list_editor'); return import(/* webpackChunkName: "features/list_editor" */'../../list_editor');
} }
export function Trends () {
return import(/* webpackChunkName: "features/trends" */'../../trends');
}

View File

@ -64,6 +64,10 @@ const initialState = ImmutableMap({
body: '', body: '',
}), }),
}), }),
trends: ImmutableMap({
show: true,
}),
}); });
const defaultColumns = fromJS([ const defaultColumns = fromJS([

View File

@ -2178,8 +2178,7 @@ a.account__display-name {
} }
.getting-started__wrapper { .getting-started__wrapper {
position: relative; flex: 0 0 auto;
overflow-y: auto;
} }
.flex-spacer { .flex-spacer {
@ -2187,7 +2186,6 @@ a.account__display-name {
} }
.getting-started { .getting-started {
flex: 1 0 auto;
color: $dark-text-color; color: $dark-text-color;
p { p {
@ -2228,7 +2226,23 @@ a.account__display-name {
&__trends { &__trends {
background: $ui-base-color; background: $ui-base-color;
flex: 1 1 auto; flex: 0 1 auto;
@media screen and (max-height: 810px) {
.trends__item:nth-child(3) {
display: none;
}
}
@media screen and (max-height: 720px) {
.trends__item:nth-child(2) {
display: none;
}
}
@media screen and (max-height: 670px) {
display: none;
}
} }
&__scrollable { &__scrollable {
@ -2460,8 +2474,10 @@ a.status-card {
line-height: inherit; line-height: inherit;
margin: 0; margin: 0;
padding: 15px; padding: 15px;
box-sizing: border-box;
width: 100%; width: 100%;
clear: both; clear: both;
text-decoration: none;
&:hover { &:hover {
background: lighten($ui-base-color, 2%); background: lighten($ui-base-color, 2%);