commit
51fbec9a19
|
@ -1,4 +1,4 @@
|
|||
# Description: Qt5 bindings for GStreamer
|
||||
# Description: Qt5 bindings for GStreamer.
|
||||
# URL: http://gstreamer.freedesktop.org/modules/qt-gstreamer.htm
|
||||
# Packager: alihan-ozturk28@hotmail.com
|
||||
# Depends on: cmake boost xorg-mesa doxygen gstreamer1-plugins-good qt5
|
||||
|
|
|
@ -1,4 +1,4 @@
|
|||
# Description: Classes for a WebKit2 based implementation and a new QML API
|
||||
# Description: Classes for a WebKit2 based implementation and a new QML API.
|
||||
# URL: http://qt-project.org/
|
||||
# Packager: alihan-ozturk28@hotmail.com
|
||||
# Depends on: gstreamer1-plugins-base libwebp xorg-libxcomposite libxslt gstreamer1-plugins-good python ruby qt5
|
||||
|
|
|
@ -0,0 +1,9 @@
|
|||
[Desktop Entry]
|
||||
Name=Qt5 Assistant
|
||||
Comment=Shows Qt documentation and examples
|
||||
Exec=/usr/bin/assistant-qt5
|
||||
Icon=assistant
|
||||
Terminal=false
|
||||
Encoding=UTF-8
|
||||
Type=Application
|
||||
Categories=Qt;Development;Documentation;
|
|
@ -0,0 +1,11 @@
|
|||
[Desktop Entry]
|
||||
Name=Qt5 Designer
|
||||
GenericName=Interface Designer
|
||||
Comment=Design GUIs for Qt applications
|
||||
Exec=/usr/bin/designer-qt5
|
||||
Icon=designer
|
||||
MimeType=application/x-designer;
|
||||
Terminal=false
|
||||
Encoding=UTF-8
|
||||
Type=Application
|
||||
Categories=Qt;Development;
|
|
@ -0,0 +1,10 @@
|
|||
[Desktop Entry]
|
||||
Name=Qt5 Linguist
|
||||
Comment=Add translations to Qt applications
|
||||
Exec=/usr/bin/linguist-qt5
|
||||
Icon=linguist
|
||||
MimeType=text/vnd.trolltech.linguist;application/x-linguist;
|
||||
Terminal=false
|
||||
Encoding=UTF-8
|
||||
Type=Application
|
||||
Categories=Qt;Development;
|
|
@ -0,0 +1,9 @@
|
|||
[Desktop Entry]
|
||||
Name=Qt5 QDbusViewer
|
||||
GenericName=D-Bus Debugger
|
||||
Comment=Debug D-Bus applications
|
||||
Exec=/usr/bin/qdbusviewer-qt5
|
||||
Icon=qdbusviewer
|
||||
Terminal=false
|
||||
Type=Application
|
||||
Categories=Qt;Development;Debugger;
|
|
@ -1,272 +0,0 @@
|
|||
From e9041c7fc1052167f1ec2df0ea9623059e55d00f Mon Sep 17 00:00:00 2001
|
||||
From: Thiago Macieira <thiago.macieira@intel.com>
|
||||
Date: Thu, 28 Apr 2016 22:09:01 -0700
|
||||
Subject: [PATCH] Fix parsing of tzfile(5) POSIX rule zone names with bracket
|
||||
quotes
|
||||
|
||||
POSIX.1-2001 allows quoting a zone name so that it can contain other
|
||||
characters besides letters, by enclosing it in angle brackets ('<' and
|
||||
'>'). This hadn't been used until recently (tzdata2016b), when the
|
||||
Asia/Barnaul rule started using a zone name "+07" (the name variable
|
||||
contained the value "<+07>-7").
|
||||
|
||||
Thanks to Paul Eggert for reporting and investigating the root cause.
|
||||
|
||||
Task-number: QTBUG-53071
|
||||
Change-Id: Id5480807d25e49e78b79ffff1449bc410776cb66
|
||||
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
|
||||
Reviewed-by: Lars Knoll <lars.knoll@theqtcompany.com>
|
||||
---
|
||||
src/corelib/tools/qtimezoneprivate_tz.cpp | 176 ++++++++++++++-------
|
||||
.../auto/corelib/tools/qtimezone/tst_qtimezone.cpp | 10 ++
|
||||
2 files changed, 130 insertions(+), 56 deletions(-)
|
||||
|
||||
diff --git a/src/corelib/tools/qtimezoneprivate_tz.cpp b/src/corelib/tools/qtimezoneprivate_tz.cpp
|
||||
index 85ed345..cb9581a 100644
|
||||
--- a/src/corelib/tools/qtimezoneprivate_tz.cpp
|
||||
+++ b/src/corelib/tools/qtimezoneprivate_tz.cpp
|
||||
@@ -41,6 +41,8 @@
|
||||
|
||||
#include <qdebug.h>
|
||||
|
||||
+#include "qlocale_tools_p.h"
|
||||
+
|
||||
#include <algorithm>
|
||||
|
||||
QT_BEGIN_NAMESPACE
|
||||
@@ -384,25 +386,100 @@ static QTime parsePosixTime(const QByteArray &timeRule)
|
||||
return QTime(2, 0, 0);
|
||||
}
|
||||
|
||||
-static int parsePosixOffset(const QByteArray &timeRule)
|
||||
+static int parsePosixOffset(const char *begin, const char *end)
|
||||
{
|
||||
// Format "[+|-]hh[:mm[:ss]]"
|
||||
- QList<QByteArray> parts = timeRule.split(':');
|
||||
- int count = parts.count();
|
||||
- if (count == 3) {
|
||||
- int hour = parts.at(0).toInt();
|
||||
- int sign = hour >= 0 ? -1 : 1;
|
||||
- return sign * ((qAbs(hour) * 60 * 60) + (parts.at(1).toInt() * 60) + parts.at(2).toInt());
|
||||
- } else if (count == 2) {
|
||||
- int hour = parts.at(0).toInt();
|
||||
- int sign = hour >= 0 ? -1 : 1;
|
||||
- return sign * ((qAbs(hour) * 60 * 60) + (parts.at(1).toInt() * 60));
|
||||
- } else if (count == 1) {
|
||||
- int hour = parts.at(0).toInt();
|
||||
- int sign = hour >= 0 ? -1 : 1;
|
||||
- return sign * (qAbs(hour) * 60 * 60);
|
||||
- }
|
||||
- return 0;
|
||||
+ int hour, min = 0, sec = 0;
|
||||
+
|
||||
+ // note that the sign is inverted because POSIX counts in hours West of GMT
|
||||
+ bool negate = true;
|
||||
+ if (*begin == '+') {
|
||||
+ ++begin;
|
||||
+ } else if (*begin == '-') {
|
||||
+ negate = false;
|
||||
+ ++begin;
|
||||
+ }
|
||||
+
|
||||
+ bool ok = false;
|
||||
+ hour = qstrtoll(begin, &begin, 10, &ok);
|
||||
+ if (!ok)
|
||||
+ return INT_MIN;
|
||||
+ if (begin < end && *begin == ':') {
|
||||
+ // minutes
|
||||
+ ++begin;
|
||||
+ min = qstrtoll(begin, &begin, 10, &ok);
|
||||
+ if (!ok || min < 0)
|
||||
+ return INT_MIN;
|
||||
+
|
||||
+ if (begin < end && *begin == ':') {
|
||||
+ // seconds
|
||||
+ ++begin;
|
||||
+ sec = qstrtoll(begin, &begin, 10, &ok);
|
||||
+ if (!ok || sec < 0)
|
||||
+ return INT_MIN;
|
||||
+ }
|
||||
+ }
|
||||
+
|
||||
+ // we must have consumed everything
|
||||
+ if (begin != end)
|
||||
+ return INT_MIN;
|
||||
+
|
||||
+ int value = (hour * 60 + min) * 60 + sec;
|
||||
+ return negate ? -value : value;
|
||||
+}
|
||||
+
|
||||
+static inline bool asciiIsLetter(char ch)
|
||||
+{
|
||||
+ ch |= 0x20; // lowercases if it is a letter, otherwise just corrupts ch
|
||||
+ return ch >= 'a' && ch <= 'z';
|
||||
+}
|
||||
+
|
||||
+// Returns the zone name, the offset (in seconds) and advances \a begin to
|
||||
+// where the parsing ended. Returns a zone of INT_MIN in case an offset
|
||||
+// couldn't be read.
|
||||
+static QPair<QString, int> parsePosixZoneNameAndOffset(const char *&pos, const char *end)
|
||||
+{
|
||||
+ static const char offsetChars[] = "0123456789:";
|
||||
+ QPair<QString, int> result = qMakePair(QString(), INT_MIN);
|
||||
+
|
||||
+ const char *nameBegin = pos;
|
||||
+ const char *nameEnd;
|
||||
+ Q_ASSERT(pos < end);
|
||||
+
|
||||
+ if (*pos == '<') {
|
||||
+ nameBegin = pos + 1; // skip the '<'
|
||||
+ nameEnd = nameBegin;
|
||||
+ while (nameEnd < end && *nameEnd != '>') {
|
||||
+ // POSIX says only alphanumeric, but we allow anything
|
||||
+ ++nameEnd;
|
||||
+ }
|
||||
+ pos = nameEnd + 1; // skip the '>'
|
||||
+ } else {
|
||||
+ nameBegin = pos;
|
||||
+ nameEnd = nameBegin;
|
||||
+ while (nameEnd < end && asciiIsLetter(*nameEnd))
|
||||
+ ++nameEnd;
|
||||
+ pos = nameEnd;
|
||||
+ }
|
||||
+ if (nameEnd - nameBegin < 3)
|
||||
+ return result; // name must be at least 3 characters long
|
||||
+
|
||||
+ // zone offset, form [+-]hh:mm:ss
|
||||
+ const char *zoneBegin = pos;
|
||||
+ const char *zoneEnd = pos;
|
||||
+ if (zoneEnd < end && (zoneEnd[0] == '+' || zoneEnd[0] == '-'))
|
||||
+ ++zoneEnd;
|
||||
+ while (zoneEnd < end) {
|
||||
+ if (strchr(offsetChars, char(*zoneEnd)) == NULL)
|
||||
+ break;
|
||||
+ ++zoneEnd;
|
||||
+ }
|
||||
+
|
||||
+ result.first = QString::fromUtf8(nameBegin, nameEnd - nameBegin);
|
||||
+ if (zoneEnd > zoneBegin)
|
||||
+ result.second = parsePosixOffset(zoneBegin, zoneEnd);
|
||||
+ pos = zoneEnd;
|
||||
+ return result;
|
||||
}
|
||||
|
||||
static QVector<QTimeZonePrivate::Data> calculatePosixTransitions(const QByteArray &posixRule,
|
||||
@@ -419,51 +496,38 @@ static QVector<QTimeZonePrivate::Data> calculatePosixTransitions(const QByteArra
|
||||
|
||||
// POSIX Format is like "TZ=CST6CDT,M3.2.0/2:00:00,M11.1.0/2:00:00"
|
||||
// i.e. "std offset dst [offset],start[/time],end[/time]"
|
||||
- // See http://www.gnu.org/software/libc/manual/html_node/TZ-Variable.html
|
||||
+ // See the section about TZ at http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html
|
||||
QList<QByteArray> parts = posixRule.split(',');
|
||||
|
||||
- QString name = QString::fromUtf8(parts.at(0));
|
||||
- QString stdName;
|
||||
- QString stdOffsetString;
|
||||
- QString dstName;
|
||||
- QString dstOffsetString;
|
||||
- bool parsedStdName = false;
|
||||
- bool parsedStdOffset = false;
|
||||
- for (int i = 0; i < name.size(); ++i) {
|
||||
- if (name.at(i).isLetter()) {
|
||||
- if (parsedStdName) {
|
||||
- parsedStdOffset = true;
|
||||
- dstName.append(name.at(i));
|
||||
- } else {
|
||||
- stdName.append(name.at(i));
|
||||
+ QPair<QString, int> stdZone, dstZone;
|
||||
+ {
|
||||
+ const QByteArray &zoneinfo = parts.at(0);
|
||||
+ const char *begin = zoneinfo.constBegin();
|
||||
+
|
||||
+ stdZone = parsePosixZoneNameAndOffset(begin, zoneinfo.constEnd());
|
||||
+ if (stdZone.second == INT_MIN) {
|
||||
+ stdZone.second = 0; // reset to UTC if we failed to parse
|
||||
+ } else if (begin < zoneinfo.constEnd()) {
|
||||
+ dstZone = parsePosixZoneNameAndOffset(begin, zoneinfo.constEnd());
|
||||
+ if (dstZone.second == INT_MIN) {
|
||||
+ // if the dst offset isn't provided, it is 1 hour ahead of the standard offset
|
||||
+ dstZone.second = stdZone.second + (60 * 60);
|
||||
}
|
||||
- } else {
|
||||
- parsedStdName = true;
|
||||
- if (parsedStdOffset)
|
||||
- dstOffsetString.append(name.at(i));
|
||||
- else
|
||||
- stdOffsetString.append(name.at(i));
|
||||
}
|
||||
}
|
||||
|
||||
- int utcOffset = parsePosixOffset(stdOffsetString.toUtf8());
|
||||
-
|
||||
// If only the name part then no transitions
|
||||
if (parts.count() == 1) {
|
||||
QTimeZonePrivate::Data data;
|
||||
data.atMSecsSinceEpoch = lastTranMSecs;
|
||||
- data.offsetFromUtc = utcOffset;
|
||||
- data.standardTimeOffset = utcOffset;
|
||||
+ data.offsetFromUtc = stdZone.second;
|
||||
+ data.standardTimeOffset = stdZone.second;
|
||||
data.daylightTimeOffset = 0;
|
||||
- data.abbreviation = stdName;
|
||||
+ data.abbreviation = stdZone.first;
|
||||
result << data;
|
||||
return result;
|
||||
}
|
||||
|
||||
- // If not populated the total dst offset is 1 hour
|
||||
- int dstOffset = utcOffset + (60 * 60);
|
||||
- if (!dstOffsetString.isEmpty())
|
||||
- dstOffset = parsePosixOffset(dstOffsetString.toUtf8());
|
||||
|
||||
// Get the std to dst transtion details
|
||||
QList<QByteArray> dstParts = parts.at(1).split('/');
|
||||
@@ -486,18 +550,18 @@ static QVector<QTimeZonePrivate::Data> calculatePosixTransitions(const QByteArra
|
||||
for (int year = startYear; year <= endYear; ++year) {
|
||||
QTimeZonePrivate::Data dstData;
|
||||
QDateTime dst(calculatePosixDate(dstDateRule, year), dstTime, Qt::UTC);
|
||||
- dstData.atMSecsSinceEpoch = dst.toMSecsSinceEpoch() - (utcOffset * 1000);
|
||||
- dstData.offsetFromUtc = dstOffset;
|
||||
- dstData.standardTimeOffset = utcOffset;
|
||||
- dstData.daylightTimeOffset = dstOffset - utcOffset;
|
||||
- dstData.abbreviation = dstName;
|
||||
+ dstData.atMSecsSinceEpoch = dst.toMSecsSinceEpoch() - (stdZone.second * 1000);
|
||||
+ dstData.offsetFromUtc = dstZone.second;
|
||||
+ dstData.standardTimeOffset = stdZone.second;
|
||||
+ dstData.daylightTimeOffset = dstZone.second - stdZone.second;
|
||||
+ dstData.abbreviation = dstZone.first;
|
||||
QTimeZonePrivate::Data stdData;
|
||||
QDateTime std(calculatePosixDate(stdDateRule, year), stdTime, Qt::UTC);
|
||||
- stdData.atMSecsSinceEpoch = std.toMSecsSinceEpoch() - (dstOffset * 1000);
|
||||
- stdData.offsetFromUtc = utcOffset;
|
||||
- stdData.standardTimeOffset = utcOffset;
|
||||
+ stdData.atMSecsSinceEpoch = std.toMSecsSinceEpoch() - (dstZone.second * 1000);
|
||||
+ stdData.offsetFromUtc = stdZone.second;
|
||||
+ stdData.standardTimeOffset = stdZone.second;
|
||||
stdData.daylightTimeOffset = 0;
|
||||
- stdData.abbreviation = stdName;
|
||||
+ stdData.abbreviation = stdZone.first;
|
||||
// Part of the high year will overflow
|
||||
if (year == 292278994 && (dstData.atMSecsSinceEpoch < 0 || stdData.atMSecsSinceEpoch < 0)) {
|
||||
if (dstData.atMSecsSinceEpoch > 0) {
|
||||
diff --git a/tests/auto/corelib/tools/qtimezone/tst_qtimezone.cpp b/tests/auto/corelib/tools/qtimezone/tst_qtimezone.cpp
|
||||
index ea83510..ce72e7c 100644
|
||||
--- a/tests/auto/corelib/tools/qtimezone/tst_qtimezone.cpp
|
||||
+++ b/tests/auto/corelib/tools/qtimezone/tst_qtimezone.cpp
|
||||
@@ -847,6 +847,16 @@ void tst_QTimeZone::tzTest()
|
||||
QTzTimeZonePrivate::Data datatz2 = tztz2.data(std);
|
||||
QTzTimeZonePrivate::Data datautc2 = tzutc2.data(std);
|
||||
QCOMPARE(datatz2.offsetFromUtc, datautc2.offsetFromUtc);
|
||||
+
|
||||
+ // Test a timezone with a name that isn't all letters
|
||||
+ QTzTimeZonePrivate tzBarnaul("Asia/Barnaul");
|
||||
+ if (tzBarnaul.isValid()) {
|
||||
+ QCOMPARE(tzBarnaul.data(std).abbreviation, QString("+07"));
|
||||
+
|
||||
+ // first full day of the new rule (tzdata2016b)
|
||||
+ QDateTime dt(QDate(2016, 3, 28), QTime(0, 0, 0), Qt::UTC);
|
||||
+ QCOMPARE(tzBarnaul.data(dt.toMSecsSinceEpoch()).abbreviation, QString("+07"));
|
||||
+ }
|
||||
#endif // Q_OS_UNIX
|
||||
}
|
||||
|
|
@ -1,122 +0,0 @@
|
|||
From cd25866f6533923c208f52d58516f3725f69cefb Mon Sep 17 00:00:00 2001
|
||||
From: Thiago Macieira <thiago.macieira@intel.com>
|
||||
Date: Wed, 18 May 2016 13:38:55 -0700
|
||||
Subject: [PATCH] Use the code we already have for parsing the transition time
|
||||
too
|
||||
|
||||
It's there and it's more efficient anyway.
|
||||
|
||||
Change-Id: Ie9fd7afe060b4e4a8052fffd144fc40647430268
|
||||
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
|
||||
Reviewed-by: Brett Stottlemyer <bstottle@ford.com>
|
||||
Reviewed-by: Lars Knoll <lars.knoll@theqtcompany.com>
|
||||
---
|
||||
src/corelib/tools/qtimezoneprivate_tz.cpp | 68 ++++++++++++++++++-------------
|
||||
1 file changed, 40 insertions(+), 28 deletions(-)
|
||||
|
||||
diff --git a/src/corelib/tools/qtimezoneprivate_tz.cpp b/src/corelib/tools/qtimezoneprivate_tz.cpp
|
||||
index cb9581a..bfa967e 100644
|
||||
--- a/src/corelib/tools/qtimezoneprivate_tz.cpp
|
||||
+++ b/src/corelib/tools/qtimezoneprivate_tz.cpp
|
||||
@@ -372,37 +372,21 @@ static QDate calculatePosixDate(const QByteArray &dateRule, int year)
|
||||
}
|
||||
}
|
||||
|
||||
-static QTime parsePosixTime(const QByteArray &timeRule)
|
||||
+// returns the time in seconds, INT_MIN if we failed to parse
|
||||
+static int parsePosixTime(const char *begin, const char *end)
|
||||
{
|
||||
- // Format "HH:mm:ss", put check parts count just in case
|
||||
- QList<QByteArray> parts = timeRule.split(':');
|
||||
- int count = parts.count();
|
||||
- if (count == 3)
|
||||
- return QTime(parts.at(0).toInt(), parts.at(1).toInt(), parts.at(2).toInt());
|
||||
- else if (count == 2)
|
||||
- return QTime(parts.at(0).toInt(), parts.at(1).toInt(), 0);
|
||||
- else if (count == 1)
|
||||
- return QTime(parts.at(0).toInt(), 0, 0);
|
||||
- return QTime(2, 0, 0);
|
||||
-}
|
||||
-
|
||||
-static int parsePosixOffset(const char *begin, const char *end)
|
||||
-{
|
||||
- // Format "[+|-]hh[:mm[:ss]]"
|
||||
+ // Format "hh[:mm[:ss]]"
|
||||
int hour, min = 0, sec = 0;
|
||||
|
||||
- // note that the sign is inverted because POSIX counts in hours West of GMT
|
||||
- bool negate = true;
|
||||
- if (*begin == '+') {
|
||||
- ++begin;
|
||||
- } else if (*begin == '-') {
|
||||
- negate = false;
|
||||
- ++begin;
|
||||
- }
|
||||
+ // Note that the calls to qstrtoll do *not* check the end pointer, which
|
||||
+ // means they proceed until they find a non-digit. We check that we're
|
||||
+ // still in range at the end, but we may have read from past end. It's the
|
||||
+ // caller's responsibility to ensure that begin is part of a
|
||||
+ // null-terminated string.
|
||||
|
||||
bool ok = false;
|
||||
hour = qstrtoll(begin, &begin, 10, &ok);
|
||||
- if (!ok)
|
||||
+ if (!ok || hour < 0)
|
||||
return INT_MIN;
|
||||
if (begin < end && *begin == ':') {
|
||||
// minutes
|
||||
@@ -424,7 +408,35 @@ static int parsePosixOffset(const char *begin, const char *end)
|
||||
if (begin != end)
|
||||
return INT_MIN;
|
||||
|
||||
- int value = (hour * 60 + min) * 60 + sec;
|
||||
+ return (hour * 60 + min) * 60 + sec;
|
||||
+}
|
||||
+
|
||||
+static QTime parsePosixTransitionTime(const QByteArray &timeRule)
|
||||
+{
|
||||
+ // Format "hh[:mm[:ss]]"
|
||||
+ int value = parsePosixTime(timeRule.constBegin(), timeRule.constEnd());
|
||||
+ if (value == INT_MIN) {
|
||||
+ // if we failed to parse, return 02:00
|
||||
+ return QTime(2, 0, 0);
|
||||
+ }
|
||||
+ return QTime::fromMSecsSinceStartOfDay(value * 1000);
|
||||
+}
|
||||
+
|
||||
+static int parsePosixOffset(const char *begin, const char *end)
|
||||
+{
|
||||
+ // Format "[+|-]hh[:mm[:ss]]"
|
||||
+ // note that the sign is inverted because POSIX counts in hours West of GMT
|
||||
+ bool negate = true;
|
||||
+ if (*begin == '+') {
|
||||
+ ++begin;
|
||||
+ } else if (*begin == '-') {
|
||||
+ negate = false;
|
||||
+ ++begin;
|
||||
+ }
|
||||
+
|
||||
+ int value = parsePosixTime(begin, end);
|
||||
+ if (value == INT_MIN)
|
||||
+ return value;
|
||||
return negate ? -value : value;
|
||||
}
|
||||
|
||||
@@ -534,7 +546,7 @@ static QVector<QTimeZonePrivate::Data> calculatePosixTransitions(const QByteArra
|
||||
QByteArray dstDateRule = dstParts.at(0);
|
||||
QTime dstTime;
|
||||
if (dstParts.count() > 1)
|
||||
- dstTime = parsePosixTime(dstParts.at(1));
|
||||
+ dstTime = parsePosixTransitionTime(dstParts.at(1));
|
||||
else
|
||||
dstTime = QTime(2, 0, 0);
|
||||
|
||||
@@ -543,7 +555,7 @@ static QVector<QTimeZonePrivate::Data> calculatePosixTransitions(const QByteArra
|
||||
QByteArray stdDateRule = stdParts.at(0);
|
||||
QTime stdTime;
|
||||
if (stdParts.count() > 1)
|
||||
- stdTime = parsePosixTime(stdParts.at(1));
|
||||
+ stdTime = parsePosixTransitionTime(stdParts.at(1));
|
||||
else
|
||||
stdTime = QTime(2, 0, 0);
|
||||
|
|
@ -1,90 +0,0 @@
|
|||
From 8e889378115c69508b050a511621ac8e30ec4158 Mon Sep 17 00:00:00 2001
|
||||
From: Jesus Fernandez <jesus.fernandez@theqtcompany.com>
|
||||
Date: Mon, 13 Jun 2016 19:09:15 +0200
|
||||
Subject: [PATCH] Fix UNSIGNED values in QMYSQL
|
||||
|
||||
The unsigned flag in columns was ignored when creating the list of
|
||||
bound values in a mysql table. So the result iteration with
|
||||
QSqlQuery::next stops after the first wrong truncated value.
|
||||
|
||||
[ChangeLog][QtSql] Fixed QSqlQuery::prepare value truncation error when
|
||||
using UNSIGNED values in a MySQL database.
|
||||
|
||||
Task-number: QTBUG-53969
|
||||
Task-number: QTBUG-53237
|
||||
Change-Id: I10d977993445f2794f1dd8c88b2e83517ef524f3
|
||||
Reviewed-by: Milian Wolff <milian.wolff@kdab.com>
|
||||
---
|
||||
src/sql/drivers/mysql/qsql_mysql.cpp | 1 +
|
||||
tests/auto/sql/kernel/qsqlquery/tst_qsqlquery.cpp | 39 +++++++++++++++++++++++
|
||||
2 files changed, 40 insertions(+)
|
||||
|
||||
diff --git a/src/sql/drivers/mysql/qsql_mysql.cpp b/src/sql/drivers/mysql/qsql_mysql.cpp
|
||||
index 96bdcc4..55bf499 100644
|
||||
--- a/src/sql/drivers/mysql/qsql_mysql.cpp
|
||||
+++ b/src/sql/drivers/mysql/qsql_mysql.cpp
|
||||
@@ -387,6 +387,7 @@ bool QMYSQLResultPrivate::bindInValues()
|
||||
bind->buffer_length = f.bufLength = fieldInfo->length + 1;
|
||||
bind->is_null = &f.nullIndicator;
|
||||
bind->length = &f.bufLength;
|
||||
+ bind->is_unsigned = fieldInfo->flags & UNSIGNED_FLAG ? 1 : 0;
|
||||
f.outField=field;
|
||||
|
||||
++i;
|
||||
diff --git a/tests/auto/sql/kernel/qsqlquery/tst_qsqlquery.cpp b/tests/auto/sql/kernel/qsqlquery/tst_qsqlquery.cpp
|
||||
index bd553d5..f1c4333 100644
|
||||
--- a/tests/auto/sql/kernel/qsqlquery/tst_qsqlquery.cpp
|
||||
+++ b/tests/auto/sql/kernel/qsqlquery/tst_qsqlquery.cpp
|
||||
@@ -233,6 +233,9 @@ private slots:
|
||||
void QTBUG_36211_data() { generic_data("QPSQL"); }
|
||||
void QTBUG_36211();
|
||||
|
||||
+ void QTBUG_53969_data() { generic_data("QMYSQL"); }
|
||||
+ void QTBUG_53969();
|
||||
+
|
||||
void sqlite_constraint_data() { generic_data("QSQLITE"); }
|
||||
void sqlite_constraint();
|
||||
|
||||
@@ -3652,6 +3655,42 @@ void tst_QSqlQuery::QTBUG_36211()
|
||||
}
|
||||
}
|
||||
|
||||
+void tst_QSqlQuery::QTBUG_53969()
|
||||
+{
|
||||
+ QFETCH( QString, dbName );
|
||||
+ QVector<int> values = QVector<int>() << 10 << 20 << 127 << 128 << 1, tableValues;
|
||||
+ QSqlDatabase db = QSqlDatabase::database( dbName );
|
||||
+ CHECK_DATABASE( db );
|
||||
+ tableValues.reserve(values.size());
|
||||
+ if (tst_Databases::getDatabaseType(db) == QSqlDriver::MySqlServer) {
|
||||
+ const QString tableName(qTableName("bug53969", __FILE__, db));
|
||||
+ tst_Databases::safeDropTable( db, tableName );
|
||||
+
|
||||
+ QSqlQuery q(db);
|
||||
+ QVERIFY_SQL(q, exec(QString("CREATE TABLE %1 (id INT AUTO_INCREMENT PRIMARY KEY, "
|
||||
+ "test_number TINYINT(3) UNSIGNED)")
|
||||
+ .arg(tableName)));
|
||||
+
|
||||
+ QVERIFY_SQL(q, prepare("INSERT INTO " + tableName + " (test_number) VALUES (:value)"));
|
||||
+
|
||||
+ QVector<int>::iterator begin = values.begin(), end = values.end(), it;
|
||||
+ for (it = begin; it != end; ++it) {
|
||||
+ q.bindValue(":value", *it);
|
||||
+ QVERIFY_SQL(q, exec());
|
||||
+ }
|
||||
+
|
||||
+ QVERIFY_SQL(q, prepare("SELECT test_number FROM " + tableName));
|
||||
+ QVERIFY_SQL(q, exec());
|
||||
+
|
||||
+ while (q.next()) {
|
||||
+ bool ok;
|
||||
+ tableValues.push_back(q.value(0).toUInt(&ok));
|
||||
+ QVERIFY(ok);
|
||||
+ }
|
||||
+ QCOMPARE(values, tableValues);
|
||||
+ }
|
||||
+}
|
||||
+
|
||||
void tst_QSqlQuery::oraOCINumber()
|
||||
{
|
||||
QFETCH( QString, dbName );
|
|
@ -1,161 +1,80 @@
|
|||
# Description: Qt Free Edition, version 5.x
|
||||
# URL: http://qt-project.org/
|
||||
# Packager: alihan-ozturk28@hotmail.com
|
||||
# Depends on: xorg-proto xorg-libxkbfile xorg-xtrans xorg-libx11 xorg-libxext xorg-libfs xorg-libice xorg-libsm xorg-libxscrnsaver xorg-libxt xorg-libxmu xorg-libxpm xorg-libxaw xorg-libxfixes xorg-libxcomposite xorg-libxrender xorg-libxcursor xorg-libxdamage xorg-libfontenc xorg-libxfont xorg-libxft xorg-libxi xorg-libxinerama xorg-libxrandr xorg-libxres xorg-libxtst xorg-libxv xorg-libxvmc xorg-libxxf86dga xorg-libxxf86vm xorg-libdmx xorg-libpciaccess xorg-libxkbfile xorg-libxshmfence xcb-proto xcb-util-image xcb-util-keysyms xcb-util-renderutil xcb-util-wm alsa-lib cups dbus glib gstreamer-plugins-base icu jasper libjpeg-turbo libmng libpng libtiff libwebp xorg-mesa mtdev pcre sqlite ruby gstreamer1-plugins-base geoclue gtk2 harfbuzz postgresql pulseaudio unixodbc libxkbcommon mariadb
|
||||
# Depends on:xorg-proto xorg-libxkbfile xorg-xtrans xorg-libx11 xorg-libxext xorg-libfs xorg-libice xorg-libsm xorg-libxscrnsaver xorg-libxt xorg-libxmu xorg-libxpm xorg-libxaw xorg-libxfixes xorg-libxcomposite xorg-libxrender xorg-libxcursor xorg-libxdamage xorg-libfontenc xorg-libxfont xorg-libxft xorg-libxi xorg-libxinerama xorg-libxrandr xorg-libxres xorg-libxtst xorg-libxv xorg-libxvmc xorg-libxxf86dga xorg-libxxf86vm xorg-libdmx xorg-libpciaccess xorg-libxkbfile xorg-libxshmfence xcb-proto xcb-util-image xcb-util-keysyms xcb-util-renderutil xcb-util-wm alsa-lib ca-certificates cups dbus glib gstreamer-plugins-base icu jasper libproxy libinput libjpeg-turbo libmng libpng libtiff libwebp xorg-mesa mtdev openssl pcre sqlite ruby gstreamer1-plugins-base geoclue gtk2 harfbuzz postgresql pulseaudio unixodbc libxkbcommon mariadb
|
||||
|
||||
name=qt5
|
||||
version=5.7.0
|
||||
release=1
|
||||
|
||||
_name=qt-everywhere-opensource-src-${version}
|
||||
|
||||
source=(http://download.qt.io/official_releases/qt/${version%.*}/$version/single/qt-everywhere-opensource-src-$version.tar.xz
|
||||
qtbug-53237.patch
|
||||
qtbug-53071.patch
|
||||
qtbug-53071b.patch)
|
||||
assistant.desktop
|
||||
designer.desktop
|
||||
qdbusviewer.desktop
|
||||
linguist.desktop)
|
||||
|
||||
build() {
|
||||
|
||||
QT5PREFIX=/usr
|
||||
QT5DIR=$QT5PREFIX/lib/qt5
|
||||
QT5BINDIR=$QT5PREFIX/lib/qt5/bin
|
||||
|
||||
cd qt-everywhere-opensource-src-$version
|
||||
cd ${_name}*
|
||||
|
||||
# Fix parsing of tzfile(5) POSIX rule zone names with bracket quotes
|
||||
patch -p1 -d qtbase -i $SRC/qtbug-53071.patch
|
||||
patch -p1 -d qtbase -i $SRC/qtbug-53071b.patch
|
||||
|
||||
# Fix UNSIGNED values in QMYSQL
|
||||
patch -p1 -d qtbase -i $SRC/qtbug-53237.patch
|
||||
|
||||
# Respect system CXX
|
||||
[ "$CXX" ] || CXX=g++
|
||||
sed -i "/^QMAKE_CXX\s/s|=.*|= $CXX|" qtbase/mkspecs/common/g++-base.conf
|
||||
|
||||
# Remove obsolete xorg path
|
||||
sed -i 's|X11R6/||g' qtbase/mkspecs/*/*.conf
|
||||
|
||||
# Respect system CXXFLAGS
|
||||
sed -i "s|^\(QMAKE_CFLAGS_RELEASE.*\)|\1 ${CXXFLAGS}|" qtbase/mkspecs/common/gcc-base.conf
|
||||
|
||||
# Respect system LDFLAGS
|
||||
sed -i "s|^\(QMAKE_LFLAGS_RELEASE.*\)|\1 ${LDFLAGS}|" qtbase/mkspecs/common/g++-unix.conf
|
||||
|
||||
# Fix quoting bug
|
||||
sed -i 's|"$COMPILER" -c|$COMPILER -c|' qtbase/config.tests/unix/fvisibility.test
|
||||
|
||||
./configure -opensource -confirm-license \
|
||||
-prefix $QT5PREFIX \
|
||||
-sysconfdir /etc/xdg \
|
||||
-bindir $QT5BINDIR \
|
||||
-plugindir /usr/lib/qt5/plugins \
|
||||
-importdir /usr/lib/qt5/imports \
|
||||
-headerdir /usr/include/qt5 \
|
||||
-datadir /usr/share/qt5 \
|
||||
-translationdir /usr/share/qt5/translations \
|
||||
-plugin-sql-{psql,mysql,sqlite,odbc} \
|
||||
-openssl-linked \
|
||||
-dbus-linked \
|
||||
-system-sqlite \
|
||||
-system-zlib \
|
||||
-system-harfbuzz \
|
||||
-optimized-qmake \
|
||||
-nomake examples \
|
||||
-no-separate-debug-info \
|
||||
-no-strip \
|
||||
-shared \
|
||||
-no-rpath \
|
||||
-release -reduce-relocations
|
||||
./configure -prefix $QT5PREFIX \
|
||||
-bindir $QT5BINDIR \
|
||||
-headerdir /usr/include/qt5 \
|
||||
-archdatadir $QT5DIR \
|
||||
-libdir /usr/lib \
|
||||
-docdir /usr/share/doc/qt5 \
|
||||
-plugindir /usr/lib/qt5/plugins \
|
||||
-importdir /usr/lib/qt5/imports \
|
||||
-qmldir /usr/lib/qt5/qml \
|
||||
-datadir /usr/share/qt5 \
|
||||
-translationdir /usr/share/qt5/translations \
|
||||
-sysconfdir /etc/xdg \
|
||||
-plugin-sql-{psql,mysql,sqlite,odbc} \
|
||||
-confirm-license \
|
||||
-opensource \
|
||||
-dbus-linked \
|
||||
-openssl-linked \
|
||||
-system-harfbuzz \
|
||||
-system-sqlite \
|
||||
-optimized-qmake \
|
||||
-nomake examples \
|
||||
-no-rpath
|
||||
|
||||
make
|
||||
make INSTALL_ROOT=$PKG install
|
||||
|
||||
find $PKG/usr/ -name qt_lib_bootstrap_private.pri \
|
||||
-exec sed -i -e "s:$PWD/qtbase:/$QT5PREfiX/lib/:g" {} \; &&
|
||||
# Fix paths
|
||||
find $PKG/usr/lib -type f -name '*.prl' \
|
||||
-exec sed -i -e '/^QmAKE_PRL_BUiLD_DiR/d' {} \;
|
||||
|
||||
sed -e "s|$PWD/qtbase|/usr/lib|g" \
|
||||
-i $PKG/usr/lib/qt5/mkspecs/modules/qt_lib_bootstrap_private.pri
|
||||
|
||||
find $PKG/usr -name \*.prl \
|
||||
-exec sed -i -e '/^QmAKE_PRL_BUiLD_DiR/d' {} \;
|
||||
|
||||
install -v -dm755 $PKG/usr/share/pixmaps/
|
||||
|
||||
install -v -Dm644 qttools/src/assistant/assistant/images/assistant-128.png \
|
||||
$PKG/usr/share/pixmaps/assistant-qt5.png
|
||||
|
||||
install -v -Dm644 qttools/src/designer/src/designer/images/designer.png \
|
||||
$PKG/usr/share/pixmaps/designer-qt5.png
|
||||
|
||||
install -v -Dm644 qttools/src/linguist/linguist/images/icons/linguist-128-32.png \
|
||||
$PKG/usr/share/pixmaps/linguist-qt5.png
|
||||
|
||||
install -v -Dm644 qttools/src/qdbus/qdbusviewer/images/qdbusviewer-128.png \
|
||||
$PKG/usr/share/pixmaps/qdbusviewer-qt5.png
|
||||
|
||||
install -dm755 $PKG/usr/share/applications
|
||||
|
||||
|
||||
cat > $PKG/usr/share/applications/assistant-qt5.desktop << "EOf"
|
||||
[Desktop Entry]
|
||||
Name=Qt5 Assistant
|
||||
Comment=Shows Qt5 documentation and examples
|
||||
Exec=assistant-qt5
|
||||
Icon=/usr/share/pixmaps/assistant-qt5
|
||||
Terminal=false
|
||||
Encoding=UTf-8
|
||||
Type=Application
|
||||
Categories=Qt;Development;Documentation;
|
||||
EOf
|
||||
|
||||
cat > $PKG/usr/share/applications/designer-qt5.desktop << "EOf"
|
||||
[Desktop Entry]
|
||||
Name=Qt5 Designer
|
||||
GenericName=interface Designer
|
||||
Comment=Design GUis for Qt5 applications
|
||||
Exec=designer-qt5
|
||||
Icon=/usr/share/pixmaps/designer-qt5
|
||||
MimeType=application/x-designer;
|
||||
Terminal=false
|
||||
Encoding=UTf-8
|
||||
Type=Application
|
||||
Categories=Qt;Development;
|
||||
EOf
|
||||
|
||||
cat > $PKG/usr/share/applications/linguist-qt5.desktop << "EOf"
|
||||
[Desktop Entry]
|
||||
Name=Qt5 Linguist
|
||||
Comment=Add translations to Qt5 applications
|
||||
Exec=linguist-qt5
|
||||
Icon=/usr/share/pixmaps/linguist-qt5
|
||||
MimeType=text/vnd.trolltech.linguist;application/x-linguist;
|
||||
Terminal=false
|
||||
Encoding=UTf-8
|
||||
Type=Application
|
||||
Categories=Qt;Development;
|
||||
EOf
|
||||
|
||||
cat > $PKG/usr/share/applications/qdbusviewer-qt5.desktop << "EOf"
|
||||
[Desktop Entry]
|
||||
Name=Qt5 QDbusviewer
|
||||
GenericName=D-Bus Debugger
|
||||
Comment=Debug D-Bus applications
|
||||
Exec=qdbusviewer-qt5
|
||||
Icon=/usr/share/pixmaps/qdbusviewer-qt5
|
||||
Terminal=false
|
||||
Encoding=UTf-8
|
||||
Type=Application
|
||||
Categories=Qt;Development;Debugger;
|
||||
EOf
|
||||
install -d $PKG/usr/share/applications
|
||||
install -m644 $SRC/assistant.desktop $PKG/usr/share/applications/
|
||||
install -m644 $SRC/designer.desktop $PKG/usr/share/applications/
|
||||
install -m644 $SRC/linguist.desktop $PKG/usr/share/applications/
|
||||
install -m644 $SRC/qdbusviewer.desktop $PKG/usr/share/applications/
|
||||
|
||||
mkdir -p $PKG/etc/profile.d
|
||||
cat > $PKG/etc/profile.d/qt5.sh << EOf
|
||||
# Begin /etc/profile.d/qt5.sh
|
||||
|
||||
QT5PREFIX=$QT5PREFIX
|
||||
QT5DIR=$QT5PREFIX
|
||||
QT5DIR=$QT5PREFIX/lib/qt5
|
||||
QT5BINDIR=$QT5PREFIX/lib/qt5/bin
|
||||
export QT5PREFIX QT5BINDIR QT5DIR
|
||||
|
||||
# End /etc/profile.d/qt5.sh
|
||||
EOf
|
||||
|
||||
|
||||
### symlink /usr/lib/qt5/bin
|
||||
mkdir -p $PKG/usr/bin
|
||||
|
||||
for i in $PKG/usr/lib/qt5/bin/*; do
|
||||
|
@ -167,4 +86,7 @@ if [ "x\$QT4BINDIR" != "x/usr/bin" ] && [ "x\$QT4BINDIR" != "x" ]; then pathremo
|
|||
if [ "x\$QT5BINDIR" != "x/usr/bin" ]; then pathprepend $QT5BINDIR; fi
|
||||
echo \$PATH
|
||||
EOF
|
||||
|
||||
rm -rf $PKG/usr/share/doc
|
||||
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue