fix some svelte data warnings (#247)

routes/_components/ExternalLink.html

@@ -1,7 +1,7 @@
 <a rel="nofollow noopener"
    target="_blank"
    :href
-   aria-label={{ariaLabel || ''}}
+   aria-label={{ariaLabel}}
    class="{{className || ''}} {{showIcon ? 'external-link-with-icon' : ''}} {{normalIconColor ? 'normal-icon-color' : ''}}">
   <slot></slot>{{#if showIcon}}
     <svg class="external-link-svg">
@@ -26,7 +26,10 @@
 <script>
   export default {
     data: () => ({
-      normalIconColor: false
+      className: void 0,
+      normalIconColor: false,
+      ariaLabel: '',
+      showIcon: false
     })
   }
 </script>

routes/_components/PlayVideoIcon.html

@@ -24,3 +24,10 @@
     background: var(--mask-opaque-bg);
   }
 </style>
+<script>
+  export default {
+    data: () => ({
+      className: void 0
+    })
+  }
+</script>

routes/_components/community/PageListItem.html

@@ -69,6 +69,9 @@
 
   export default {
     store: () => store,
+    data: () => ({
+      pinnable: false
+    }),
     components: {
       IconButton
     },

routes/_components/dialog/components/ModalDialog.html

@@ -141,7 +141,10 @@
     },
     data: () => ({
       // don't animate if we're showing a modal dialog on top of another modal dialog. it looks ugly
-      shouldAnimate: !process.browser || document.getElementsByClassName('modal-dialog').length < 2
+      shouldAnimate: !process.browser || document.getElementsByClassName('modal-dialog').length < 2,
+      fadedIn: false,
+      muted: false,
+      className: void 0
     }),
     computed: {
       backdropClass: (fadedIn, shouldAnimate) => {

routes/_components/profile/AccountProfileFollow.html

@@ -53,6 +53,9 @@
       }
     },
     store: () => store,
+    data: () => ({
+      overrideFollowing: void 0
+    }),
     computed: {
       accountId: (account) => account.id,
       following: (relationship, overrideFollowing) => {

routes/_components/search/AccountSearchResult.html

@@ -73,11 +73,9 @@
   import IconButton from '../IconButton.html'
 
   export default {
-    components: {
-      Avatar,
-      SearchResult,
-      IconButton
-    },
+    data: () => ({
+      actions: void 0
+    }),
     methods: {
       onButtonClick (event, action, accountId) {
         event.preventDefault()
@@ -87,6 +85,11 @@
           accountId
         })
       }
+    },
+    components: {
+      Avatar,
+      SearchResult,
+      IconButton
     }
   }
 </script>

routes/_components/settings/SettingsList.html

@@ -26,3 +26,10 @@
     }
   }
 </style>
+<script>
+  export default {
+    data: () => ({
+      label: void 0
+    })
+  }
+</script>

routes/_components/settings/SettingsListItem.html

@@ -5,15 +5,9 @@
       <use xlink:href={{icon}} />
     </svg>
     {{/if}}
-    {{#if ariaLabel}}
-    <span aria-label={{ariaLabel}} class={{offsetForIcon ? 'offset-for-icon' : ''}}>
+    <span aria-label={{ariaLabel || label}} class={{offsetForIcon ? 'offset-for-icon' : ''}}>
       {{label}}
     </span>
-    {{else}}
-    <span class={{offsetForIcon ? 'offset-for-icon' : ''}}>
-      {{label}}
-    </span>
-    {{/if}}
   </a>
 </li>
 <style>
@@ -68,3 +62,12 @@
   }
 
 </style>
+<script>
+  export default {
+    data: () => ({
+      icon: void 0,
+      ariaLabel: void 0,
+      offsetForIcon: void 0
+    })
+  }
+</script>