copyleftie
/
pinafore
1
0
Fork 0
Code Issues Pull Requests Releases Activity

fix: add <select> aria-label, remove unnecessary aria-labelledby (#1242)

This commit is contained in:
Nolan Lawson 2019-05-27 12:31:59 -07:00 committed by GitHub
parent 12179505e1
commit 3a7d6d3552
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/routes/_components/Select.html
View File

@ -1,5 +1,5 @@
<div class="select-wrapper {className || ''}"> <div class="select-wrapper {className || ''}">
<select on:change> <select on:change aria-label={label}>
{#each options as option (option.value)} {#each options as option (option.value)}
<option value="{option.value}" selected="{option.value === defaultValue ? 'selected' : ''}"> <option value="{option.value}" selected="{option.value === defaultValue ? 'selected' : ''}">
{option.label} {option.label}

2
src/routes/_components/compose/ComposePoll.html
View File

@ -5,7 +5,6 @@
maxlength="25" maxlength="25"
on:change="onChange(i)" on:change="onChange(i)"
placeholder="Choice {i + 1}" placeholder="Choice {i + 1}"
aria-labelledby="poll-option-label-{realm}-{i}"
> >
<IconButton <IconButton
@ -28,6 +27,7 @@
options={pollExpiryOptions} options={pollExpiryOptions}
defaultValue={pollExpiryDefaultValue} defaultValue={pollExpiryDefaultValue}
on:change="onExpiryChange(event)" on:change="onExpiryChange(event)"
label="Poll duration"
/> />
</div> </div>
<IconButton <IconButton