cdc2ec9205
The purpose of `if version and not gajim.contacts.get_contacts_jid_list()` seemed to be that when cache.db is empty (maybe it was deleted) `gajim.contacts.get_contacts_jid_list()` should come back empty. So on an empty roster cache, version was set to None, so that we request in any case a new roster. The Problem is that `gajim.contacts.get_contacts_jid_list()` is not a good indication for an empty cache.db. On start we trigger a `RosterReceivedEvent` which does a DB query to get the roster. Even if that DB query comes up empty, the Event is still pushed. In the event handler `_nec_roster_received` in roster_window.py we add then previously open controls and our self (if the option is set) to the roster, making `gajim.contacts.get_contacts_jid_list()` return these contacts and hence the condition in `request_roster()` always False. So the version is set in the roster request, and if there is no new version on the server, we request no new roster even though we only have ourself and previously open controls in our roster. As a solution for this we delete the roster version from the config in `RosterReceivedEvent` if the DB query comes back empty, which triggers a new roster request. |
||
|---|---|---|
| .. | ||
| command_system | ||
| common | ||
| plugins | ||
| Makefile.am | ||
| adhoc_commands.py | ||
| advanced_configuration_window.py | ||
| app_actions.py | ||
| atom_window.py | ||
| cell_renderer_image.py | ||
| chat_control.py | ||
| chat_control_base.py | ||
| config.py | ||
| conversation_textview.py | ||
| dataforms_widget.py | ||
| dialogs.py | ||
| disco.py | ||
| emoticons.py | ||
| features_window.py | ||
| filetransfers_window.py | ||
| gajim-remote.py | ||
| gajim.py | ||
| gajim_themes_window.py | ||
| groupchat_control.py | ||
| groups.py | ||
| gtkexcepthook.py | ||
| gtkgui_helpers.py | ||
| gtkspell.py | ||
| gui_interface.py | ||
| gui_menu_builder.py | ||
| history_manager.py | ||
| history_window.py | ||
| htmltextview.py | ||
| ipython_view.py | ||
| logind_listener.py | ||
| message_control.py | ||
| message_textview.py | ||
| message_window.py | ||
| music_track_listener.py | ||
| negotiation.py | ||
| network_watcher.py | ||
| notify.py | ||
| profile_window.py | ||
| pylint.rc | ||
| remote_control.py | ||
| roster_window.py | ||
| search_window.py | ||
| secrets.py | ||
| session.py | ||
| shortcuts_window.py | ||
| statusicon.py | ||
| tooltips.py | ||
| upower_listener.py | ||
| vcard.py | ||