Commit Graph

557 Commits

Author SHA1 Message Date
Philipp Hörist 74b66837fa Add annotations
- Remove some unused vars from app
2018-09-21 15:46:52 +02:00
Philipp Hörist cb692ae4eb Make SQL INSERT querys more resilient
Specify the column in which we insert otherwise downgrading Gajim is
not possible anymore because the query breaks if we modified the column
count in future
2018-09-19 20:12:24 +02:00
Philipp Hörist 422cd12991 Fix pylint errors
- deprecated-method
- anomalous-backslash-in-string
- cell-var-from-loop
- undefined-loop-variable
2018-09-18 18:45:16 +02:00
Philipp Hörist 6c80473ebe pylint W0143 is not available on pylint < 2.0 2018-09-18 17:39:35 +02:00
Philipp Hörist 385ef2e456 Fix pylint errors
- duplicate-key
- eval-used
- comparison-with-callable
2018-09-18 17:02:14 +02:00
Philipp Hörist 81387ada51 Fix pylint errors
- pointless-statement
- pointless-string-statement
- unnecessary-lambda
2018-09-18 16:44:23 +02:00
Philipp Hörist 1680c3bb38 Fix pylint errors
- consider-using-enumerate
- unneeded-not
- unidiomatic-typecheck
2018-09-18 15:24:40 +02:00
Philipp Hörist df88cc5e15 Fix redefined-builtin pylint errors 2018-09-18 13:54:25 +02:00
Philipp Hörist 29647ea693 Fix trailing-whitespace pylint errors 2018-09-18 13:38:22 +02:00
Philipp Hörist ccc06a04ab Fix bad-whitespace pylint errors 2018-09-18 12:06:01 +02:00
Philipp Hörist dea1464832 Fix multiple-statements pylint errors 2018-09-18 10:30:33 +02:00
Philipp Hörist 6237bfae41 Fix singleton-comparison pylint errors 2018-09-18 10:26:27 +02:00
Philipp Hörist ff6ca57033 Fix no-else-return pylint errors 2018-09-18 10:16:54 +02:00
Philipp Hörist d6f0242655 Fix redefined-argument-from-local pylint errors 2018-09-18 08:37:18 +02:00
Philipp Hörist cbe335b291 keys() doesnt return list() in python3 2018-09-18 07:20:49 +02:00
Philipp Hörist 04b70bf220 Fix trailing-comma-tuple pylint errors 2018-09-17 23:38:52 +02:00
Philipp Hörist 01694c6a06 Fix simplifiable-if-statement pylint errors 2018-09-17 23:25:55 +02:00
Philipp Hörist 158d013a86 Fix literal-comparison pylint errors 2018-09-17 23:03:45 +02:00
Philipp Hörist 76333ec73a Use keys() iteration if we modify the dict 2018-09-17 22:51:42 +02:00
Philipp Hörist 793184e7be Fix consider-iterating-dictionary pylint errors 2018-09-17 22:34:15 +02:00
Philipp Hörist 0b8b4f75c3 Fix pylint errors 2018-09-17 22:20:19 +02:00
Philipp Hörist e8ac644440 Fix unused-variable pylint errors 2018-09-17 21:16:19 +02:00
Philipp Hörist d638087c26 Fix logging-not-lazy pylint errors 2018-09-17 18:57:00 +02:00
Philipp Hörist 7bb6f8b22e Fix bare-except pylint errors 2018-09-16 23:45:01 +02:00
Philipp Hörist b8bbcf2be0 Fix missing time attribute
This was removed by accident
2018-09-16 23:33:09 +02:00
Philipp Hörist d53b95218a Fix redefined-outer-name pylint errors 2018-09-16 18:04:15 +02:00
Philipp Hörist c6547b6d30 Fix superfluous-parens pylint errors 2018-09-16 14:42:18 +02:00
Philipp Hörist 328d250f4c Fix evaluation for subject change 2018-09-16 14:36:54 +02:00
Philipp Hörist 7018d5be0e Dont retract pep items on UserXEPs
This leads to multiple problems

1. We cant assume only items with id='current' are stored in the node
which would lead to retracting 'current' but another item would become
the last published and sent to users

2. Even if we have a SingletonNode retracting the only item means the Node
would be empty and offline clients would not receive the last published item
on coming online, because there is no item anymore

Instead we always publish an empty item from now on
2018-09-16 13:35:55 +02:00
Philipp Hörist e85bc52c8b Fix sending empty pep data 2018-09-16 12:58:37 +02:00
Philipp Hörist bb545d546a Fix useless-object-inheritance pylint errors 2018-09-16 11:56:56 +02:00
Philipp Hörist de0c0a9c08 Fix unsued-import pylint errors 2018-09-16 11:37:38 +02:00
Philipp Hörist 49ca238252 Fix len-as-condition pylint errors 2018-09-16 01:10:04 +02:00
Philipp Hörist f7a139eac2 Zeroconf: Store time of outgoing messages 2018-09-15 12:00:32 +02:00
Philipp Hörist d54d4bc232 Add annotations and fix pylint/mypy errors 2018-09-13 23:56:12 +02:00
Philipp Hörist 62c54525d8 fuzzyclock: Fix pylint errors 2018-09-13 00:33:54 +02:00
Philipp Hörist 64aec8adce Add annotations 2018-09-12 21:08:37 +02:00
Philipp Hörist b99632ab03 Fix pylint errors 2018-09-12 00:01:54 +02:00
Philipp Hörist 09c5183575 Fix pylint errors in common/modules 2018-09-11 22:25:55 +02:00
Philipp Hörist 4ad38d5398 Make some vars private 2018-09-11 20:00:34 +02:00
Philipp Hörist dad7def794 Catch error if no translation is found 2018-09-11 19:37:48 +02:00
Philipp Hörist a34bf54c46 Fix mypy error regarding _() 2018-09-11 19:29:08 +02:00
Philipp Hörist 21672fadee Refactor i18n
- Make _() available, so other modules can import it from i18n, we need
this because mypy cant handle _() in the builtins namespace
2018-09-11 19:27:10 +02:00
Philipp Hörist 2649b3d01e Add annotations to modules/util.py 2018-09-11 00:47:59 +02:00
Philipp Hörist ca9b4cb596 Add annotations for modules/__init__.py 2018-09-11 00:47:54 +02:00
Philipp Hörist bcf2a3770d Remove unnecessary code
NetworkIncomingEvent defines base_network_events and generate() already
2018-09-11 00:37:00 +02:00
Philipp Hörist f82cd95f2c Fix subscribing to contact
Fixes #9321
2018-09-09 17:43:17 +02:00
Philipp Hörist 432704005d Request blocking list on connect 2018-09-09 16:50:55 +02:00
Philipp Hörist 0a20cb5997 Fix fallback for bookmark name 2018-09-08 23:55:31 +02:00
Philipp Hörist 27dd36cca3 Improve speed of groupchat roster
- Save reference to contact in a dict instead of iterating the whole model
- Sort roster only once after all contacts have been added to the roster
- Speed up get_gc_contact()

Fixes #9334
2018-09-08 20:49:26 +02:00