Commit Graph

48 Commits

Author SHA1 Message Date
Philipp Hörist 510985d7c4 Enforce min and max version for plugin manifest
This reduces problems with old plugins without max version
2018-11-13 21:56:21 +01:00
Philipp Hörist a7624b564f Fix error when plugin cant be loaded
Fixes #9403
2018-10-26 00:23:13 +02:00
Philipp Hörist ec05b1a47e Catch exceptions when loading plugins 2018-10-13 14:14:28 +02:00
Philipp Hörist aff0dbe928 Bind textdomain also for plugins 2018-10-13 13:32:14 +02:00
Philipp Hörist 0f0c0a6ab7 Allow to load multiple widgets with get_builder() 2018-10-13 13:31:48 +02:00
Philipp Hörist cc62761da3 Add get_builder() for plugins 2018-10-13 13:31:10 +02:00
Yann Leboulanger 83c737312b Ability to update plugins on startup from a download folder 2018-10-13 13:31:00 +02:00
Philipp Hörist 796da7b2dc Dont overwrite user plugins with base plugins
- Dont load plugins without short_name
- Check with the short_name if a plugin is already loaded
2018-10-11 20:01:49 +02:00
Philipp Hörist bd2a3a0e17 Improve finding locale dir
- Dont install _() globally, although its elegant mypy cant deal with it
- If gettext cant find the translation itself, iter through all dirs and search for it
2018-10-07 00:47:00 +02:00
Philipp Hörist f197358e2f Import _() instead of using builtin namespace
- Prepare for removing the global installed _() method in builtins
- Sort some imports along the way
2018-10-07 00:47:00 +02:00
Philipp Hörist ec76d8ac3b Only use absolute imports from gtk module
- This reduces import cycles
2018-10-07 00:46:55 +02:00
Philipp Hörist ad5f59ba49 configpaths: Add get_plugin_dirs() method
This helps with mypy because otherwise get() has multiple return types

This reduces our usage of cast()
2018-10-07 00:46:54 +02:00
Philipp Hörist eb8093d25f Add annotations
- Remove some unused vars from app
2018-10-07 00:46:52 +02:00
Philipp Hörist f163d90a44 Dont move window between virtual desktops
Its the job of the window manager to restore a window to the correct
location
2018-10-07 00:46:50 +02:00
Philipp Hörist c156f02cc0 Fix redefined-builtin pylint errors 2018-10-07 00:46:48 +02:00
Philipp Hörist f12dfb811d Fix trailing-whitespace pylint errors 2018-10-07 00:46:48 +02:00
Philipp Hörist e842298724 Fix bad-whitespace pylint errors 2018-10-07 00:46:48 +02:00
Philipp Hörist dad5331bf2 Fix no-else-return pylint errors 2018-10-07 00:46:46 +02:00
Philipp Hörist defe74cc06 Fix literal-comparison pylint errors 2018-10-07 00:46:45 +02:00
Philipp Hörist cebd83d436 Fix unused-variable pylint errors 2018-10-07 00:46:44 +02:00
Philipp Hörist 6305fc69b9 Fix logging-not-lazy pylint errors 2018-10-07 00:46:43 +02:00
Philipp Hörist 5ff08236bb Fix bare-except pylint errors 2018-10-07 00:46:42 +02:00
Philipp Hörist eb6f5761ec Fix redefined-outer-name pylint errors 2018-10-07 00:46:42 +02:00
Philipp Hörist 7cf53e901b Fix useless-object-inheritance pylint errors 2018-10-07 00:46:40 +02:00
Philipp Hörist d011be2d89 Fix unsued-import pylint errors 2018-10-07 00:46:40 +02:00
Philipp Hörist 77c9b3a98d Add annotations and fix pylint/mypy errors 2018-10-07 00:46:38 +02:00
Philipp Hörist ebc0dd4536 Fix license comment format
every linter flags this as an error
2018-10-07 00:46:35 +02:00
Philipp Hörist f25634bff5 Register modules defined by plugins 2018-10-07 00:46:33 +02:00
Philipp Hörist a457a9ac21 Move filechoosers into gtk module 2018-08-19 17:44:17 +02:00
Philipp Hörist 3a3b5aff20 Move some dialogs into gtk module 2018-07-18 00:15:46 +02:00
Sophie Herold f89169517e Rework Plugins Dialog 2018-07-16 22:38:08 +02:00
Alexander Krotov 1d27ab2254 Spellcheck 2018-06-21 03:05:47 +03:00
Philipp Hörist c38db84e04 Refactor FileChooserDialogs
Use GtkFileChooserDialog only when we need previews, default to
NativeFileChooser otherwise.

GtkFileChooserDialogs have a long list of issues, so lets only use it
if we gain something from it.

Flatpak should only run NativeFileChoosers because its sandboxed and
this is needed for security purposes. As a result of that, Flatpak Users
dont have image previews in the FileOpenDialogs

Refactor all FileChoosers for a more simple approach when we use them

Add a new SendFileDialog, so we dont have to put widgets into the FileChooser
which forces non-native Dialogs.
2018-05-05 09:22:08 +02:00
Philipp Hörist 779a4d4ce3 Get version from package instead of config 2018-05-01 00:37:13 +02:00
Markus Wintermann 49bfc1f226 Add support for dynamic reloading of plugins
‎* rename the remove_plugin function to uninstall_plugin because it
deletes files on the disc and uninstall is the label of the button which
triggers this function
* added a new remove_plugin function, which deactivates the plugin (if
needed), removes it from the list of managed plugins and deletes the
contents of sys.modules
2018-04-28 13:31:19 +02:00
Philipp Hörist 105427b8fd Use consistent way to get paths
This lets us now import the app module without setting paths
2018-04-25 20:49:37 +02:00
Philipp Hörist 276daa991c Correctly split version string
We changed the version format
2017-11-24 16:49:30 +01:00
Philipp Hörist 775fec2fea Dont activate plugins in PluginManager init
Plugins maybe want to use in their activation Gajim methods that
use an extension point. But because the PluginManager Object is not fully
initialized, the extension point method is not available yet

First create the PluginManager Object, then load Plugins.
2017-11-15 22:26:55 +01:00
André Apitzsch 2872405f07 Fix deprecation warnings 2017-10-07 21:01:27 +02:00
Philipp Hörist b9aba06f71 Remove unused variables 2017-09-29 02:41:03 +02:00
Philipp Hörist dd39067ef7 Allow Plugins to use other dialogs 2017-09-29 02:40:01 +02:00
Yann Leboulanger 8d4e815f3e fix some pylint errors 2017-08-24 23:01:06 +02:00
André Apitzsch 89c7eb6e6a Rename gajim.common.gajim to avoid name conflicts 2017-08-18 20:03:20 +02:00
André Apitzsch efec098aef Use absolute imports 2017-08-18 19:48:48 +02:00
Philipp Hörist 635ce52856 PluginManager: prefer plugins in user path
As we always load plugins from the user path first, we should not
reload them later from Gajims plugin base dir
2017-08-07 20:02:03 +02:00
Philipp Hörist 7e0e4cced0 PluginManager: remove plugin path from sys.path
Remove plugin path from sys.path after importing.

If we scan multiple plugin dirs and never remove the path from
sys.path, it is hard to predict from which path python will import
a package.

The chance that the same plugin package is in multiple plugin paths
is high.
2017-08-07 19:28:54 +02:00
Philipp Hörist 0eca29d484 Fix memory leak in plugins window
- remove gui extension point on close, to remove the reference the plugin manager holds to the Class.

- reduce scope of var that holds reference to Gtk.Builder(). We have to be careful with
Gtk.Builder, because it can hold a reference to our Class (methods bound to signals) which creates a reference cycle
which python is not able to detect. Hence neither Gtk.Builder nor our Class are garbage collected.
Why this is not detected as a reference cylce is unclear at the moment.

There are two approaches to circumvent the problem:

1. we lose our reference to Gtk.Builder when closing the window, which lets python garbage
collect the builder, afterwards it can garbage collect our class.

2. we reduce the scope of the var that holds a reference to Gtk.Builder, so that the builder
can be garbage collected at the end of __init__.

I chose to reduce the scope because the builder is not needed class wide.
2017-07-10 01:15:30 +02:00
André Apitzsch 125ce523e4 Rename src directory 2017-07-02 17:25:47 +02:00