copyleftie
/
gajim-plural
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Dont use Resolver when using a proxy 

This leaks the DNS request
This commit is contained in:
Philipp Hörist 2017-09-17 14:02:01 +02:00
parent 2c9d5d838b
commit b93098a379
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
gajim/common/connection.py
View File

@ -1083,7 +1083,8 @@ class Connection(CommonConnection, ConnectionHandlers):
self._hosts = [ {'host': h, 'port': p, 'ssl_port': ssl_p, 'prio': 10, self._hosts = [ {'host': h, 'port': p, 'ssl_port': ssl_p, 'prio': 10,
'weight': 10} ] 'weight': 10} ]
self._hostname = hostname self._hostname = hostname
if use_srv:
if use_srv and self._proxy is None:
# add request for srv query to the resolve, on result '_on_resolve' # add request for srv query to the resolve, on result '_on_resolve'
# will be called # will be called
app.resolver.resolve('_xmpp-client._tcp.' + helpers.idn_to_ascii( app.resolver.resolve('_xmpp-client._tcp.' + helpers.idn_to_ascii(
@ -1823,9 +1824,10 @@ class Connection(CommonConnection, ConnectionHandlers):
self.sm.resuming = False # back to previous state self.sm.resuming = False # back to previous state
# Discover Stun server(s) # Discover Stun server(s)
hostname = app.config.get_per('accounts', self.name, 'hostname') if self._proxy is None:
app.resolver.resolve('_stun._udp.' + helpers.idn_to_ascii(hostname), hostname = app.config.get_per('accounts', self.name, 'hostname')
self._on_stun_resolved) app.resolver.resolve('_stun._udp.' + helpers.idn_to_ascii(hostname),
self._on_stun_resolved)
def _on_stun_resolved(self, host, result_array): def _on_stun_resolved(self, host, result_array):
if len(result_array) != 0: if len(result_array) != 0: