copyleftie/gajim-plural
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Dont punycode encode all domain names

Browse source 
RFC7622 3.2.1

... This implies that the string MUST NOT include A-labels ...

Fixes #9211
This commit is contained in:
Philipp Hörist 2018-06-23 20:15:00 +02:00
parent 86eddc2ee9
commit 78ebaefaec
1 changed files with 3 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
gajim/common/helpers.py
View file

@ -61,12 +61,6 @@ try:
except ImportError: except ImportError:
HAS_PRECIS_I18N = False HAS_PRECIS_I18N = False
try:
import idna
HAS_IDNA = True
except ImportError:
HAS_IDNA = False
HAS_SOUND = True HAS_SOUND = True
if sys.platform == 'win32': if sys.platform == 'win32':
try: try:
@ -291,16 +285,13 @@ def prep(user, server, resource):
if not ip_address: if not ip_address:
if server is not None: if server is not None:
if server.endswith('.'): # RFC7622, 3.2 if server.endswith('.'): # RFC7622, 3.2
server = server[:-1] server = server[:-1]
if len(server) < 1 or len(server.encode('utf-8')) > 1023: if len(server) < 1 or len(server.encode('utf-8')) > 1023:
raise InvalidFormat(_('Server must be between 1 and 1023 bytes')) raise InvalidFormat(_('Server must be between 1 and 1023 bytes'))
try: try:
if HAS_IDNA: from nbxmpp.stringprepare import nameprep
server = idna.encode(server).decode('utf-8') server = nameprep.prepare(server)
else:
from nbxmpp.stringprepare import nameprep
server = nameprep.prepare(server)
except UnicodeError: except UnicodeError:
raise InvalidFormat(_('Invalid character in hostname.')) raise InvalidFormat(_('Invalid character in hostname.'))
else: else: