Commit Graph

87 Commits

Author SHA1 Message Date
Joseph Bisch 0c494a9c24 Fix rfc_ncasecmp handling of n reaching 0
If n becomes 0 at the same time that the end of either s1 or s2 are
reached, the next iteration of the while loop wouldn't happen, so we
wouldn't correctly return 0.
2017-09-21 21:34:14 -04:00
Joseph Bisch 4a09ce6fc3 Fix rfc_{n,}casecmp functions (#2058)
rfc_casecmp was broken because reaching terminator for str1 was used as
a terminal condition and str2 may be shorter than str1, resulting in an
oob read condition for str2.

rfc_ncasecmp was broken because it checked if n characters were checked
or if BOTH pointers reached their terminator, however the strings may
be different lengths and also less than n characters in length, meaning
that they don't both reach their terminators at the same time,
resulting in an oob read condition.
2017-09-19 14:31:48 -04:00
Patrick Griffis d99cd18fb9 Improve detection of system tray support
Closes #2045
2017-08-31 10:16:03 -04:00
Patrick Griffis 628100c19f build: Replace Autotools with Meson
Quick rundown of benefits:

- Much faster:
  - Autotools (with autogen): 22 seconds
  - Meson: 7 seconds
  - Meson (with ccache): 2 seconds

- Simpler:
  - ~1000 lines smaller
  - Single simple language

- Potentially better Windows (Visual Studio) support

What is not done:

- Complete Windows support
- OSX support (easy)

Closes #2013
Closes #1937
Closes #1803
2017-06-13 23:54:51 -04:00
Erik de Castro Lopo c698e13c0d Couple of minor const correctness fixes 2016-05-28 16:52:26 +10:00
Patrick Griffis 44aa999598 Fix challengeauth lower casing username 2016-04-13 18:47:51 -04:00
Patrick Griffis 4362085847 Remove DH-AES/DH-BLOWFISH mechanisms and misc cleanup
- AES and Blowfish mechanisms are deemed insecure and servers
  have removed support for them
- Remove attempts to retry since we only support one mech
- Handle SASL 3.2's new syntax for supported mechs
2016-01-29 17:41:08 -05:00
Arnavion 7f1ee9dad0 common: Moved some functions over from plugins/sysinfo that are useful for the rest of HC.
OS name, CPU, GPU, HDD info and build arch are now all available within core HC. OS name and build arch are used in the About dialog.
2015-10-12 19:20:53 +02:00
Patrick Griffis 599f5c7b29 win32: Don't rely on CWD for portable-mode check
Also cache the result...

Fixes #1500
2015-10-05 15:06:57 -04:00
TingPing b4906f3d23 Fix warnings 2015-03-19 16:06:49 -04:00
Berke Viktor a216ed1df9 Partial fix for Windows 10 detection 2015-02-04 04:48:44 -08:00
TingPing 5beaf15f21 Remove option to use socks5 library
This was always disabled by default and is not required
for the current socks support. I am not even sure this
library is packaged by any distro?
2014-12-28 22:29:06 -05:00
TingPing 95febd978c Fix building as c89 2014-12-28 06:47:23 -05:00
TingPing 83032b1aa3 Use glib for all allocations
- Removes need to check for malloc failure
- Removes need for NULL checks on free
- Adds checks for integer overflows
- Removes some extra memset calls
- Removes chance of mixing libc and glib malloc/free
2014-12-28 06:44:44 -05:00
TingPing aeb5d15871 More consistently include config.h 2014-12-17 18:21:10 -05:00
TingPing a86b03e939 Remove unused header 2014-12-15 11:07:47 -05:00
TingPing 35fd47da55 Add patch from cygwin 2014-12-15 11:07:47 -05:00
Arnavion 65c8494698 Removed some unnecessary casts. 2014-12-08 21:25:00 -08:00
Arnavion 2b94011fdc Removed some commented-out code. 2014-12-08 21:25:00 -08:00
Arnavion 65da34f19e Removed some unnecessary null-checks for calls to g_free and g_strfreev 2014-12-08 21:24:59 -08:00
TingPing c0769397d5 Fix possible crash in SASL Blowfish mech 2014-11-22 20:56:15 -05:00
Campbell Barton f83d78dd28 Warning cleanup
- ignoring const
- declarations after statements
- some C files didnt include own headers (risking them getting out of sync)

Closes #1064
2014-11-02 14:41:20 -05:00
TingPing a854234c1f Fix warning 2014-07-28 16:18:27 -04:00
Arnavion 7c2c8b1403 Fixed expand_homedir to handle paths like "~user" correctly. 2014-07-28 14:49:14 -04:00
TingPing f1e853c1cb Disable tray support on Elementary
They followed Ubuntu in breaking any gtk trays..
2014-07-05 13:08:48 -04:00
TingPing 45526205ab Remove broken debug code 2014-06-21 22:21:12 -04:00
TingPing 3cd8556c54 Use GDir instead of dirent 2014-06-04 13:56:33 -04:00
TingPing 5849a0588e Use glib to parse and launch commands for util_exec
Fixes #958
2014-06-04 10:38:23 -04:00
TingPing b8c02f71d9 win32: Use config.h instead of config-win32.h 2014-06-04 10:30:18 -04:00
Berke Viktor b049757302 Replace deprecated GetVersionEx calls with version helpers
Only compiles with 8.1 SDK but runs everywhere

Closes #957
2014-04-24 06:55:16 -04:00
Arnavion dc27640265 Use utf-8 variant of strftime to format log file paths.
strftime assumes the format string is in locale encoding, which mangles log file paths that are in utf-8.

Fixes #767
Fixes #945
2014-04-21 01:39:28 -07:00
TingPing b17c0276de Fix some leaks 2014-02-12 10:31:11 -05:00
TingPing ba399eb7f9 Remove unused function 2014-02-12 10:20:23 -05:00
TingPing 3a7fb4d8e1 osx: Set Menlo as default font
This moves the find_font function to the front ends since it depends on
pango and cairo
2014-02-04 20:45:29 -05:00
Diogo Sousa 9969282c72 Now make_ping_time() in common/util.c returns the time in milliseconds instead
of microseconds.
In fe_set_lag(serv, lag) the lag argument is now in milliseconds as well.

Fixes #758.
2014-01-30 19:23:35 +00:00
TingPing af248ce2c1 Fix invalid timestamps crashing on Windows 2013-11-02 21:07:03 -04:00
TingPing c7a00a4aba Only show users country if its not unknown 2013-09-25 17:16:47 -04:00
TingPing bdb18828e3 Disable challangeauth without openssl 2013-09-07 18:59:29 -04:00
TingPing a903f16c68 Implement BLOWFISh, AES, and EXTERNAL SASL mechanisms
Closes #657
2013-09-07 18:59:28 -04:00
Berke Viktor 1432ecfb33 Sample code docs for challengeauth_response() 2013-05-20 12:38:50 +02:00
Berke Viktor c0cc6a2c93 Cosmetics 2013-05-19 11:49:27 +03:00
Berke Viktor f778245a86 Simplify SASL auth string generation code 2013-05-19 01:21:27 +02:00
Berke Viktor a1a94ed319 Add support for QuakeNet /CHALLENGEAUTH, remove legacy /AUTH 2013-05-17 01:40:07 +02:00
Berke Viktor 947dd45294 Fix warnings 2013-05-14 16:52:16 +02:00
Berke Viktor fb01d4e9ab Replace g_strdup_printf with g_build_filename where possible 2013-05-04 18:21:48 +02:00
Berke Viktor 9c49254abd Only include top level includes from GTK+, GLib and GDK-PixBuf 2013-04-02 20:39:37 -07:00
Berke Viktor 5e59578e28 Remove most of HexTray and one instance
You can still build HexTray manually if you want to try fixing it
2013-04-02 11:56:08 -07:00
TingPing e9a3528bbd Disable tray when using Unity 2013-03-25 02:41:13 -04:00
RichardHitt 672dbf75d6 Oops, fixed error in util.c 2013-01-09 14:53:19 -08:00
RichardHitt 6beef589e3 Make source cleah with cppcheck, except for mpc and sasl 2013-01-09 14:37:57 -08:00