From d2834d3bb2d525de92d06936785927d6f2b5ef9b Mon Sep 17 00:00:00 2001
From: Nolan Lawson <nolan@nolanlawson.com>
Date: Thu, 22 Mar 2018 00:01:19 -0700
Subject: [PATCH] dial back rIC usage, fix virtualListStore calculations

---
 .../pseudoVirtualList/PseudoVirtualListLazyItem.html     | 8 +++-----
 routes/_components/virtualList/VirtualListLazyItem.html  | 9 +++------
 routes/_components/virtualList/virtualListStore.js       | 6 +++---
 3 files changed, 9 insertions(+), 14 deletions(-)

diff --git a/routes/_components/pseudoVirtualList/PseudoVirtualListLazyItem.html b/routes/_components/pseudoVirtualList/PseudoVirtualListLazyItem.html
index 216beac..d115be7 100644
--- a/routes/_components/pseudoVirtualList/PseudoVirtualListLazyItem.html
+++ b/routes/_components/pseudoVirtualList/PseudoVirtualListLazyItem.html
@@ -23,11 +23,9 @@
       let key = this.get('key')
       if (makeProps) {
         let props = await makeProps(key)
-        requestAnimationFrame(() => { // delay slightly to avoid slow scrolling
-          mark('PseudoVirtualListLazyItem set props')
-          this.set({props: props})
-          stop('PseudoVirtualListLazyItem set props')
-        })
+        mark('PseudoVirtualListLazyItem set props')
+        this.set({props: props})
+        stop('PseudoVirtualListLazyItem set props')
       }
     },
     components: {
diff --git a/routes/_components/virtualList/VirtualListLazyItem.html b/routes/_components/virtualList/VirtualListLazyItem.html
index 828796a..e98f54b 100644
--- a/routes/_components/virtualList/VirtualListLazyItem.html
+++ b/routes/_components/virtualList/VirtualListLazyItem.html
@@ -9,7 +9,6 @@
 <script>
   import VirtualListItem from './VirtualListItem'
   import { mark, stop } from '../../_utils/marks'
-  import { scheduleIdleTask } from '../../_utils/scheduleIdleTask'
 
   export default {
     async oncreate() {
@@ -19,11 +18,9 @@
       let key = this.get('key')
       if (makeProps) {
         let props = await makeProps(key)
-        scheduleIdleTask(() => { // delay slightly to avoid slow scrolling
-          mark('VirtualListLazyItem set props')
-          this.set({props: props})
-          stop('VirtualListLazyItem set props')
-        })
+        mark('VirtualListLazyItem set props')
+        this.set({props: props})
+        stop('VirtualListLazyItem set props')
       }
     },
     components: {
diff --git a/routes/_components/virtualList/virtualListStore.js b/routes/_components/virtualList/virtualListStore.js
index cc44dd2..6c1a91e 100644
--- a/routes/_components/virtualList/virtualListStore.js
+++ b/routes/_components/virtualList/virtualListStore.js
@@ -2,7 +2,7 @@ import { mark, stop } from '../../_utils/marks'
 import { RealmStore } from '../../_utils/RealmStore'
 import { reselect } from '../../_utils/reselect'
 
-const VIEWPORT_RENDER_FACTOR = 5
+const RENDER_BUFFER_FACTOR = 1.5
 
 class VirtualListStore extends RealmStore {
   constructor (state) {
@@ -30,7 +30,7 @@ virtualListStore.compute('rawVisibleItems',
       if (!items) {
         return null
       }
-      let renderBuffer = VIEWPORT_RENDER_FACTOR * offsetHeight
+      let renderBuffer = RENDER_BUFFER_FACTOR * offsetHeight
       let visibleItems = []
       let totalOffset = showHeader ? headerHeight : 0
       let len = items.length
@@ -46,7 +46,7 @@ virtualListStore.compute('rawVisibleItems',
             continue // above the area we want to render
           }
         } else {
-          if (currentOffset > (scrollTop + height + renderBuffer)) {
+          if (currentOffset > (scrollTop + offsetHeight + renderBuffer)) {
             break // below the area we want to render
           }
         }