From b8d862618aa46ea0f9a3b930ca2c2ee823ed5835 Mon Sep 17 00:00:00 2001
From: Nolan Lawson <nolan@nolanlawson.com>
Date: Thu, 12 Apr 2018 21:17:57 -0700
Subject: [PATCH] Use display:none for virtual list header (#96)

Fixes #59 by using display:none instead of opacity/pointer-events tricks while still showing an animation
---
 .../virtualList/VirtualListHeader.html        | 38 ++++++++++++++-----
 1 file changed, 28 insertions(+), 10 deletions(-)

diff --git a/routes/_components/virtualList/VirtualListHeader.html b/routes/_components/virtualList/VirtualListHeader.html
index 3ff9a79..69194bd 100644
--- a/routes/_components/virtualList/VirtualListHeader.html
+++ b/routes/_components/virtualList/VirtualListHeader.html
@@ -1,5 +1,4 @@
-<div class="virtual-list-header {{shown ? 'shown' : ''}}"
-     aria-hidden="{{!shown}}"
+<div class="virtual-list-header {{shown ? 'shown' : ''}} {{fadedIn ? 'faded-in' : ''}}"
      ref:node >
   <:Component {component} :virtualProps />
 </div>
@@ -9,28 +8,47 @@
     top: 0;
     width: 100%;
     opacity: 0;
-    pointer-events: none;
     z-index: 10;
     transition: none;
+    display: none;
   }
   .virtual-list-header.shown {
-    opacity: 1;
-    pointer-events: auto;
+    display: block;
     transition: opacity 0.333s linear;
   }
+  .virtual-list-header.faded-in {
+    opacity: 1;
+  }
 </style>
 <script>
   import { virtualListStore } from './virtualListStore'
   import { AsyncLayout } from '../../_utils/AsyncLayout'
+  import { doubleRAF } from '../../_utils/doubleRAF'
 
   export default {
     oncreate() {
-      const asyncLayout = new AsyncLayout(() => '__header__')
-      asyncLayout.observe('__header__', this.refs.node, (rect) => {
-        asyncLayout.disconnect()
-        this.store.setForRealm({headerHeight: rect.height})
-      })
+      this.observe('shown', shown => {
+        if (shown) {
+          this.doCalculateHeight()
+          doubleRAF(() => this.set({fadedIn: true})) //  animate in
+        } else {
+          this.set({fadedIn: false})
+        }
+      }, {init: false})
     },
     store: () => virtualListStore,
+    methods: {
+      doCalculateHeight() {
+        if (this.get('heightCalculated')) { // only need to calculate once, it never changes
+          return
+        }
+        this.set({heightCalculated: true})
+        const asyncLayout = new AsyncLayout(() => '__header__')
+        asyncLayout.observe('__header__', this.refs.node, (rect) => {
+          asyncLayout.disconnect()
+          this.store.setForRealm({headerHeight: rect.height})
+        })
+      }
+    }
   }
 </script>
\ No newline at end of file