From 624020dd0165f4eda78358b286c4ae2ceabd2ad6 Mon Sep 17 00:00:00 2001
From: Nolan Lawson <nolan@nolanlawson.com>
Date: Mon, 12 Mar 2018 20:18:34 -0700
Subject: [PATCH] improve keyboard latency in compose box

---
 .../compose/ComposeLengthGauge.html           | 24 +++++++++----------
 .../compose/ComposeLengthIndicator.html       | 22 +++++++++--------
 2 files changed, 24 insertions(+), 22 deletions(-)

diff --git a/routes/_components/compose/ComposeLengthGauge.html b/routes/_components/compose/ComposeLengthGauge.html
index 3ff60b3..f1dfe3a 100644
--- a/routes/_components/compose/ComposeLengthGauge.html
+++ b/routes/_components/compose/ComposeLengthGauge.html
@@ -1,5 +1,5 @@
 <div class="compose-box-length-gauge {{shouldAnimate ? 'should-animate' : ''}}  {{overLimit ? 'over-char-limit' : ''}}"
-     style="transform: scaleX({{lengthAsFractionRoundedAfterRaf || 0}});"
+     style="transform: scaleX({{lengthAsFractionDeferred || 0}});"
      aria-hidden="true"
 ></div>
 <style>
@@ -21,27 +21,27 @@
   import { CHAR_LIMIT } from '../../_static/statuses'
   import { mark, stop } from '../../_utils/marks'
   import { store } from '../../_store/store'
+  import { scheduleIdleTask } from '../../_utils/scheduleIdleTask'
 
   export default {
     oncreate() {
+      this.set({lengthAsFractionDeferred: this.get('lengthAsFraction')})
       // perf improvement for keyboard input latency
-      this.observe('lengthAsFractionRounded', lengthAsFractionRounded => {
-        requestAnimationFrame(() => {
-          mark('set lengthAsFractionRoundedAfterRaf')
-          this.set({lengthAsFractionRoundedAfterRaf: lengthAsFractionRounded})
-          stop('set lengthAsFractionRoundedAfterRaf')
+      this.observe('lengthAsFraction', () => {
+        scheduleIdleTask(() => {
+          mark('set lengthAsFractionDeferred')
+          this.set({lengthAsFractionDeferred: this.get('lengthAsFraction')})
+          stop('set lengthAsFractionDeferred')
           requestAnimationFrame(() => this.set({shouldAnimate: true}))
         })
-      })
+      }, {init: false})
     },
     store: () => store,
     computed: {
-      lengthAsFraction: (length) => Math.min(CHAR_LIMIT, length) / CHAR_LIMIT,
-      lengthAsFractionRounded: (lengthAsFraction) => {
+      lengthAsFraction: (length) => {
         // We don't need to update the gauge for every decimal point, so round it to the nearest 0.02
-        let int = Math.round(lengthAsFraction * 100)
-        int -= (int % 2)
-        return int / 100
+        let int = Math.round(Math.min(CHAR_LIMIT, length) / CHAR_LIMIT * 100)
+        return (int - (int % 2)) / 100
       }
     }
 }
diff --git a/routes/_components/compose/ComposeLengthIndicator.html b/routes/_components/compose/ComposeLengthIndicator.html
index b4ee6e4..ce01def 100644
--- a/routes/_components/compose/ComposeLengthIndicator.html
+++ b/routes/_components/compose/ComposeLengthIndicator.html
@@ -1,6 +1,6 @@
 <span class="compose-box-length {{overLimit ? 'over-char-limit' : ''}}"
       aria-label="{{lengthLabel}}">
-      {{lengthToDisplayAfterRaf || '0'}}
+      {{lengthToDisplayDeferred || '0'}}
     </span>
 <style>
   .compose-box-length {
@@ -19,26 +19,28 @@
   import { CHAR_LIMIT } from '../../_static/statuses'
   import { mark, stop } from '../../_utils/marks'
   import { store } from '../../_store/store'
+  import { scheduleIdleTask } from '../../_utils/scheduleIdleTask'
 
   export default {
     oncreate() {
+      this.set({lengthToDisplayDeferred: this.get('lengthToDisplay')})
       // perf improvement for keyboard input latency
-      this.observe('lengthToDisplay', lengthToDisplay => {
-        requestAnimationFrame(() => {
-          mark('set lengthToDisplayAfterRaf')
-          this.set({lengthToDisplayAfterRaf: lengthToDisplay})
-          stop('set lengthToDisplayAfterRaf')
+      this.observe('lengthToDisplay', () => {
+        scheduleIdleTask(() => {
+          mark('set lengthToDisplayDeferred')
+          this.set({lengthToDisplayDeferred: this.get('lengthToDisplay')})
+          stop('set lengthToDisplayDeferred')
         })
-      })
+      }, {init: false})
     },
     store: () => store,
     computed: {
       lengthToDisplay: (length) => CHAR_LIMIT - length,
-      lengthLabel: (overLimit, lengthToDisplay) => {
+      lengthLabel: (overLimit, lengthToDisplayDeferred) => {
         if (overLimit) {
-          return `${lengthToDisplay} characters over limit`
+          return `${lengthToDisplayDeferred} characters over limit`
         } else {
-          return `${lengthToDisplay} characters remaining`
+          return `${lengthToDisplayDeferred} characters remaining`
         }
       }
     }