diff --git a/.babelrc b/.babelrc index 31f4e2e0c..37cdb1c20 100644 --- a/.babelrc +++ b/.babelrc @@ -14,6 +14,7 @@ "plugins": [ "syntax-dynamic-import", "transform-object-rest-spread", + "transform-class-properties", [ "react-intl", { diff --git a/app/javascript/mastodon/components/account.js b/app/javascript/mastodon/components/account.js index 9016bedb6..5850a8791 100644 --- a/app/javascript/mastodon/components/account.js +++ b/app/javascript/mastodon/components/account.js @@ -18,6 +18,15 @@ const messages = defineMessages({ class Account extends ImmutablePureComponent { + static propTypes = { + account: ImmutablePropTypes.map.isRequired, + me: PropTypes.number.isRequired, + onFollow: PropTypes.func.isRequired, + onBlock: PropTypes.func.isRequired, + onMute: PropTypes.func.isRequired, + intl: PropTypes.object.isRequired + }; + constructor (props, context) { super(props, context); this.handleFollow = this.handleFollow.bind(this); @@ -81,13 +90,4 @@ class Account extends ImmutablePureComponent { } -Account.propTypes = { - account: ImmutablePropTypes.map.isRequired, - me: PropTypes.number.isRequired, - onFollow: PropTypes.func.isRequired, - onBlock: PropTypes.func.isRequired, - onMute: PropTypes.func.isRequired, - intl: PropTypes.object.isRequired -} - export default injectIntl(Account); diff --git a/app/javascript/mastodon/components/attachment_list.js b/app/javascript/mastodon/components/attachment_list.js index 6df578b77..f6449e2c0 100644 --- a/app/javascript/mastodon/components/attachment_list.js +++ b/app/javascript/mastodon/components/attachment_list.js @@ -5,6 +5,10 @@ const filename = url => url.split('/').pop().split('#')[0].split('?')[0]; class AttachmentList extends React.PureComponent { + static propTypes = { + media: ImmutablePropTypes.list.isRequired + }; + render () { const { media } = this.props; @@ -24,10 +28,7 @@ class AttachmentList extends React.PureComponent { ); } + } -AttachmentList.propTypes = { - media: ImmutablePropTypes.list.isRequired -}; - export default AttachmentList; diff --git a/app/javascript/mastodon/components/autosuggest_textarea.js b/app/javascript/mastodon/components/autosuggest_textarea.js index 4d8f2882c..61e101f29 100644 --- a/app/javascript/mastodon/components/autosuggest_textarea.js +++ b/app/javascript/mastodon/components/autosuggest_textarea.js @@ -32,6 +32,25 @@ const textAtCursorMatchesToken = (str, caretPosition) => { class AutosuggestTextarea extends ImmutablePureComponent { + static propTypes = { + value: PropTypes.string, + suggestions: ImmutablePropTypes.list, + disabled: PropTypes.bool, + placeholder: PropTypes.string, + onSuggestionSelected: PropTypes.func.isRequired, + onSuggestionsClearRequested: PropTypes.func.isRequired, + onSuggestionsFetchRequested: PropTypes.func.isRequired, + onChange: PropTypes.func.isRequired, + onKeyUp: PropTypes.func, + onKeyDown: PropTypes.func, + onPaste: PropTypes.func.isRequired, + autoFocus: PropTypes.bool + }; + + static defaultProps = { + autoFucus: true + }; + constructor (props, context) { super(props, context); this.state = { @@ -194,25 +213,6 @@ class AutosuggestTextarea extends ImmutablePureComponent { ); } -}; - -AutosuggestTextarea.propTypes = { - value: PropTypes.string, - suggestions: ImmutablePropTypes.list, - disabled: PropTypes.bool, - placeholder: PropTypes.string, - onSuggestionSelected: PropTypes.func.isRequired, - onSuggestionsClearRequested: PropTypes.func.isRequired, - onSuggestionsFetchRequested: PropTypes.func.isRequired, - onChange: PropTypes.func.isRequired, - onKeyUp: PropTypes.func, - onKeyDown: PropTypes.func, - onPaste: PropTypes.func.isRequired, - autoFocus: PropTypes.bool -}; - -AutosuggestTextarea.defaultProps = { - autoFucus: true, -}; +} export default AutosuggestTextarea; diff --git a/app/javascript/mastodon/components/avatar.js b/app/javascript/mastodon/components/avatar.js index 76c561c91..90c84f32a 100644 --- a/app/javascript/mastodon/components/avatar.js +++ b/app/javascript/mastodon/components/avatar.js @@ -3,23 +3,31 @@ import PropTypes from 'prop-types'; class Avatar extends React.PureComponent { - constructor (props, context) { - super(props, context); + static propTypes = { + src: PropTypes.string.isRequired, + staticSrc: PropTypes.string, + size: PropTypes.number.isRequired, + style: PropTypes.object, + animate: PropTypes.bool, + inline: PropTypes.bool + }; - this.state = { - hovering: false - }; + static defaultProps = { + animate: false, + size: 20, + inline: false + }; - this.handleMouseEnter = this.handleMouseEnter.bind(this); - this.handleMouseLeave = this.handleMouseLeave.bind(this); - } + state = { + hovering: true + }; - handleMouseEnter () { + handleMouseEnter = () => { if (this.props.animate) return; this.setState({ hovering: true }); } - handleMouseLeave () { + handleMouseLeave = () => { if (this.props.animate) return; this.setState({ hovering: false }); } @@ -59,19 +67,4 @@ class Avatar extends React.PureComponent { } -Avatar.propTypes = { - src: PropTypes.string.isRequired, - staticSrc: PropTypes.string, - size: PropTypes.number.isRequired, - style: PropTypes.object, - animate: PropTypes.bool, - inline: PropTypes.bool -}; - -Avatar.defaultProps = { - animate: false, - size: 20, - inline: false -}; - export default Avatar; diff --git a/app/javascript/mastodon/components/avatar_overlay.js b/app/javascript/mastodon/components/avatar_overlay.js index afa0c6667..b76750513 100644 --- a/app/javascript/mastodon/components/avatar_overlay.js +++ b/app/javascript/mastodon/components/avatar_overlay.js @@ -2,6 +2,11 @@ import React from 'react'; import PropTypes from 'prop-types'; class AvatarOverlay extends React.PureComponent { + static propTypes = { + staticSrc: PropTypes.string.isRequired, + overlaySrc: PropTypes.string.isRequired + }; + render() { const {staticSrc, overlaySrc} = this.props; @@ -20,11 +25,7 @@ class AvatarOverlay extends React.PureComponent { ); } + } -AvatarOverlay.propTypes = { - staticSrc: PropTypes.string.isRequired, - overlaySrc: PropTypes.string.isRequired, -}; - export default AvatarOverlay; diff --git a/app/javascript/mastodon/components/button.js b/app/javascript/mastodon/components/button.js index 1063e0289..40a17f92e 100644 --- a/app/javascript/mastodon/components/button.js +++ b/app/javascript/mastodon/components/button.js @@ -3,12 +3,22 @@ import PropTypes from 'prop-types'; class Button extends React.PureComponent { - constructor (props, context) { - super(props, context); - this.handleClick = this.handleClick.bind(this); - } + static propTypes = { + text: PropTypes.node, + onClick: PropTypes.func, + disabled: PropTypes.bool, + block: PropTypes.bool, + secondary: PropTypes.bool, + size: PropTypes.number, + style: PropTypes.object, + children: PropTypes.node + }; - handleClick (e) { + static defaultProps = { + size: 36 + }; + + handleClick = (e) => { if (!this.props.disabled) { this.props.onClick(); } @@ -32,19 +42,4 @@ class Button extends React.PureComponent { } -Button.propTypes = { - text: PropTypes.node, - onClick: PropTypes.func, - disabled: PropTypes.bool, - block: PropTypes.bool, - secondary: PropTypes.bool, - size: PropTypes.number, - style: PropTypes.object, - children: PropTypes.node -}; - -Button.defaultProps = { - size: 36 -}; - export default Button; diff --git a/app/javascript/mastodon/components/column_back_button.js b/app/javascript/mastodon/components/column_back_button.js index bedc417fd..a4971f5f8 100644 --- a/app/javascript/mastodon/components/column_back_button.js +++ b/app/javascript/mastodon/components/column_back_button.js @@ -4,12 +4,11 @@ import PropTypes from 'prop-types'; class ColumnBackButton extends React.PureComponent { - constructor (props, context) { - super(props, context); - this.handleClick = this.handleClick.bind(this); - } + static contextTypes = { + router: PropTypes.object + }; - handleClick () { + handleClick = () => { if (window.history && window.history.length === 1) this.context.router.push("/"); else this.context.router.goBack(); } @@ -23,10 +22,6 @@ class ColumnBackButton extends React.PureComponent { ); } -}; - -ColumnBackButton.contextTypes = { - router: PropTypes.object -}; +} export default ColumnBackButton; diff --git a/app/javascript/mastodon/components/column_back_button_slim.js b/app/javascript/mastodon/components/column_back_button_slim.js index 9aa7e92c2..6966a138d 100644 --- a/app/javascript/mastodon/components/column_back_button_slim.js +++ b/app/javascript/mastodon/components/column_back_button_slim.js @@ -4,12 +4,11 @@ import PropTypes from 'prop-types'; class ColumnBackButtonSlim extends React.PureComponent { - constructor (props, context) { - super(props, context); - this.handleClick = this.handleClick.bind(this); - } + static contextTypes = { + router: PropTypes.object + }; - handleClick () { + handleClick = () => { this.context.router.push('/'); } @@ -25,8 +24,4 @@ class ColumnBackButtonSlim extends React.PureComponent { } } -ColumnBackButtonSlim.contextTypes = { - router: PropTypes.object -}; - export default ColumnBackButtonSlim; diff --git a/app/javascript/mastodon/components/column_collapsable.js b/app/javascript/mastodon/components/column_collapsable.js index 797946859..3154c977f 100644 --- a/app/javascript/mastodon/components/column_collapsable.js +++ b/app/javascript/mastodon/components/column_collapsable.js @@ -4,16 +4,19 @@ import PropTypes from 'prop-types'; class ColumnCollapsable extends React.PureComponent { - constructor (props, context) { - super(props, context); - this.state = { - collapsed: true - }; + static propTypes = { + icon: PropTypes.string.isRequired, + title: PropTypes.string, + fullHeight: PropTypes.number.isRequired, + children: PropTypes.node, + onCollapse: PropTypes.func + }; - this.handleToggleCollapsed = this.handleToggleCollapsed.bind(this); - } + state = { + collapsed: true + }; - handleToggleCollapsed () { + handleToggleCollapsed = () => { const currentState = this.state.collapsed; this.setState({ collapsed: !currentState }); @@ -46,12 +49,4 @@ class ColumnCollapsable extends React.PureComponent { } } -ColumnCollapsable.propTypes = { - icon: PropTypes.string.isRequired, - title: PropTypes.string, - fullHeight: PropTypes.number.isRequired, - children: PropTypes.node, - onCollapse: PropTypes.func -}; - export default ColumnCollapsable; diff --git a/app/javascript/mastodon/components/display_name.js b/app/javascript/mastodon/components/display_name.js index 6bdd06db7..e122debf4 100644 --- a/app/javascript/mastodon/components/display_name.js +++ b/app/javascript/mastodon/components/display_name.js @@ -5,6 +5,10 @@ import emojify from '../emoji'; class DisplayName extends React.PureComponent { + static propTypes = { + account: ImmutablePropTypes.map.isRequired + }; + render () { const displayName = this.props.account.get('display_name').length === 0 ? this.props.account.get('username') : this.props.account.get('display_name'); const displayNameHTML = { __html: emojify(escapeTextContentForBrowser(displayName)) }; @@ -16,10 +20,6 @@ class DisplayName extends React.PureComponent { ); } -}; - -DisplayName.propTypes = { - account: ImmutablePropTypes.map.isRequired } export default DisplayName; diff --git a/app/javascript/mastodon/components/dropdown_menu.js b/app/javascript/mastodon/components/dropdown_menu.js index aed0757b1..99432463c 100644 --- a/app/javascript/mastodon/components/dropdown_menu.js +++ b/app/javascript/mastodon/components/dropdown_menu.js @@ -4,20 +4,27 @@ import PropTypes from 'prop-types'; class DropdownMenu extends React.PureComponent { - constructor (props, context) { - super(props, context); - this.state = { - direction: 'left' - }; - this.setRef = this.setRef.bind(this); - this.renderItem = this.renderItem.bind(this); - } + static propTypes = { + icon: PropTypes.string.isRequired, + items: PropTypes.array.isRequired, + size: PropTypes.number.isRequired, + direction: PropTypes.string, + ariaLabel: PropTypes.string + }; - setRef (c) { + static defaultProps = { + ariaLabel: "Menu" + }; + + state = { + direction: 'left' + }; + + setRef = (c) => { this.dropdown = c; } - handleClick (i, e) { + handleClick = (i, e) => { const { action } = this.props.items[i]; if (typeof action === 'function') { @@ -27,7 +34,7 @@ class DropdownMenu extends React.PureComponent { } } - renderItem (item, i) { + renderItem = (item, i) => { if (item === null) { return
; } @@ -64,16 +71,4 @@ class DropdownMenu extends React.PureComponent { } -DropdownMenu.propTypes = { - icon: PropTypes.string.isRequired, - items: PropTypes.array.isRequired, - size: PropTypes.number.isRequired, - direction: PropTypes.string, - ariaLabel: PropTypes.string -}; - -DropdownMenu.defaultProps = { - ariaLabel: "Menu" -}; - export default DropdownMenu; diff --git a/app/javascript/mastodon/components/extended_video_player.js b/app/javascript/mastodon/components/extended_video_player.js index 34ede66fd..a07d27186 100644 --- a/app/javascript/mastodon/components/extended_video_player.js +++ b/app/javascript/mastodon/components/extended_video_player.js @@ -3,13 +3,14 @@ import PropTypes from 'prop-types'; class ExtendedVideoPlayer extends React.PureComponent { - constructor (props, context) { - super(props, context); - this.handleLoadedData = this.handleLoadedData.bind(this); - this.setRef = this.setRef.bind(this); - } + static propTypes = { + src: PropTypes.string.isRequired, + time: PropTypes.number, + controls: PropTypes.bool.isRequired, + muted: PropTypes.bool.isRequired + }; - handleLoadedData () { + handleLoadedData = () => { if (this.props.time) { this.video.currentTime = this.props.time; } @@ -23,7 +24,7 @@ class ExtendedVideoPlayer extends React.PureComponent { this.video.removeEventListener('loadeddata', this.handleLoadedData); } - setRef (c) { + setRef = (c) => { this.video = c; } @@ -44,11 +45,4 @@ class ExtendedVideoPlayer extends React.PureComponent { } -ExtendedVideoPlayer.propTypes = { - src: PropTypes.string.isRequired, - time: PropTypes.number, - controls: PropTypes.bool.isRequired, - muted: PropTypes.bool.isRequired -}; - export default ExtendedVideoPlayer; diff --git a/app/javascript/mastodon/components/icon_button.js b/app/javascript/mastodon/components/icon_button.js index 87324b6c8..b229e5748 100644 --- a/app/javascript/mastodon/components/icon_button.js +++ b/app/javascript/mastodon/components/icon_button.js @@ -4,12 +4,30 @@ import PropTypes from 'prop-types'; class IconButton extends React.PureComponent { - constructor (props, context) { - super(props, context); - this.handleClick = this.handleClick.bind(this); - } + static propTypes = { + className: PropTypes.string, + title: PropTypes.string.isRequired, + icon: PropTypes.string.isRequired, + onClick: PropTypes.func, + size: PropTypes.number, + active: PropTypes.bool, + style: PropTypes.object, + activeStyle: PropTypes.object, + disabled: PropTypes.bool, + inverted: PropTypes.bool, + animate: PropTypes.bool, + overlay: PropTypes.bool + }; - handleClick (e) { + static defaultProps = { + size: 18, + active: false, + disabled: false, + animate: false, + overlay: false + }; + + handleClick = (e) => { e.preventDefault(); if (!this.props.disabled) { @@ -70,27 +88,4 @@ class IconButton extends React.PureComponent { } -IconButton.propTypes = { - className: PropTypes.string, - title: PropTypes.string.isRequired, - icon: PropTypes.string.isRequired, - onClick: PropTypes.func, - size: PropTypes.number, - active: PropTypes.bool, - style: PropTypes.object, - activeStyle: PropTypes.object, - disabled: PropTypes.bool, - inverted: PropTypes.bool, - animate: PropTypes.bool, - overlay: PropTypes.bool -}; - -IconButton.defaultProps = { - size: 18, - active: false, - disabled: false, - animate: false, - overlay: false -}; - export default IconButton; diff --git a/app/javascript/mastodon/components/media_gallery.js b/app/javascript/mastodon/components/media_gallery.js index dc08c457d..92b1825bf 100644 --- a/app/javascript/mastodon/components/media_gallery.js +++ b/app/javascript/mastodon/components/media_gallery.js @@ -10,12 +10,16 @@ const messages = defineMessages({ }); class Item extends React.PureComponent { - constructor (props, context) { - super(props, context); - this.handleClick = this.handleClick.bind(this); - } - handleClick (e) { + static propTypes = { + attachment: ImmutablePropTypes.map.isRequired, + index: PropTypes.number.isRequired, + size: PropTypes.number.isRequired, + onClick: PropTypes.func.isRequired, + autoPlayGif: PropTypes.bool.isRequired + }; + + handleClick = (e) => { const { index, onClick } = this.props; if (e.button === 0) { @@ -119,30 +123,26 @@ class Item extends React.PureComponent { } -Item.propTypes = { - attachment: ImmutablePropTypes.map.isRequired, - index: PropTypes.number.isRequired, - size: PropTypes.number.isRequired, - onClick: PropTypes.func.isRequired, - autoPlayGif: PropTypes.bool.isRequired -}; - class MediaGallery extends React.PureComponent { - constructor (props, context) { - super(props, context); - this.state = { - visible: !props.sensitive - }; - this.handleOpen = this.handleOpen.bind(this); - this.handleClick = this.handleClick.bind(this); - } + static propTypes = { + sensitive: PropTypes.bool, + media: ImmutablePropTypes.list.isRequired, + height: PropTypes.number.isRequired, + onOpenMedia: PropTypes.func.isRequired, + intl: PropTypes.object.isRequired, + autoPlayGif: PropTypes.bool.isRequired + }; - handleOpen (e) { + state = { + visible: !props.sensitive + }; + + handleOpen = (e) => { this.setState({ visible: !this.state.visible }); } - handleClick (index) { + handleClick = (index) => { this.props.onOpenMedia(this.props.media, index); } @@ -184,13 +184,4 @@ class MediaGallery extends React.PureComponent { } -MediaGallery.propTypes = { - sensitive: PropTypes.bool, - media: ImmutablePropTypes.list.isRequired, - height: PropTypes.number.isRequired, - onOpenMedia: PropTypes.func.isRequired, - intl: PropTypes.object.isRequired, - autoPlayGif: PropTypes.bool.isRequired -}; - export default injectIntl(MediaGallery); diff --git a/app/javascript/mastodon/components/permalink.js b/app/javascript/mastodon/components/permalink.js index 26444f27c..531ece33f 100644 --- a/app/javascript/mastodon/components/permalink.js +++ b/app/javascript/mastodon/components/permalink.js @@ -3,12 +3,18 @@ import PropTypes from 'prop-types'; class Permalink extends React.PureComponent { - constructor (props, context) { - super(props, context); - this.handleClick = this.handleClick.bind(this); - } + static contextTypes = { + router: PropTypes.object + }; - handleClick (e) { + static propTypes = { + className: PropTypes.string, + href: PropTypes.string.isRequired, + to: PropTypes.string.isRequired, + children: PropTypes.node + }; + + handleClick = (e) => { if (e.button === 0) { e.preventDefault(); this.context.router.push(this.props.to); @@ -27,15 +33,4 @@ class Permalink extends React.PureComponent { } -Permalink.contextTypes = { - router: PropTypes.object -}; - -Permalink.propTypes = { - className: PropTypes.string, - href: PropTypes.string.isRequired, - to: PropTypes.string.isRequired, - children: PropTypes.node -}; - export default Permalink; diff --git a/app/javascript/mastodon/components/status.js b/app/javascript/mastodon/components/status.js index 4c4fb7e75..e82f1d7aa 100644 --- a/app/javascript/mastodon/components/status.js +++ b/app/javascript/mastodon/components/status.js @@ -17,18 +17,33 @@ import ImmutablePureComponent from 'react-immutable-pure-component'; class Status extends ImmutablePureComponent { - constructor (props, context) { - super(props, context); - this.handleClick = this.handleClick.bind(this); - this.handleAccountClick = this.handleAccountClick.bind(this); - } + static contextTypes = { + router: PropTypes.object + }; - handleClick () { + static propTypes = { + status: ImmutablePropTypes.map, + account: ImmutablePropTypes.map, + wrapped: PropTypes.bool, + onReply: PropTypes.func, + onFavourite: PropTypes.func, + onReblog: PropTypes.func, + onDelete: PropTypes.func, + onOpenMedia: PropTypes.func, + onOpenVideo: PropTypes.func, + onBlock: PropTypes.func, + me: PropTypes.number, + boostModal: PropTypes.bool, + autoPlayGif: PropTypes.bool, + muted: PropTypes.bool + }; + + handleClick = () => { const { status } = this.props; this.context.router.push(`/statuses/${status.getIn(['reblog', 'id'], status.get('id'))}`); } - handleAccountClick (id, e) { + handleAccountClick = (id, e) => { if (e.button === 0) { e.preventDefault(); this.context.router.push(`/accounts/${id}`); @@ -108,25 +123,4 @@ class Status extends ImmutablePureComponent { } -Status.contextTypes = { - router: PropTypes.object -}; - -Status.propTypes = { - status: ImmutablePropTypes.map, - account: ImmutablePropTypes.map, - wrapped: PropTypes.bool, - onReply: PropTypes.func, - onFavourite: PropTypes.func, - onReblog: PropTypes.func, - onDelete: PropTypes.func, - onOpenMedia: PropTypes.func, - onOpenVideo: PropTypes.func, - onBlock: PropTypes.func, - me: PropTypes.number, - boostModal: PropTypes.bool, - autoPlayGif: PropTypes.bool, - muted: PropTypes.bool -}; - export default Status; diff --git a/app/javascript/mastodon/components/status_action_bar.js b/app/javascript/mastodon/components/status_action_bar.js index 1c2445232..b3d5e442c 100644 --- a/app/javascript/mastodon/components/status_action_bar.js +++ b/app/javascript/mastodon/components/status_action_bar.js @@ -21,52 +21,57 @@ const messages = defineMessages({ class StatusActionBar extends React.PureComponent { - constructor (props, context) { - super(props, context); - this.handleReplyClick = this.handleReplyClick.bind(this); - this.handleFavouriteClick = this.handleFavouriteClick.bind(this); - this.handleReblogClick = this.handleReblogClick.bind(this); - this.handleDeleteClick = this.handleDeleteClick.bind(this); - this.handleMentionClick = this.handleMentionClick.bind(this); - this.handleMuteClick = this.handleMuteClick.bind(this); - this.handleBlockClick = this.handleBlockClick.bind(this); - this.handleOpen = this.handleOpen.bind(this); - this.handleReport = this.handleReport.bind(this); - } + static contextTypes = { + router: PropTypes.object + }; - handleReplyClick () { + static propTypes = { + status: ImmutablePropTypes.map.isRequired, + onReply: PropTypes.func, + onFavourite: PropTypes.func, + onReblog: PropTypes.func, + onDelete: PropTypes.func, + onMention: PropTypes.func, + onMute: PropTypes.func, + onBlock: PropTypes.func, + onReport: PropTypes.func, + me: PropTypes.number.isRequired, + intl: PropTypes.object.isRequired + }; + + handleReplyClick = () => { this.props.onReply(this.props.status, this.context.router); } - handleFavouriteClick () { + handleFavouriteClick = () => { this.props.onFavourite(this.props.status); } - handleReblogClick (e) { + handleReblogClick = (e) => { this.props.onReblog(this.props.status, e); } - handleDeleteClick () { + handleDeleteClick = () => { this.props.onDelete(this.props.status); } - handleMentionClick () { + handleMentionClick = () => { this.props.onMention(this.props.status.get('account'), this.context.router); } - handleMuteClick () { + handleMuteClick = () => { this.props.onMute(this.props.status.get('account')); } - handleBlockClick () { + handleBlockClick = () => { this.props.onBlock(this.props.status.get('account')); } - handleOpen () { + handleOpen = () => { this.context.router.push(`/statuses/${this.props.status.get('id')}`); } - handleReport () { + handleReport = () => { this.props.onReport(this.props.status); this.context.router.push('/report'); } @@ -122,22 +127,4 @@ class StatusActionBar extends React.PureComponent { } -StatusActionBar.contextTypes = { - router: PropTypes.object -}; - -StatusActionBar.propTypes = { - status: ImmutablePropTypes.map.isRequired, - onReply: PropTypes.func, - onFavourite: PropTypes.func, - onReblog: PropTypes.func, - onDelete: PropTypes.func, - onMention: PropTypes.func, - onMute: PropTypes.func, - onBlock: PropTypes.func, - onReport: PropTypes.func, - me: PropTypes.number.isRequired, - intl: PropTypes.object.isRequired -}; - export default injectIntl(StatusActionBar); diff --git a/app/javascript/mastodon/components/status_content.js b/app/javascript/mastodon/components/status_content.js index e613f829f..f7d6b750f 100644 --- a/app/javascript/mastodon/components/status_content.js +++ b/app/javascript/mastodon/components/status_content.js @@ -9,19 +9,17 @@ import Permalink from './permalink'; class StatusContent extends React.PureComponent { - constructor (props, context) { - super(props, context); + static contextTypes = { + router: PropTypes.object + }; - this.state = { - hidden: true - }; + static propTypes = { + status: ImmutablePropTypes.map.isRequired, + onClick: PropTypes.func + }; - this.onMentionClick = this.onMentionClick.bind(this); - this.onHashtagClick = this.onHashtagClick.bind(this); - this.handleMouseDown = this.handleMouseDown.bind(this) - this.handleMouseUp = this.handleMouseUp.bind(this); - this.handleSpoilerClick = this.handleSpoilerClick.bind(this); - this.setRef = this.setRef.bind(this); + state = { + hidden: true }; componentDidMount () { @@ -46,14 +44,14 @@ class StatusContent extends React.PureComponent { } } - onMentionClick (mention, e) { + onMentionClick = (mention, e) => { if (e.button === 0) { e.preventDefault(); this.context.router.push(`/accounts/${mention.get('id')}`); } } - onHashtagClick (hashtag, e) { + onHashtagClick = (hashtag, e) => { hashtag = hashtag.replace(/^#/, '').toLowerCase(); if (e.button === 0) { @@ -62,11 +60,11 @@ class StatusContent extends React.PureComponent { } } - handleMouseDown (e) { + handleMouseDown = (e) => { this.startXY = [e.clientX, e.clientY]; } - handleMouseUp (e) { + handleMouseUp = (e) => { const [ startX, startY ] = this.startXY; const [ deltaX, deltaY ] = [Math.abs(e.clientX - startX), Math.abs(e.clientY - startY)]; @@ -81,12 +79,12 @@ class StatusContent extends React.PureComponent { this.startXY = null; } - handleSpoilerClick (e) { + handleSpoilerClick = (e) => { e.preventDefault(); this.setState({ hidden: !this.state.hidden }); } - setRef (c) { + setRef = (c) => { this.node = c; } @@ -158,13 +156,4 @@ class StatusContent extends React.PureComponent { } -StatusContent.contextTypes = { - router: PropTypes.object -}; - -StatusContent.propTypes = { - status: ImmutablePropTypes.map.isRequired, - onClick: PropTypes.func -}; - export default StatusContent; diff --git a/app/javascript/mastodon/components/status_list.js b/app/javascript/mastodon/components/status_list.js index 9abf1fbfe..0413e9d5f 100644 --- a/app/javascript/mastodon/components/status_list.js +++ b/app/javascript/mastodon/components/status_list.js @@ -9,14 +9,25 @@ import ImmutablePureComponent from 'react-immutable-pure-component'; class StatusList extends ImmutablePureComponent { - constructor (props, context) { - super(props, context); - this.handleScroll = this.handleScroll.bind(this); - this.setRef = this.setRef.bind(this); - this.handleLoadMore = this.handleLoadMore.bind(this); - } + static propTypes = { + scrollKey: PropTypes.string.isRequired, + statusIds: ImmutablePropTypes.list.isRequired, + onScrollToBottom: PropTypes.func, + onScrollToTop: PropTypes.func, + onScroll: PropTypes.func, + shouldUpdateScroll: PropTypes.func, + isLoading: PropTypes.bool, + isUnread: PropTypes.bool, + hasMore: PropTypes.bool, + prepend: PropTypes.node, + emptyMessage: PropTypes.node + }; - handleScroll (e) { + static defaultProps = { + trackScroll: true + }; + + handleScroll = (e) => { const { scrollTop, scrollHeight, clientHeight } = e.target; const offset = scrollHeight - scrollTop - clientHeight; this._oldScrollPosition = scrollHeight - scrollTop; @@ -52,11 +63,11 @@ class StatusList extends ImmutablePureComponent { this.node.removeEventListener('scroll', this.handleScroll); } - setRef (c) { + setRef = (c) => { this.node = c; } - handleLoadMore (e) { + handleLoadMore = (e) => { e.preventDefault(); this.props.onScrollToBottom(); } @@ -109,22 +120,4 @@ class StatusList extends ImmutablePureComponent { } -StatusList.propTypes = { - scrollKey: PropTypes.string.isRequired, - statusIds: ImmutablePropTypes.list.isRequired, - onScrollToBottom: PropTypes.func, - onScrollToTop: PropTypes.func, - onScroll: PropTypes.func, - shouldUpdateScroll: PropTypes.func, - isLoading: PropTypes.bool, - isUnread: PropTypes.bool, - hasMore: PropTypes.bool, - prepend: PropTypes.node, - emptyMessage: PropTypes.node -}; - -StatusList.defaultProps = { - trackScroll: true -}; - export default StatusList; diff --git a/app/javascript/mastodon/components/video_player.js b/app/javascript/mastodon/components/video_player.js index dd3ea0ed4..ba6d97c84 100644 --- a/app/javascript/mastodon/components/video_player.js +++ b/app/javascript/mastodon/components/video_player.js @@ -13,31 +13,34 @@ const messages = defineMessages({ class VideoPlayer extends React.PureComponent { - constructor (props, context) { - super(props, context); - this.state = { - visible: !this.props.sensitive, - preview: true, - muted: true, - hasAudio: true, - videoError: false - }; + static propTypes = { + media: ImmutablePropTypes.map.isRequired, + width: PropTypes.number, + height: PropTypes.number, + sensitive: PropTypes.bool, + intl: PropTypes.object.isRequired, + autoplay: PropTypes.bool, + onOpenVideo: PropTypes.func.isRequired + }; - this.handleClick = this.handleClick.bind(this); - this.handleVideoClick = this.handleVideoClick.bind(this); - this.handleOpen = this.handleOpen.bind(this); - this.handleVisibility = this.handleVisibility.bind(this); - this.handleExpand = this.handleExpand.bind(this); - this.setRef = this.setRef.bind(this); - this.handleLoadedData = this.handleLoadedData.bind(this); - this.handleVideoError = this.handleVideoError.bind(this); - } + static defaultProps = { + width: 239, + height: 110 + }; - handleClick () { + state = { + visible: !this.props.sensitive, + preview: true, + muted: true, + hasAudio: true, + videoError: false + }; + + handleClick = () => { this.setState({ muted: !this.state.muted }); } - handleVideoClick (e) { + handleVideoClick = (e) => { e.stopPropagation(); const node = this.video; @@ -49,33 +52,33 @@ class VideoPlayer extends React.PureComponent { } } - handleOpen () { + handleOpen = () => { this.setState({ preview: !this.state.preview }); } - handleVisibility () { + handleVisibility = () => { this.setState({ visible: !this.state.visible, preview: true }); } - handleExpand () { + handleExpand = () => { this.video.pause(); this.props.onOpenVideo(this.props.media, this.video.currentTime); } - setRef (c) { + setRef = (c) => { this.video = c; } - handleLoadedData () { + handleLoadedData = () => { if (('WebkitAppearance' in document.documentElement.style && this.video.audioTracks.length === 0) || this.video.mozHasAudio === false) { this.setState({ hasAudio: false }); } } - handleVideoError () { + handleVideoError = () => { this.setState({ videoError: true }); } @@ -191,19 +194,4 @@ class VideoPlayer extends React.PureComponent { } -VideoPlayer.propTypes = { - media: ImmutablePropTypes.map.isRequired, - width: PropTypes.number, - height: PropTypes.number, - sensitive: PropTypes.bool, - intl: PropTypes.object.isRequired, - autoplay: PropTypes.bool, - onOpenVideo: PropTypes.func.isRequired -}; - -VideoPlayer.defaultProps = { - width: 239, - height: 110 -}; - export default injectIntl(VideoPlayer); diff --git a/app/javascript/mastodon/features/account/components/action_bar.js b/app/javascript/mastodon/features/account/components/action_bar.js index 069348050..e1b9f3c09 100644 --- a/app/javascript/mastodon/features/account/components/action_bar.js +++ b/app/javascript/mastodon/features/account/components/action_bar.js @@ -20,6 +20,17 @@ const messages = defineMessages({ class ActionBar extends React.PureComponent { + static propTypes = { + account: ImmutablePropTypes.map.isRequired, + me: PropTypes.number.isRequired, + onFollow: PropTypes.func, + onBlock: PropTypes.func.isRequired, + onMention: PropTypes.func.isRequired, + onReport: PropTypes.func.isRequired, + onMute: PropTypes.func.isRequired, + intl: PropTypes.object.isRequired + }; + render () { const { account, me, intl } = this.props; @@ -79,15 +90,4 @@ class ActionBar extends React.PureComponent { } -ActionBar.propTypes = { - account: ImmutablePropTypes.map.isRequired, - me: PropTypes.number.isRequired, - onFollow: PropTypes.func, - onBlock: PropTypes.func.isRequired, - onMention: PropTypes.func.isRequired, - onReport: PropTypes.func.isRequired, - onMute: PropTypes.func.isRequired, - intl: PropTypes.object.isRequired -}; - export default injectIntl(ActionBar); diff --git a/app/javascript/mastodon/features/account/components/header.js b/app/javascript/mastodon/features/account/components/header.js index fbaa5e9e6..e65f70595 100644 --- a/app/javascript/mastodon/features/account/components/header.js +++ b/app/javascript/mastodon/features/account/components/header.js @@ -25,23 +25,21 @@ const makeMapStateToProps = () => { class Avatar extends ImmutablePureComponent { - constructor (props, context) { - super(props, context); + static propTypes = { + account: ImmutablePropTypes.map.isRequired, + autoPlayGif: PropTypes.bool.isRequired + }; - this.state = { - isHovered: false - }; + state = { + isHovered: false + }; - this.handleMouseOver = this.handleMouseOver.bind(this); - this.handleMouseOut = this.handleMouseOut.bind(this); - } - - handleMouseOver () { + handleMouseOver = () => { if (this.state.isHovered) return; this.setState({ isHovered: true }); } - handleMouseOut () { + handleMouseOut = () => { if (!this.state.isHovered) return; this.setState({ isHovered: false }); } @@ -71,13 +69,16 @@ class Avatar extends ImmutablePureComponent { } -Avatar.propTypes = { - account: ImmutablePropTypes.map.isRequired, - autoPlayGif: PropTypes.bool.isRequired -}; - class Header extends ImmutablePureComponent { + static propTypes = { + account: ImmutablePropTypes.map, + me: PropTypes.number.isRequired, + onFollow: PropTypes.func.isRequired, + intl: PropTypes.object.isRequired, + autoPlayGif: PropTypes.bool.isRequired + }; + render () { const { account, me, intl } = this.props; @@ -139,12 +140,4 @@ class Header extends ImmutablePureComponent { } -Header.propTypes = { - account: ImmutablePropTypes.map, - me: PropTypes.number.isRequired, - onFollow: PropTypes.func.isRequired, - intl: PropTypes.object.isRequired, - autoPlayGif: PropTypes.bool.isRequired -}; - export default connect(makeMapStateToProps)(injectIntl(Header)); diff --git a/app/javascript/mastodon/features/account_timeline/components/header.js b/app/javascript/mastodon/features/account_timeline/components/header.js index b4dca3a57..d7226d9b2 100644 --- a/app/javascript/mastodon/features/account_timeline/components/header.js +++ b/app/javascript/mastodon/features/account_timeline/components/header.js @@ -8,33 +8,38 @@ import ImmutablePureComponent from 'react-immutable-pure-component'; class Header extends ImmutablePureComponent { - constructor (props, context) { - super(props, context); - this.handleFollow = this.handleFollow.bind(this); - this.handleBlock = this.handleBlock.bind(this); - this.handleMention = this.handleMention.bind(this); - this.handleReport = this.handleReport.bind(this); - this.handleMute = this.handleMute.bind(this); - } + static propTypes = { + account: ImmutablePropTypes.map, + me: PropTypes.number.isRequired, + onFollow: PropTypes.func.isRequired, + onBlock: PropTypes.func.isRequired, + onMention: PropTypes.func.isRequired, + onReport: PropTypes.func.isRequired, + onMute: PropTypes.func.isRequired + }; - handleFollow () { + static contextTypes = { + router: PropTypes.object + }; + + handleFollow = () => { this.props.onFollow(this.props.account); } - handleBlock () { + handleBlock = () => { this.props.onBlock(this.props.account); } - handleMention () { + handleMention = () => { this.props.onMention(this.props.account, this.context.router); } - handleReport () { + handleReport = () => { this.props.onReport(this.props.account); this.context.router.push('/report'); } - handleMute() { + handleMute = () => { this.props.onMute(this.props.account); } @@ -64,20 +69,7 @@ class Header extends ImmutablePureComponent { ); } + } -Header.propTypes = { - account: ImmutablePropTypes.map, - me: PropTypes.number.isRequired, - onFollow: PropTypes.func.isRequired, - onBlock: PropTypes.func.isRequired, - onMention: PropTypes.func.isRequired, - onReport: PropTypes.func.isRequired, - onMute: PropTypes.func.isRequired -}; - -Header.contextTypes = { - router: PropTypes.object -}; - export default Header; diff --git a/app/javascript/mastodon/features/account_timeline/index.js b/app/javascript/mastodon/features/account_timeline/index.js index fb76f4d2e..4a7ac3eba 100644 --- a/app/javascript/mastodon/features/account_timeline/index.js +++ b/app/javascript/mastodon/features/account_timeline/index.js @@ -24,24 +24,28 @@ const mapStateToProps = (state, props) => ({ class AccountTimeline extends ImmutablePureComponent { - constructor (props, context) { - super(props, context); - this.handleScrollToBottom = this.handleScrollToBottom.bind(this); - } + static propTypes = { + params: PropTypes.object.isRequired, + dispatch: PropTypes.func.isRequired, + statusIds: ImmutablePropTypes.list, + isLoading: PropTypes.bool, + hasMore: PropTypes.bool, + me: PropTypes.number.isRequired + }; componentWillMount () { this.props.dispatch(fetchAccount(Number(this.props.params.accountId))); this.props.dispatch(fetchAccountTimeline(Number(this.props.params.accountId))); } - componentWillReceiveProps(nextProps) { + componentWillReceiveProps (nextProps) { if (nextProps.params.accountId !== this.props.params.accountId && nextProps.params.accountId) { this.props.dispatch(fetchAccount(Number(nextProps.params.accountId))); this.props.dispatch(fetchAccountTimeline(Number(nextProps.params.accountId))); } } - handleScrollToBottom () { + handleScrollToBottom = () => { if (!this.props.isLoading && this.props.hasMore) { this.props.dispatch(expandAccountTimeline(Number(this.props.params.accountId))); } @@ -77,13 +81,4 @@ class AccountTimeline extends ImmutablePureComponent { } -AccountTimeline.propTypes = { - params: PropTypes.object.isRequired, - dispatch: PropTypes.func.isRequired, - statusIds: ImmutablePropTypes.list, - isLoading: PropTypes.bool, - hasMore: PropTypes.bool, - me: PropTypes.number.isRequired -}; - export default connect(mapStateToProps)(AccountTimeline); diff --git a/app/javascript/mastodon/features/blocks/index.js b/app/javascript/mastodon/features/blocks/index.js index e25d9b2b4..4af48cf9c 100644 --- a/app/javascript/mastodon/features/blocks/index.js +++ b/app/javascript/mastodon/features/blocks/index.js @@ -21,6 +21,13 @@ const mapStateToProps = state => ({ class Blocks extends ImmutablePureComponent { + static propTypes = { + params: PropTypes.object.isRequired, + dispatch: PropTypes.func.isRequired, + accountIds: ImmutablePropTypes.list, + intl: PropTypes.object.isRequired + }; + constructor (props, context) { super(props, context); this.handleScroll = this.handleScroll.bind(this); @@ -64,11 +71,4 @@ class Blocks extends ImmutablePureComponent { } } -Blocks.propTypes = { - params: PropTypes.object.isRequired, - dispatch: PropTypes.func.isRequired, - accountIds: ImmutablePropTypes.list, - intl: PropTypes.object.isRequired -}; - export default connect(mapStateToProps)(injectIntl(Blocks)); diff --git a/app/javascript/mastodon/features/community_timeline/index.js b/app/javascript/mastodon/features/community_timeline/index.js index 883263631..5b0efa77c 100644 --- a/app/javascript/mastodon/features/community_timeline/index.js +++ b/app/javascript/mastodon/features/community_timeline/index.js @@ -28,6 +28,14 @@ let subscription; class CommunityTimeline extends React.PureComponent { + static propTypes = { + dispatch: PropTypes.func.isRequired, + intl: PropTypes.object.isRequired, + streamingAPIBaseURL: PropTypes.string.isRequired, + accessToken: PropTypes.string.isRequired, + hasUnread: PropTypes.bool + }; + componentDidMount () { const { dispatch, streamingAPIBaseURL, accessToken } = this.props; @@ -85,12 +93,4 @@ class CommunityTimeline extends React.PureComponent { } -CommunityTimeline.propTypes = { - dispatch: PropTypes.func.isRequired, - intl: PropTypes.object.isRequired, - streamingAPIBaseURL: PropTypes.string.isRequired, - accessToken: PropTypes.string.isRequired, - hasUnread: PropTypes.bool -}; - export default connect(mapStateToProps)(injectIntl(CommunityTimeline)); diff --git a/app/javascript/mastodon/features/compose/components/autosuggest_account.js b/app/javascript/mastodon/features/compose/components/autosuggest_account.js index 3d87c4649..32bd3ec5c 100644 --- a/app/javascript/mastodon/features/compose/components/autosuggest_account.js +++ b/app/javascript/mastodon/features/compose/components/autosuggest_account.js @@ -6,6 +6,10 @@ import ImmutablePureComponent from 'react-immutable-pure-component'; class AutosuggestAccount extends ImmutablePureComponent { + static propTypes = { + account: ImmutablePropTypes.map.isRequired + }; + render () { const { account } = this.props; @@ -19,8 +23,4 @@ class AutosuggestAccount extends ImmutablePureComponent { } -AutosuggestAccount.propTypes = { - account: ImmutablePropTypes.map.isRequired -}; - export default AutosuggestAccount; diff --git a/app/javascript/mastodon/features/compose/components/character_counter.js b/app/javascript/mastodon/features/compose/components/character_counter.js index 617f85cfe..29598f953 100644 --- a/app/javascript/mastodon/features/compose/components/character_counter.js +++ b/app/javascript/mastodon/features/compose/components/character_counter.js @@ -4,6 +4,11 @@ import { length } from 'stringz'; class CharacterCounter extends React.PureComponent { + static propTypes = { + text: PropTypes.string.isRequired, + max: PropTypes.number.isRequired + }; + checkRemainingText (diff) { if (diff < 0) { return {diff}; @@ -19,9 +24,4 @@ class CharacterCounter extends React.PureComponent { } -CharacterCounter.propTypes = { - text: PropTypes.string.isRequired, - max: PropTypes.number.isRequired -} - export default CharacterCounter; diff --git a/app/javascript/mastodon/features/compose/components/compose_form.js b/app/javascript/mastodon/features/compose/components/compose_form.js index 530e50b2f..eeacae106 100644 --- a/app/javascript/mastodon/features/compose/components/compose_form.js +++ b/app/javascript/mastodon/features/compose/components/compose_form.js @@ -27,48 +27,63 @@ const messages = defineMessages({ class ComposeForm extends ImmutablePureComponent { - constructor (props, context) { - super(props, context); - this.handleChange = this.handleChange.bind(this); - this.handleKeyDown = this.handleKeyDown.bind(this); - this.handleSubmit = this.handleSubmit.bind(this); - this.onSuggestionsClearRequested = this.onSuggestionsClearRequested.bind(this); - this.onSuggestionsFetchRequested = debounce(this.onSuggestionsFetchRequested.bind(this), 500); - this.onSuggestionSelected = this.onSuggestionSelected.bind(this); - this.handleChangeSpoilerText = this.handleChangeSpoilerText.bind(this); - this.setAutosuggestTextarea = this.setAutosuggestTextarea.bind(this); - this.handleEmojiPick = this.handleEmojiPick.bind(this); - } + static propTypes = { + intl: PropTypes.object.isRequired, + text: PropTypes.string.isRequired, + suggestion_token: PropTypes.string, + suggestions: ImmutablePropTypes.list, + spoiler: PropTypes.bool, + privacy: PropTypes.string, + spoiler_text: PropTypes.string, + focusDate: PropTypes.instanceOf(Date), + preselectDate: PropTypes.instanceOf(Date), + is_submitting: PropTypes.bool, + is_uploading: PropTypes.bool, + me: PropTypes.number, + onChange: PropTypes.func.isRequired, + onSubmit: PropTypes.func.isRequired, + onClearSuggestions: PropTypes.func.isRequired, + onFetchSuggestions: PropTypes.func.isRequired, + onSuggestionSelected: PropTypes.func.isRequired, + onChangeSpoilerText: PropTypes.func.isRequired, + onPaste: PropTypes.func.isRequired, + onPickEmoji: PropTypes.func.isRequired, + showSearch: PropTypes.bool, + }; - handleChange (e) { + static defaultProps = { + showSearch: false + }; + + handleChange = (e) => { this.props.onChange(e.target.value); } - handleKeyDown (e) { + handleKeyDown = (e) => { if (e.keyCode === 13 && (e.ctrlKey || e.metaKey)) { this.handleSubmit(); } } - handleSubmit () { + handleSubmit = () => { this.autosuggestTextarea.reset(); this.props.onSubmit(); } - onSuggestionsClearRequested () { + onSuggestionsClearRequested = () => { this.props.onClearSuggestions(); } - onSuggestionsFetchRequested (token) { + onSuggestionsFetchRequested = (token) => { this.props.onFetchSuggestions(token); } - onSuggestionSelected (tokenStart, token, value) { + onSuggestionSelected = (tokenStart, token, value) => { this._restoreCaret = null; this.props.onSuggestionSelected(tokenStart, token, value); } - handleChangeSpoilerText (e) { + handleChangeSpoilerText = (e) => { this.props.onChangeSpoilerText(e.target.value); } @@ -107,11 +122,11 @@ class ComposeForm extends ImmutablePureComponent { } } - setAutosuggestTextarea (c) { + setAutosuggestTextarea = (c) => { this.autosuggestTextarea = c; } - handleEmojiPick (data) { + handleEmojiPick = (data) => { const position = this.autosuggestTextarea.textarea.selectionStart; this._restoreCaret = position + data.shortname.length + 1; this.props.onPickEmoji(position, data); @@ -185,32 +200,4 @@ class ComposeForm extends ImmutablePureComponent { } -ComposeForm.propTypes = { - intl: PropTypes.object.isRequired, - text: PropTypes.string.isRequired, - suggestion_token: PropTypes.string, - suggestions: ImmutablePropTypes.list, - spoiler: PropTypes.bool, - privacy: PropTypes.string, - spoiler_text: PropTypes.string, - focusDate: PropTypes.instanceOf(Date), - preselectDate: PropTypes.instanceOf(Date), - is_submitting: PropTypes.bool, - is_uploading: PropTypes.bool, - me: PropTypes.number, - onChange: PropTypes.func.isRequired, - onSubmit: PropTypes.func.isRequired, - onClearSuggestions: PropTypes.func.isRequired, - onFetchSuggestions: PropTypes.func.isRequired, - onSuggestionSelected: PropTypes.func.isRequired, - onChangeSpoilerText: PropTypes.func.isRequired, - onPaste: PropTypes.func.isRequired, - onPickEmoji: PropTypes.func.isRequired, - showSearch: PropTypes.bool, -}; - -ComposeForm.defaultProps = { - showSearch: false -}; - export default injectIntl(ComposeForm); diff --git a/app/javascript/mastodon/features/compose/components/emoji_picker_dropdown.js b/app/javascript/mastodon/features/compose/components/emoji_picker_dropdown.js index c95b4a279..9ad0ae296 100644 --- a/app/javascript/mastodon/features/compose/components/emoji_picker_dropdown.js +++ b/app/javascript/mastodon/features/compose/components/emoji_picker_dropdown.js @@ -40,28 +40,26 @@ let EmojiPicker; // load asynchronously class EmojiPickerDropdown extends React.PureComponent { - constructor (props, context) { - super(props, context); - this.setRef = this.setRef.bind(this); - this.handleChange = this.handleChange.bind(this); - this.onHideDropdown = this.onHideDropdown.bind(this); - this.onShowDropdown = this.onShowDropdown.bind(this); - this.state = { - active: false, - loading: false - }; - } + static propTypes = { + intl: PropTypes.object.isRequired, + onPickEmoji: PropTypes.func.isRequired + }; - setRef (c) { + state = { + active: false, + loading: false + }; + + setRef = (c) => { this.dropdown = c; } - handleChange (data) { + handleChange = (data) => { this.dropdown.hide(); this.props.onPickEmoji(data); } - onShowDropdown () { + onShowDropdown = () => { this.setState({active: true}); if (!EmojiPicker) { this.setState({loading: true}); @@ -75,7 +73,7 @@ class EmojiPickerDropdown extends React.PureComponent { } } - onHideDropdown () { + onHideDropdown = () => { this.setState({active: false}); } @@ -138,9 +136,4 @@ class EmojiPickerDropdown extends React.PureComponent { } -EmojiPickerDropdown.propTypes = { - intl: PropTypes.object.isRequired, - onPickEmoji: PropTypes.func.isRequired -}; - export default injectIntl(EmojiPickerDropdown); diff --git a/app/javascript/mastodon/features/compose/components/navigation_bar.js b/app/javascript/mastodon/features/compose/components/navigation_bar.js index aec8f6153..ca2d9c3f1 100644 --- a/app/javascript/mastodon/features/compose/components/navigation_bar.js +++ b/app/javascript/mastodon/features/compose/components/navigation_bar.js @@ -10,6 +10,10 @@ import ImmutablePureComponent from 'react-immutable-pure-component'; class NavigationBar extends ImmutablePureComponent { + static propTypes = { + account: ImmutablePropTypes.map.isRequired + }; + render () { return (