From 032956d3436fd3f32d9c82516e165ba9526de1e2 Mon Sep 17 00:00:00 2001
From: Vivian Lim <vivvnlim@gmail.com>
Date: Mon, 23 Dec 2019 00:22:35 -0800
Subject: [PATCH 1/5] Add keyboard input bindings

---
 examples/sdl2_emulator.rs | 95 +++++++++++++++++++++++++++++++--------
 1 file changed, 76 insertions(+), 19 deletions(-)

diff --git a/examples/sdl2_emulator.rs b/examples/sdl2_emulator.rs
index 8ca7db2..4dd24f4 100644
--- a/examples/sdl2_emulator.rs
+++ b/examples/sdl2_emulator.rs
@@ -48,6 +48,7 @@ struct MyEmulator {
     // input bits
     gamepad_subsys: sdl2::GameControllerSubsystem,
     gamepads: Vec<GameController>,
+    pressed_keys: Vec<Keycode>,
 }
 
 impl MyEmulator {
@@ -112,6 +113,8 @@ impl MyEmulator {
             gamepads.extend(gamepad_subsys.open(i).into_iter());
         }
 
+        let pressed_keys = Vec::new();
+
         let emu = MyEmulator {
             retro,
             core_path,
@@ -128,6 +131,7 @@ impl MyEmulator {
             audio_sender,
             gamepad_subsys,
             gamepads,
+            pressed_keys,
         };
         let mut pin_emu = Box::pin(emu);
         retro::wrapper::set_handler(pin_emu.as_mut());
@@ -152,6 +156,8 @@ impl MyEmulator {
                 }
             }
 
+            self.update_key_state(&event_pump.keyboard_state());
+
             // The rest of the game loop goes here...
             self.retro.run();
             self.canvas.present();
@@ -188,6 +194,11 @@ impl MyEmulator {
         }
     }
 
+    pub fn update_key_state<'a>(&mut self, keyboard_state: &sdl2::keyboard::KeyboardState<'a>){
+        let keys: Vec<Keycode> = keyboard_state.pressed_scancodes().filter_map(Keycode::from_scancode).collect();
+        self.pressed_keys = keys;
+    }
+
     fn send_audio_samples(&mut self) {
         let stereo_samples = self.audio_spec.samples as usize * 2;
         while self.audio_buffer.len() >= stereo_samples {
@@ -196,6 +207,44 @@ impl MyEmulator {
             let _ = self.audio_sender.try_send(msg);
         }
     }
+
+    fn input_state_gamepad(&mut self, port: u32, device: &InputDeviceId, index: &InputIndex) -> i16 {
+        match self.gamepads.get(port as usize) {
+            Some(gamepad) => {
+                match device {
+                    InputDeviceId::Joypad(button) => {
+                        match button_map(&button) {
+                            Some(x) => gamepad.button(x) as i16,
+                            None => match button {
+                                JoypadButton::L2 => gamepad.axis(Axis::TriggerLeft),
+                                JoypadButton::R2 => gamepad.axis(Axis::TriggerRight),
+                                _ => 0,
+                            }
+                        }
+                    }
+                    InputDeviceId::Analog(axis) => gamepad.axis(axis_map(index, axis)),
+                    _ => 0,
+                }
+            }
+            None => 0,
+        }
+    }
+
+    fn input_state_keyboard(&mut self, port: u32, device: &InputDeviceId, index: &InputIndex) -> i16 {
+        if port != 0 { // Keyboard only controls the first port.
+            return 0;
+        }
+
+        match device {
+            InputDeviceId::Joypad(button) => {
+                match keyboard_map(&button) {
+                    Some(x) => return if self.pressed_keys.contains(&x) {1} else {0},
+                    None => 0
+                }
+            },
+            _ => 0
+        }
+    }
 }
 
 impl Drop for MyEmulator {
@@ -241,25 +290,12 @@ impl retro::wrapper::Handler for MyEmulator {
     }
 
     fn input_state(&mut self, port: u32, device: InputDeviceId, index: InputIndex) -> i16 {
-        match self.gamepads.get(port as usize) {
-            Some(gamepad) => {
-                match device {
-                    InputDeviceId::Joypad(button) => {
-                        match button_map(&button) {
-                            Some(x) => gamepad.button(x) as i16,
-                            None => match button {
-                                JoypadButton::L2 => gamepad.axis(Axis::TriggerLeft),
-                                JoypadButton::R2 => gamepad.axis(Axis::TriggerRight),
-                                _ => 0,
-                            }
-                        }
-                    }
-                    InputDeviceId::Analog(axis) => gamepad.axis(axis_map(index, axis)),
-                    _ => 0,
-                }
-            }
-            None => 0,
+        let gamepad_state = self.input_state_gamepad(port, &device, &index);
+        if gamepad_state > 0 {
+            return gamepad_state;
         }
+
+        return self.input_state_keyboard(port, &device, &index);
     }
 
     fn get_can_dupe(&mut self) -> Option<bool> { Some(true) }
@@ -407,7 +443,28 @@ fn button_map(retro_button: &JoypadButton) -> Option<Button> {
     }
 }
 
-fn axis_map(index: InputIndex, axis: AnalogAxis) -> Axis {
+fn keyboard_map(retro_button: &JoypadButton) -> Option<Keycode> {
+    match retro_button {
+        JoypadButton::B => Some(Keycode::K),
+        JoypadButton::Y => Some(Keycode::J),
+        JoypadButton::Select => Some(Keycode::Num5),
+        JoypadButton::Start => Some(Keycode::Num6),
+        JoypadButton::Up => Some(Keycode::W),
+        JoypadButton::Down => Some(Keycode::S),
+        JoypadButton::Left => Some(Keycode::A),
+        JoypadButton::Right => Some(Keycode::D),
+        JoypadButton::A => Some(Keycode::L),
+        JoypadButton::X => Some(Keycode::I),
+        JoypadButton::L => Some(Keycode::Num1),
+        JoypadButton::R => Some(Keycode::Num0),
+        JoypadButton::L2 => None,
+        JoypadButton::R2 => None,
+        JoypadButton::L3 => None,
+        JoypadButton::R3 => None,
+    }
+}
+
+fn axis_map(index: &InputIndex, axis: &AnalogAxis) -> Axis {
     match (index, axis) {
         (InputIndex::Left, AnalogAxis::X) => Axis::LeftX,
         (InputIndex::Left, AnalogAxis::Y) => Axis::LeftY,

From 243d5b38895e66b30339805abc49854c887c362b Mon Sep 17 00:00:00 2001
From: Vivian Lim <vivvnlim@gmail.com>
Date: Mon, 23 Dec 2019 21:20:45 -0800
Subject: [PATCH 2/5] wrapper: invoke handler.set_memory_maps()

---
 src/retro/wrapper.rs | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/retro/wrapper.rs b/src/retro/wrapper.rs
index 0152361..d2412d8 100644
--- a/src/retro/wrapper.rs
+++ b/src/retro/wrapper.rs
@@ -307,7 +307,10 @@ impl StaticCallbacks {
                     .collect();
                 handler.set_controller_info(controller_info)
             }
-            // TODO (experimental) EnvCmd::SetMemoryMaps => {},
+            EnvCmd::SetMemoryMaps => {
+                let map = Self::from_void::<MemoryMap>(data)?.clone();
+                handler.set_memory_maps(map)
+            },
             EnvCmd::SetGeometry => {
                 handler.set_geometry(Self::from_void::<GameGeometry>(data)?.clone())
             }

From 84973982b4a693891925c5954d90e6b93ae8930e Mon Sep 17 00:00:00 2001
From: Vivian Lim <vivvnlim@gmail.com>
Date: Mon, 23 Dec 2019 21:23:18 -0800
Subject: [PATCH 3/5] use gamepad_state for any non-zero value, instead of just
 positive ones.

---
 examples/sdl2_emulator.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/sdl2_emulator.rs b/examples/sdl2_emulator.rs
index 4dd24f4..a0f000b 100644
--- a/examples/sdl2_emulator.rs
+++ b/examples/sdl2_emulator.rs
@@ -291,7 +291,7 @@ impl retro::wrapper::Handler for MyEmulator {
 
     fn input_state(&mut self, port: u32, device: InputDeviceId, index: InputIndex) -> i16 {
         let gamepad_state = self.input_state_gamepad(port, &device, &index);
-        if gamepad_state > 0 {
+        if gamepad_state != 0 {
             return gamepad_state;
         }
 

From 6ae54e8ea247c479bc3bba549ed3e37fa920ea0f Mon Sep 17 00:00:00 2001
From: Vivian Lim <vivvnlim@gmail.com>
Date: Mon, 23 Dec 2019 21:24:45 -0800
Subject: [PATCH 4/5] add check for infinite framerate, which I saw on
 gambatte/windows

---
 examples/sdl2_emulator.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/sdl2_emulator.rs b/examples/sdl2_emulator.rs
index 8ca7db2..293dc90 100644
--- a/examples/sdl2_emulator.rs
+++ b/examples/sdl2_emulator.rs
@@ -158,7 +158,7 @@ impl MyEmulator {
 
             // similar hack to the sample rate, make sure we don't divide by zero.
             let mut spf = 1.0 / self.av_info.timing.fps;
-            if spf.is_nan() {
+            if spf.is_nan() || spf.is_infinite() {
                 spf = 1.0 / 60.0;
             }
             Duration::from_secs_f64(spf)

From abff72a694fc464ee943ad69d0cbf9dc73962754 Mon Sep 17 00:00:00 2001
From: lif <lifning+git@pm.me>
Date: Sat, 25 Jan 2020 12:18:35 -0800
Subject: [PATCH 5/5] fix a warning & the cargo version of ffmpeg4

---
 Cargo.toml                | 2 +-
 examples/sdl2_emulator.rs | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Cargo.toml b/Cargo.toml
index 2b76f12..e3c6866 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -19,4 +19,4 @@ sdl2 = "^0.32"
 crossbeam-channel = "^0.4"
 structopt = "^0.3"
 # example: ffmpeg_recorder
-ffmpeg4 = "*"
+ffmpeg4 = "0.4.0"
diff --git a/examples/sdl2_emulator.rs b/examples/sdl2_emulator.rs
index 71a0a0f..e0c54ed 100644
--- a/examples/sdl2_emulator.rs
+++ b/examples/sdl2_emulator.rs
@@ -230,7 +230,7 @@ impl MyEmulator {
         }
     }
 
-    fn input_state_keyboard(&mut self, port: u32, device: &InputDeviceId, index: &InputIndex) -> i16 {
+    fn input_state_keyboard(&mut self, port: u32, device: &InputDeviceId, _index: &InputIndex) -> i16 {
         if port != 0 { // Keyboard only controls the first port.
             return 0;
         }