From 56f5a45221142bfc3a190fbed1e02e1766f35054 Mon Sep 17 00:00:00 2001
From: Nolan Lawson <nolan@nolanlawson.com>
Date: Sat, 9 Feb 2019 19:05:59 -0800
Subject: [PATCH] fix: fix aria-hidden on hidden icons (#957)

---
 src/routes/_components/IconButton.html                      | 5 ++++-
 src/routes/_components/dialog/components/MediaDialog.html   | 1 +
 src/routes/_components/dialog/components/PinchZoomable.html | 2 ++
 3 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/routes/_components/IconButton.html b/src/routes/_components/IconButton.html
index 51d5de8..ea9257b 100644
--- a/src/routes/_components/IconButton.html
+++ b/src/routes/_components/IconButton.html
@@ -3,6 +3,7 @@
           title={label}
           aria-label={label}
           aria-pressed={pressable ? !!pressed : void 0}
+          aria-hidden={ariaHidden}
           class={computedClass}
           {disabled}
           delegate-key={delegateKey}
@@ -16,6 +17,7 @@
           title={label}
           aria-label={label}
           aria-pressed={pressable ? !!pressed : void 0}
+          aria-hidden={ariaHidden}
           class={computedClass}
           focus-key={focusKey || ''}
           {disabled}
@@ -117,7 +119,8 @@
       pressed: false,
       className: void 0,
       delegateKey: void 0,
-      sameColorWhenPressed: false
+      sameColorWhenPressed: false,
+      ariaHidden: false
     }),
     store: () => store,
     computed: {
diff --git a/src/routes/_components/dialog/components/MediaDialog.html b/src/routes/_components/dialog/components/MediaDialog.html
index dfa5743..fadae0d 100644
--- a/src/routes/_components/dialog/components/MediaDialog.html
+++ b/src/routes/_components/dialog/components/MediaDialog.html
@@ -29,6 +29,7 @@
           className="media-control-button media-control-button-dummy-spacer"
           href="#fa-search"
           label=""
+          ariaHidden={true}
         />
       {/if}
       {#if dots.length > 1}
diff --git a/src/routes/_components/dialog/components/PinchZoomable.html b/src/routes/_components/dialog/components/PinchZoomable.html
index cdd7870..3f38a67 100644
--- a/src/routes/_components/dialog/components/PinchZoomable.html
+++ b/src/routes/_components/dialog/components/PinchZoomable.html
@@ -8,6 +8,7 @@
     label="Zoom out"
     href="#fa-search-minus"
     on:click="zoomOut()"
+    ariaHidden={disabled}
   />
   <IconButton
     className="pinch-zoom-button pinch-zoom-button-zoom-in"
@@ -15,6 +16,7 @@
     label="Zoom in"
     href="#fa-search-plus"
     on:click="zoomIn()"
+    ariaHidden={disabled}
   />
 </div>
 <style>