From e75dc0c4085103358e8f639bfe5228570329f002 Mon Sep 17 00:00:00 2001 From: Zhenchao Li Date: Thu, 15 Jul 2010 14:32:34 +0800 Subject: [PATCH] fix incorrect use of jid where account name should be used as parameter --- src/common/jingle_ft.py | 12 +++++------- src/common/protocol/bytestream.py | 3 +-- src/gui_interface.py | 2 +- 3 files changed, 7 insertions(+), 10 deletions(-) diff --git a/src/common/jingle_ft.py b/src/common/jingle_ft.py index fb6b43c7e..3dcc09c0e 100644 --- a/src/common/jingle_ft.py +++ b/src/common/jingle_ft.py @@ -169,13 +169,12 @@ class JingleFileTransfer(JingleContent): self.file_props['is_a_proxy'] = True receiver = Socks5Receiver(gajim.idlequeue, streamhost_used, self.file_props['sid'], self.file_props) - #gajim.socks5queue.add_file_props(self.session.ourjid, self.file_props) - gajim.socks5queue.add_receiver(self.session.ourjid, receiver) + gajim.socks5queue.add_receiver(self.session.connection.name, receiver) streamhost_used['idx'] = receiver.queue_idx gajim.socks5queue.on_success = self.transport._on_proxy_auth_ok else: jid = gajim.get_jid_without_resource(self.session.ourjid) - gajim.socks5queue.send_file(self.file_props, jid) + gajim.socks5queue.send_file(self.file_props, self.session.connection.name) def __on_iq_result(self, stanza, content, error, action): log.info("__on_iq_result") @@ -199,10 +198,9 @@ class JingleFileTransfer(JingleContent): # send error message, notify the user elif not self.weinitiate and self.state == STATE_NOT_STARTED: # session-accept iq-result self.state = STATE_ACCEPTED - if not gajim.socks5queue.get_file_props(self.session.ourjid, self.file_props['sid']): - gajim.socks5queue.add_file_props(self.session.ourjid, self.file_props) - jid = gajim.get_jid_without_resource(self.session.ourjid) - gajim.socks5queue.connect_to_hosts(jid, self.file_props['sid'], + if not gajim.socks5queue.get_file_props(self.session.connection.name, self.file_props['sid']): + gajim.socks5queue.add_file_props(self.session.connection.name, self.file_props) + gajim.socks5queue.connect_to_hosts(self.session.connection.name, self.file_props['sid'], self.send_candidate_used, self._on_connect_error) elif not self.weinitiate and self.state == STATE_ACCEPTED: # transport-info iq-result self.state = STATE_TRANSPORT_INFO diff --git a/src/common/protocol/bytestream.py b/src/common/protocol/bytestream.py index a1ed9d593..ff0bd6599 100644 --- a/src/common/protocol/bytestream.py +++ b/src/common/protocol/bytestream.py @@ -138,8 +138,7 @@ class ConnectionBytestream: jid = gajim.get_jid_without_resource(file_props['sender']) resource = gajim.get_resource_from_jid(file_props['sender']) sid = file_props['sid'] - wr_ourjid = gajim.get_jid_without_resource(session.ourjid) - gajim.socks5queue.add_file_props(wr_ourjid, file_props) + gajim.socks5queue.add_file_props(self.name, file_props) if not session.accepted: session.approve_session() diff --git a/src/gui_interface.py b/src/gui_interface.py index 4a63b5a82..9f77390d3 100644 --- a/src/gui_interface.py +++ b/src/gui_interface.py @@ -1510,7 +1510,7 @@ class Interface: # send session-terminate stanza if 'session-type' in file_props and file_props['session-type'] == 'jingle': sender = gajim.get_jid_without_resource(file_props['sender']) - jingle_session = gajim.connections[sender].get_jingle_session(sender, file_props['sid']) + jingle_session = gajim.connections[account].get_jingle_session(sender, file_props['sid']) jingle_session.end_session() path = gtkgui_helpers.get_icon_path(img_name, 48) else: