From e501754aabb7309f55a0fe9ca9619a5690069f3a Mon Sep 17 00:00:00 2001 From: Alexander Cherniuk Date: Tue, 23 Mar 2010 09:31:52 +0200 Subject: [PATCH] Improved sending a DTMF batch --- src/common/jingle_rtp.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/common/jingle_rtp.py b/src/common/jingle_rtp.py index 2de70516b..ae53adcac 100644 --- a/src/common/jingle_rtp.py +++ b/src/common/jingle_rtp.py @@ -121,16 +121,17 @@ class JingleRTPContent(JingleContent): Send several DTMF tones """ if self._dtmf_running: - raise Exception # TODO: Proper exception + raise Exception("There is a DTMF batch already running") + events = list(events) self._dtmf_running = True - self._start_dtmf(events[-1]) - gobject.timeout_add(500, self._next_dtmf, events[:-1]) + self._start_dtmf(events.pop(0)) + gobject.timeout_add(500, self._next_dtmf, events) def _next_dtmf(self, events): self._stop_dtmf() if events: - self._start_dtmf(events[-1]) - gobject.timeout_add(500, self._next_dtmf, events[:-1]) + self._start_dtmf(events.pop(0)) + gobject.timeout_add(500, self._next_dtmf, events) else: self._dtmf_running = False