From 64487929a6222153c9cfd846b7588bf73d4fbf70 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Philipp=20H=C3=B6rist?= <forenjunkie@chello.at>
Date: Tue, 18 Sep 2018 16:44:23 +0200
Subject: [PATCH] Fix pylint errors

- pointless-statement
- pointless-string-statement
- unnecessary-lambda
---
 gajim/common/app.py           | 14 ++++++--------
 gajim/filetransfers_window.py |  2 +-
 gajim/gtk/profile.py          |  2 +-
 gajim/gui_menu_builder.py     |  4 ----
 4 files changed, 8 insertions(+), 14 deletions(-)

diff --git a/gajim/common/app.py b/gajim/common/app.py
index d03f9aebe..27a036483 100644
--- a/gajim/common/app.py
+++ b/gajim/common/app.py
@@ -188,14 +188,12 @@ def detect_dependencies():
     # python-gnupg
     try:
         import gnupg
-        '''
-        We need https://pypi.python.org/pypi/python-gnupg
-        but https://pypi.python.org/pypi/gnupg shares the same package name.
-        It cannot be used as a drop-in replacement.
-        We test with a version check if python-gnupg is installed as it is
-        on a much lower version number than gnupg
-        Also we need at least python-gnupg 0.3.8
-        '''
+        # We need https://pypi.python.org/pypi/python-gnupg
+        # but https://pypi.python.org/pypi/gnupg shares the same package name.
+        # It cannot be used as a drop-in replacement.
+        # We test with a version check if python-gnupg is installed as it is
+        # on a much lower version number than gnupg
+        # Also we need at least python-gnupg 0.3.8
         v_gnupg = gnupg.__version__
         if V(v_gnupg) < V('0.3.8') or V(v_gnupg) > V('1.0.0'):
             log('gajim').info('Gajim needs python-gnupg >= 0.3.8')
diff --git a/gajim/filetransfers_window.py b/gajim/filetransfers_window.py
index 649fa9146..82540bb72 100644
--- a/gajim/filetransfers_window.py
+++ b/gajim/filetransfers_window.py
@@ -466,7 +466,7 @@ class FileTransfersWindow:
         iter_ = self.get_iter_by_sid(file_props.type_, file_props.sid)
         if iter_ is None:
             return
-        self.model[iter_][Column.SID]
+
         if status == 'stop':
             file_props.stopped = True
         elif status == 'ok':
diff --git a/gajim/gtk/profile.py b/gajim/gtk/profile.py
index 6f7137a83..4b5db96ac 100644
--- a/gajim/gtk/profile.py
+++ b/gajim/gtk/profile.py
@@ -185,7 +185,7 @@ class ProfileWindow(Gtk.ApplicationWindow):
                     pritext,
                     _('Format of the date must be YYYY-MM-DD'),
                     transient_for=self)
-                GLib.idle_add(lambda: widget.grab_focus())
+                GLib.idle_add(widget.grab_focus)
             return True
 
     def set_value(self, entry_name, value):
diff --git a/gajim/gui_menu_builder.py b/gajim/gui_menu_builder.py
index 515f79f0d..c8ce28d63 100644
--- a/gajim/gui_menu_builder.py
+++ b/gajim/gui_menu_builder.py
@@ -594,10 +594,6 @@ def get_transport_menu(contact, account):
     menu.show_all()
     return menu
 
-'''
-Build dynamic Application Menus
-'''
-
 
 def get_singlechat_menu(control_id):
     singlechat_menu = [