From cb38d57053dc52efa98ce0adee2be4b5a60b640d Mon Sep 17 00:00:00 2001 From: Robbie Antenesse Date: Wed, 17 Jul 2019 11:33:02 -0600 Subject: [PATCH] Improve spacing for headers and labels --- src/js/render/details.js | 10 +++++----- src/scss/_elements.scss | 9 +++++---- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/src/js/render/details.js b/src/js/render/details.js index 2aa05f0..606558b 100644 --- a/src/js/render/details.js +++ b/src/js/render/details.js @@ -54,14 +54,14 @@ export function renderDetails() { const alphabeticalOrderHTML = `

Alphabetical Order
${ (alphabeticalOrder.length > 0 ? alphabeticalOrder : ['English Alphabet']).map(letter => `${letter}`).join(' ') }`; - const generalHTML = `

General

${partsOfSpeechHTML}${alphabeticalOrderHTML}`; + const generalHTML = `

General

${partsOfSpeechHTML}${alphabeticalOrderHTML}`; const { consonants, vowels, blends } = phonology const consonantHTML = `

Consonants
${consonants.map(letter => `${letter}`).join(' ')}

`; const vowelHTML = `

Vowels
${vowels.map(letter => `${letter}`).join(' ')}

`; const blendHTML = blends.length > 0 ? `

Polyphthongs / Blends
${blends.map(letter => `${letter}`).join(' ')}

` : ''; const phonologyNotesHTML = phonology.notes.trim().length > 0 ? '

Notes

' + md(removeTags(phonology.notes)) + '
' : ''; - const phonologyHTML = `

Phonology

+ const phonologyHTML = `

Phonology

${consonantHTML}
${vowelHTML}
@@ -75,7 +75,7 @@ export function renderDetails() { const codaHTML = `

Coda
${coda.map(letter => `${letter}`).join(' ')}

`; const phonotacticsNotesHTML = phonotactics.notes.trim().length > 0 ? '

Notes

' + md(removeTags(phonotactics.notes)) + '
' : ''; const phonotacticsHTML = onset.length + nucleus.length + coda.length + phonotacticsNotesHTML.length > 0 - ? `

Phonotactics

+ ? `

Phonotactics

${onset.length > 0 || nucleus.length > 0 || coda.length > 0 ? `
${onsetHTML}
@@ -95,11 +95,11 @@ export function renderDetails() { }).filter(html => html !== false).join(' ')}

` : ''; const orthographyNotesHTML = orthography.notes.trim().length > 0 ? '

Notes
' + md(removeTags(orthography.notes)) + '

' : ''; const orthographyHTML = translations.length + orthographyNotesHTML.length > 0 - ? `

Orthography

+ ? `

Orthography

${translationsHTML} ${orthographyNotesHTML}` : ''; - const grammarHTML = grammar.notes.trim().length > 0 ? '

Grammar

' + const grammarHTML = grammar.notes.trim().length > 0 ? '

Grammar

' + (grammar.notes.trim().length > 0 ? md(removeTags(grammar.notes)) : '') + '
' : ''; diff --git a/src/scss/_elements.scss b/src/scss/_elements.scss index c2addc9..b310cdb 100644 --- a/src/scss/_elements.scss +++ b/src/scss/_elements.scss @@ -8,6 +8,10 @@ p, span { } } +h2 { + margin-bottom: 5px; +} + input:not([type="checkbox"]), select, textarea { @@ -19,10 +23,7 @@ label { font-weight: bold; line-height: 120%; cursor: pointer; - - &:not(:last-child) { - margin-bottom: $general-padding; - } + margin-bottom: $general-padding; small { font-weight: normal;